diff mbox series

[v1,2/3] dt-bindings: net: bluetooth: Add device tree bindings for QTI bluetooth MAPLE

Message ID 1635837069-1293-1-git-send-email-zijuhu@codeaurora.org (mailing list archive)
State Rejected
Headers show
Series [v1,1/3] serdev: Add interface serdev_device_ioctl | expand

Checks

Context Check Description
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint fail [v1,2/3] dt-bindings: net: bluetooth: Add device tree bindings for QTI bluetooth MAPLE 1: T1 Title exceeds max length (86>80): "[v1,2/3] dt-bindings: net: bluetooth: Add device tree bindings for QTI bluetooth MAPLE"

Commit Message

Zijun Hu Nov. 2, 2021, 7:11 a.m. UTC
From: Zijun Hu <quic_zijuhu@quicinc.com>

Add device tree bindings for QTI bluetooth MAPLE.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring Nov. 12, 2021, 5:02 p.m. UTC | #1
On Tue, Nov 02, 2021 at 03:11:09PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>

Subject space is valuable, don't say things twice:

dt-bindings: net: bluetooth: Add Qualcomm MAPLE

Is MAPLE an SoC? Everything else used part numbers, why not here?

> 
> Add device tree bindings for QTI bluetooth MAPLE.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> index f93c6e7a1b59..9f0508c4dd16 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> @@ -23,6 +23,7 @@ properties:
>        - qcom,wcn3998-bt
>        - qcom,qca6390-bt
>        - qcom,wcn6750-bt
> +      - qcom,maple-bt
>  
>    enable-gpios:
>      maxItems: 1
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
> 
>
Zijun Hu Nov. 14, 2021, 12:34 p.m. UTC | #2
On 2021-11-13 01:02, Rob Herring wrote:
> On Tue, Nov 02, 2021 at 03:11:09PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> Subject space is valuable, don't say things twice:
> 
> dt-bindings: net: bluetooth: Add Qualcomm MAPLE
> 
> Is MAPLE an SoC? Everything else used part numbers, why not here?
> 
thanks for your reply, please ignore this patch bcz part of the patch 
series is refused.

MAPLE is a name of BT controller which is integrated within a Soc, so it 
doesn't regular part number.

>> 
>> Add device tree bindings for QTI bluetooth MAPLE.
>> 
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
>> ---
>>  Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml 
>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>> index f93c6e7a1b59..9f0508c4dd16 100644
>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>> @@ -23,6 +23,7 @@ properties:
>>        - qcom,wcn3998-bt
>>        - qcom,qca6390-bt
>>        - qcom,wcn6750-bt
>> +      - qcom,maple-bt
>> 
>>    enable-gpios:
>>      maxItems: 1
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum, a Linux Foundation Collaborative Project
>> 
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
index f93c6e7a1b59..9f0508c4dd16 100644
--- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
@@ -23,6 +23,7 @@  properties:
       - qcom,wcn3998-bt
       - qcom,qca6390-bt
       - qcom,wcn6750-bt
+      - qcom,maple-bt
 
   enable-gpios:
     maxItems: 1