diff mbox series

[v4] Bluetooth: hci_qca: Stop IBS timer during BT OFF

Message ID 1640158145-24569-1-git-send-email-quic_pharish@quicinc.com (mailing list archive)
State Accepted
Commit be762b7655741f6a5934c158edb5747093cf068e
Headers show
Series [v4] Bluetooth: hci_qca: Stop IBS timer during BT OFF | expand

Checks

Context Check Description
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint fail [v4] Bluetooth: hci_qca: Stop IBS timer during BT OFF 7: B1 Line exceeds max length (92>80): "Fixes: 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990")"
tedd_an/buildkernel success Build Kernel PASS
tedd_an/incremental_build success Pass
tedd_an/testrunnersetup success Test Runner Setup PASS
tedd_an/testrunnerl2cap-tester success Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerbnep-tester success Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnermgmt-tester success Total: 493, Passed: 493 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerrfcomm-tester success Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersco-tester success Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersmp-tester success Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneruserchan-tester success Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

Commit Message

Panicker Harish Dec. 22, 2021, 7:29 a.m. UTC 
The IBS timers are not stopped properly once BT OFF is triggered.
we could see IBS commands being sent along with version command,
so stopped IBS timers while Bluetooth is off.

Fixes: 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990")

Signed-off-by: Panicker Harish <quic_pharish@quicinc.com>
----
v4:
  * Used del_timer_sync() instead of mod_timer() to stop the timer and
    to make sure the handler has finished executing on other CPUs.

v3:
  *Addressed reviewers comments
  *updated commit message

v2:
  * Addressed the username
  * The full implementation of IBS is based on timers
    to that reason we have used timers.

v1: initial patch
---
 drivers/bluetooth/hci_qca.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Marcel Holtmann Dec. 22, 2021, 8:33 a.m. UTC | #1 
Hi Panicker,

> The IBS timers are not stopped properly once BT OFF is triggered.
> we could see IBS commands being sent along with version command,
> so stopped IBS timers while Bluetooth is off.
> 
> Fixes: 3e4be65eb82c ("Bluetooth: hci_qca: Add poweroff support during hci down for wcn3990")
> 
> Signed-off-by: Panicker Harish <quic_pharish@quicinc.com>
> ----
> v4:
>  * Used del_timer_sync() instead of mod_timer() to stop the timer and
>    to make sure the handler has finished executing on other CPUs.
> 
> v3:
>  *Addressed reviewers comments
>  *updated commit message
> 
> v2:
>  * Addressed the username
>  * The full implementation of IBS is based on timers
>    to that reason we have used timers.
> 
> v1: initial patch
> ---
> drivers/bluetooth/hci_qca.c | 3 +++
> 1 file changed, 3 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel
diff mbox series

Patch

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index dd768a8..9e99311 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1928,6 +1928,9 @@  static int qca_power_off(struct hci_dev *hdev)
 	hu->hdev->hw_error = NULL;
 	hu->hdev->cmd_timeout = NULL;
 
+	del_timer_sync(&qca->wake_retrans_timer);
+	del_timer_sync(&qca->tx_idle_timer);
+
 	/* Stop sending shutdown command if soc crashes. */
 	if (soc_type != QCA_ROME
 		&& qca->memdump_state == QCA_MEMDUMP_IDLE) {