diff mbox series

[v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask

Message ID 1657695194-25801-1-git-send-email-quic_zijuhu@quicinc.com (mailing list archive)
State Accepted
Commit f7913b8db3c4fe3ff39f541703d1354a2f0b276a
Headers show
Series [v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/subjectprefix success PASS
tedd_an/buildkernel success Build Kernel PASS
tedd_an/buildkernel32 success Build Kernel32 PASS
tedd_an/incremental_build success Pass
tedd_an/testrunnersetup success Test Runner Setup PASS
tedd_an/testrunnerl2cap-tester success Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerbnep-tester success Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnermgmt-tester success Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerrfcomm-tester success Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersco-tester success Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersmp-tester success Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneruserchan-tester success Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

Commit Message

quic_zijuhu July 13, 2022, 6:53 a.m. UTC
Event HCI_Truncated_Page_Complete should belong to central
and HCI_Peripheral_Page_Response_Timeout should belong to
peripheral, but hci_set_event_mask_page_2_sync() take these
two events for wrong roles, so correct it by this change.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 net/bluetooth/hci_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

bluez.test.bot@gmail.com July 13, 2022, 7:56 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=659174

---Test result---

Test Summary:
CheckPatch                    PASS      1.85 seconds
GitLint                       PASS      0.94 seconds
SubjectPrefix                 PASS      0.82 seconds
BuildKernel                   PASS      29.89 seconds
BuildKernel32                 PASS      25.76 seconds
Incremental Build with patchesPASS      35.02 seconds
TestRunner: Setup             PASS      429.54 seconds
TestRunner: l2cap-tester      PASS      16.44 seconds
TestRunner: bnep-tester       PASS      5.55 seconds
TestRunner: mgmt-tester       PASS      90.61 seconds
TestRunner: rfcomm-tester     PASS      8.67 seconds
TestRunner: sco-tester        PASS      8.44 seconds
TestRunner: smp-tester        PASS      8.60 seconds
TestRunner: userchan-tester   PASS      5.68 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org July 20, 2022, 4:50 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 13 Jul 2022 14:53:14 +0800 you wrote:
> Event HCI_Truncated_Page_Complete should belong to central
> and HCI_Peripheral_Page_Response_Timeout should belong to
> peripheral, but hci_set_event_mask_page_2_sync() take these
> two events for wrong roles, so correct it by this change.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask
    https://git.kernel.org/bluetooth/bluetooth-next/c/f7913b8db3c4

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 7cb310051879..c72533bb9834 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3602,7 +3602,7 @@  static int hci_set_event_mask_page_2_sync(struct hci_dev *hdev)
 	if (lmp_cpb_central_capable(hdev)) {
 		events[1] |= 0x40;	/* Triggered Clock Capture */
 		events[1] |= 0x80;	/* Synchronization Train Complete */
-		events[2] |= 0x10;	/* Peripheral Page Response Timeout */
+		events[2] |= 0x08;	/* Truncated Page Complete */
 		events[2] |= 0x20;	/* CPB Channel Map Change */
 		changed = true;
 	}
@@ -3614,7 +3614,7 @@  static int hci_set_event_mask_page_2_sync(struct hci_dev *hdev)
 		events[2] |= 0x01;	/* Synchronization Train Received */
 		events[2] |= 0x02;	/* CPB Receive */
 		events[2] |= 0x04;	/* CPB Timeout */
-		events[2] |= 0x08;	/* Truncated Page Complete */
+		events[2] |= 0x10;	/* Peripheral Page Response Timeout */
 		changed = true;
 	}