[v1,1/2] Bluetooth: hci_qca: Add qcomm devcoredump sysfs support

Commit Message

Sai Teja Aluvala May 1, 2023, noon UTC

This patch implements the hci_qca driver side .coredump() callback to
trigger a devcoredump via sysfs

Signed-off-by: Sai Teja Aluvala <[e-mail]>
Reviewed-by: Manish Mandlik <[e-mail]>
v1:Initial Patch
---
 drivers/bluetooth/hci_qca.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

[e-mail] May 1, 2023, 12:39 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=744132

---Test result---

Test Summary:
CheckPatch                    PASS      1.34 seconds
GitLint                       PASS      0.57 seconds
SubjectPrefix                 PASS      0.20 seconds
BuildKernel                   FAIL      27.06 seconds
CheckAllWarning               FAIL      29.49 seconds
CheckSparse                   FAIL      33.02 seconds
CheckSmatch                   FAIL      89.25 seconds
BuildKernel32                 FAIL      25.92 seconds
TestRunnerSetup               PASS      451.81 seconds
TestRunner_l2cap-tester       PASS      16.54 seconds
TestRunner_iso-tester         PASS      20.42 seconds
TestRunner_bnep-tester        PASS      5.33 seconds
TestRunner_mgmt-tester        PASS      112.23 seconds
TestRunner_rfcomm-tester      PASS      8.61 seconds
TestRunner_sco-tester         PASS      7.86 seconds
TestRunner_ioctl-tester       PASS      9.12 seconds
TestRunner_mesh-tester        PASS      6.83 seconds
TestRunner_smp-tester         PASS      7.79 seconds
TestRunner_userchan-tester    PASS      5.64 seconds
IncrementalBuild              FAIL      35.49 seconds

Details
##############################
Test: BuildKernel - FAIL
Desc: Build Kernel for Bluetooth
Output:

drivers/bluetooth/hci_qca.c: In function ‘qca_setup’:
drivers/bluetooth/hci_qca.c:1903:45: error: passing argument 3 of ‘hci_devcd_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
 1903 |  hci_devcd_register(hdev, hci_coredump_qca, qca_dmp_hdr, NULL);
      |                                             ^~~~~~~~~~~
      |                                             |
      |                                             int (*)(struct hci_dev *, char *, size_t) {aka int (*)(struct hci_dev *, char *, long unsigned int)}
In file included from ./include/net/bluetooth/hci_core.h:36,
                 from drivers/bluetooth/hci_qca.c:37:
./include/net/bluetooth/coredump.h:68:20: note: expected ‘dmp_hdr_t’ {aka ‘void (*)(struct hci_dev *, struct sk_buff *)’} but argument is of type ‘int (*)(struct hci_dev *, char *, size_t)’ {aka ‘int (*)(struct hci_dev *, char *, long unsigned int)’}
   68 |          dmp_hdr_t dmp_hdr, notify_change_t notify_change);
      |          ~~~~~~~~~~^~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:252: drivers/bluetooth/hci_qca.o] Error 1
make[2]: *** [scripts/Makefile.build:494: drivers/bluetooth] Error 2
make[1]: *** [scripts/Makefile.build:494: drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:2025: .] Error 2
##############################
Test: CheckAllWarning - FAIL
Desc: Run linux kernel with all warning enabled
Output:

drivers/bluetooth/hci_qca.c: In function ‘qca_setup’:
drivers/bluetooth/hci_qca.c:1903:45: error: passing argument 3 of ‘hci_devcd_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
 1903 |  hci_devcd_register(hdev, hci_coredump_qca, qca_dmp_hdr, NULL);
      |                                             ^~~~~~~~~~~
      |                                             |
      |                                             int (*)(struct hci_dev *, char *, size_t) {aka int (*)(struct hci_dev *, char *, long unsigned int)}
In file included from ./include/net/bluetooth/hci_core.h:36,
                 from drivers/bluetooth/hci_qca.c:37:
./include/net/bluetooth/coredump.h:68:20: note: expected ‘dmp_hdr_t’ {aka ‘void (*)(struct hci_dev *, struct sk_buff *)’} but argument is of type ‘int (*)(struct hci_dev *, char *, size_t)’ {aka ‘int (*)(struct hci_dev *, char *, long unsigned int)’}
   68 |          dmp_hdr_t dmp_hdr, notify_change_t notify_change);
      |          ~~~~~~~~~~^~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:252: drivers/bluetooth/hci_qca.o] Error 1
make[2]: *** [scripts/Makefile.build:494: drivers/bluetooth] Error 2
make[1]: *** [scripts/Makefile.build:494: drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:2025: .] Error 2
##############################
Test: CheckSparse - FAIL
Desc: Run sparse tool with linux kernel
Output:

net/bluetooth/af_bluetooth.c:178:25: warning: context imbalance in 'bt_accept_enqueue' - different lock contexts for basic block
drivers/bluetooth/hci_qca.c: In function ‘qca_setup’:
drivers/bluetooth/hci_qca.c:1903:45: error: passing argument 3 of ‘hci_devcd_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
 1903 |  hci_devcd_register(hdev, hci_coredump_qca, qca_dmp_hdr, NULL);
      |                                             ^~~~~~~~~~~
      |                                             |
      |                                             int (*)(struct hci_dev *, char *, size_t) {aka int (*)(struct hci_dev *, char *, long unsigned int)}
In file included from ./include/net/bluetooth/hci_core.h:36,
                 from drivers/bluetooth/hci_qca.c:37:
./include/net/bluetooth/coredump.h:68:20: note: expected ‘dmp_hdr_t’ {aka ‘void (*)(struct hci_dev *, struct sk_buff *)’} but argument is of type ‘int (*)(struct hci_dev *, char *, size_t)’ {aka ‘int (*)(struct hci_dev *, char *, long unsigned int)’}
   68 |          dmp_hdr_t dmp_hdr, notify_change_t notify_change);
      |          ~~~~~~~~~~^~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:252: drivers/bluetooth/hci_qca.o] Error 1
make[2]: *** [scripts/Makefile.build:494: drivers/bluetooth] Error 2
make[1]: *** [scripts/Makefile.build:494: drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
./include/net/bluetooth/hci.h:2646:47: warning: array of flexible structures
./include/net/bluetooth/hci.h:2732:43: warning: array of flexible structures
net/bluetooth/hci_codec.c: note: in included file:
./include/net/bluetooth/hci_core.h:150:35: warning: array of flexible structures
net/bluetooth/sco.c: note: in included file:
./include/net/bluetooth/hci_core.h:150:35: warning: array of flexible structures
make: *** [Makefile:2025: .] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

drivers/bluetooth/hci_qca.c: In function ‘qca_setup’:
drivers/bluetooth/hci_qca.c:1903:45: error: passing argument 3 of ‘hci_devcd_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
 1903 |  hci_devcd_register(hdev, hci_coredump_qca, qca_dmp_hdr, NULL);
      |                                             ^~~~~~~~~~~
      |                                             |
      |                                             int (*)(struct hci_dev *, char *, size_t) {aka int (*)(struct hci_dev *, char *, long unsigned int)}
In file included from ./include/net/bluetooth/hci_core.h:36,
                 from drivers/bluetooth/hci_qca.c:37:
./include/net/bluetooth/coredump.h:68:20: note: expected ‘dmp_hdr_t’ {aka ‘void (*)(struct hci_dev *, struct sk_buff *)’} but argument is of type ‘int (*)(struct hci_dev *, char *, size_t)’ {aka ‘int (*)(struct hci_dev *, char *, long unsigned int)’}
   68 |          dmp_hdr_t dmp_hdr, notify_change_t notify_change);
      |          ~~~~~~~~~~^~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:252: drivers/bluetooth/hci_qca.o] Error 1
make[2]: *** [scripts/Makefile.build:494: drivers/bluetooth] Error 2
make[1]: *** [scripts/Makefile.build:494: drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
./include/net/bluetooth/hci.h:2646:47: warning: array of flexible structures
./include/net/bluetooth/hci.h:2732:43: warning: array of flexible structures
net/bluetooth/hci_codec.c: note: in included file:
./include/net/bluetooth/hci_core.h:150:35: warning: array of flexible structures
net/bluetooth/sco.c: note: in included file:
./include/net/bluetooth/hci_core.h:150:35: warning: array of flexible structures
make: *** [Makefile:2025: .] Error 2
##############################
Test: BuildKernel32 - FAIL
Desc: Build 32bit Kernel for Bluetooth
Output:

drivers/bluetooth/hci_qca.c: In function ‘qca_setup’:
drivers/bluetooth/hci_qca.c:1903:45: error: passing argument 3 of ‘hci_devcd_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
 1903 |  hci_devcd_register(hdev, hci_coredump_qca, qca_dmp_hdr, NULL);
      |                                             ^~~~~~~~~~~
      |                                             |
      |                                             int (*)(struct hci_dev *, char *, size_t) {aka int (*)(struct hci_dev *, char *, unsigned int)}
In file included from ./include/net/bluetooth/hci_core.h:36,
                 from drivers/bluetooth/hci_qca.c:37:
./include/net/bluetooth/coredump.h:68:20: note: expected ‘dmp_hdr_t’ {aka ‘void (*)(struct hci_dev *, struct sk_buff *)’} but argument is of type ‘int (*)(struct hci_dev *, char *, size_t)’ {aka ‘int (*)(struct hci_dev *, char *, unsigned int)’}
   68 |          dmp_hdr_t dmp_hdr, notify_change_t notify_change);
      |          ~~~~~~~~~~^~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:252: drivers/bluetooth/hci_qca.o] Error 1
make[2]: *** [scripts/Makefile.build:494: drivers/bluetooth] Error 2
make[1]: *** [scripts/Makefile.build:494: drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:2025: .] Error 2
##############################
Test: IncrementalBuild - FAIL
Desc: Incremental build with the patches in the series
Output:
[v1,2/2] Bluetooth: hci_qca: Add qcomm devcoredump support

drivers/bluetooth/hci_qca.c: In function ‘qca_setup’:
drivers/bluetooth/hci_qca.c:1903:45: error: passing argument 3 of ‘hci_devcd_register’ from incompatible pointer type [-Werror=incompatible-pointer-types]
 1903 |  hci_devcd_register(hdev, hci_coredump_qca, qca_dmp_hdr, NULL);
      |                                             ^~~~~~~~~~~
      |                                             |
      |                                             int (*)(struct hci_dev *, char *, size_t) {aka int (*)(struct hci_dev *, char *, long unsigned int)}
In file included from ./include/net/bluetooth/hci_core.h:36,
                 from drivers/bluetooth/hci_qca.c:37:
./include/net/bluetooth/coredump.h:68:20: note: expected ‘dmp_hdr_t’ {aka ‘void (*)(struct hci_dev *, struct sk_buff *)’} but argument is of type ‘int (*)(struct hci_dev *, char *, size_t)’ {aka ‘int (*)(struct hci_dev *, char *, long unsigned int)’}
   68 |          dmp_hdr_t dmp_hdr, notify_change_t notify_change);
      |          ~~~~~~~~~~^~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:252: drivers/bluetooth/hci_qca.o] Error 1
make[2]: *** [scripts/Makefile.build:494: drivers/bluetooth] Error 2
make[1]: *** [scripts/Makefile.build:494: drivers] Error 2
make: *** [Makefile:2025: .] Error 2


---
Regards,
Linux Bluetooth

Patch

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 1b06450..ca98f6d 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -2380,6 +2380,18 @@  static const struct acpi_device_id qca_bluetooth_acpi_match[] = {
 MODULE_DEVICE_TABLE(acpi, qca_bluetooth_acpi_match);
 #endif
 
+#ifdef CONFIG_DEV_COREDUMP
+static void hciqca_coredump(struct device *dev)
+{
+	struct serdev_device *serdev = to_serdev_device(dev);
+	struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
+	struct hci_uart *hu = &qcadev->serdev_hu;
+	struct hci_dev  *hdev = hu->hdev;
+
+	if (hdev->dump.coredump)
+		hdev->dump.coredump(hdev);
+}
+#endif
 
 static struct serdev_device_driver qca_serdev_driver = {
 	.probe = qca_serdev_probe,
@@ -2390,6 +2402,9 @@  static struct serdev_device_driver qca_serdev_driver = {
 		.acpi_match_table = ACPI_PTR(qca_bluetooth_acpi_match),
 		.shutdown = qca_serdev_shutdown,
 		.pm = &qca_pm_ops,
+#ifdef CONFIG_DEV_COREDUMP
+		.coredump = hciqca_coredump,
+#endif
 	},
 };