[RESEND,v3,1/2] Bluetooth: hci_qca: Add qcom devcoredump sysfs support

Commit Message

Sai Teja Aluvala June 14, 2023, 4:58 a.m. UTC

This patch implements the hci_qca driver side .coredump() callback to
trigger a devcoredump via sysfs.

Signed-off-by: Sai Teja Aluvala <[e-mail]>

v2 -> V3:
--------
Updated commit text

v1 -> V2:
--------
Updated to work with the updated HCI devcoredump API.
---
 drivers/bluetooth/hci_qca.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

[e-mail] June 14, 2023, 5:37 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=756942

---Test result---

Test Summary:
CheckPatch                    PASS      1.57 seconds
GitLint                       PASS      0.63 seconds
SubjectPrefix                 PASS      0.21 seconds
BuildKernel                   PASS      42.25 seconds
CheckAllWarning               PASS      44.82 seconds
CheckSparse                   PASS      51.92 seconds
CheckSmatch                   PASS      139.51 seconds
BuildKernel32                 PASS      40.26 seconds
TestRunnerSetup               PASS      573.20 seconds
TestRunner_l2cap-tester       PASS      20.76 seconds
TestRunner_iso-tester         PASS      30.31 seconds
TestRunner_bnep-tester        PASS      7.26 seconds
TestRunner_mgmt-tester        PASS      141.61 seconds
TestRunner_rfcomm-tester      PASS      11.10 seconds
TestRunner_sco-tester         PASS      10.71 seconds
TestRunner_ioctl-tester       PASS      12.69 seconds
TestRunner_mesh-tester        PASS      9.25 seconds
TestRunner_smp-tester         PASS      10.17 seconds
TestRunner_userchan-tester    PASS      7.47 seconds
IncrementalBuild              PASS      45.20 seconds



---
Regards,
Linux Bluetooth

[e-mail] June 20, 2023, 6:30 p.m. UTC | #2

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Wed, 14 Jun 2023 10:28:15 +0530 you wrote:
> This patch implements the hci_qca driver side .coredump() callback to
> trigger a devcoredump via sysfs.
> 
> Signed-off-by: Sai Teja Aluvala <[e-mail]>
> 
> v2 -> V3:
> 
> [...]

Here is the summary with links:
  - [RESEND,v3,1/2] Bluetooth: hci_qca: Add qcom devcoredump sysfs support
    https://git.kernel.org/bluetooth/bluetooth-next/c/79e5531b19fa
  - [RESEND,v3,2/2] Bluetooth: hci_qca: Add qcom devcoredump support
    https://git.kernel.org/bluetooth/bluetooth-next/c/97604e9492ce

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index e30c979..1ee5323 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -2384,6 +2384,18 @@  static const struct acpi_device_id qca_bluetooth_acpi_match[] = {
 MODULE_DEVICE_TABLE(acpi, qca_bluetooth_acpi_match);
 #endif
 
+#ifdef CONFIG_DEV_COREDUMP
+static void hciqca_coredump(struct device *dev)
+{
+	struct serdev_device *serdev = to_serdev_device(dev);
+	struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
+	struct hci_uart *hu = &qcadev->serdev_hu;
+	struct hci_dev  *hdev = hu->hdev;
+
+	if (hdev->dump.coredump)
+		hdev->dump.coredump(hdev);
+}
+#endif
 
 static struct serdev_device_driver qca_serdev_driver = {
 	.probe = qca_serdev_probe,
@@ -2394,6 +2406,9 @@  static struct serdev_device_driver qca_serdev_driver = {
 		.acpi_match_table = ACPI_PTR(qca_bluetooth_acpi_match),
 		.shutdown = qca_serdev_shutdown,
 		.pm = &qca_pm_ops,
+#ifdef CONFIG_DEV_COREDUMP
+		.coredump = hciqca_coredump,
+#endif
 	},
 };