| Message ID | 1690789604-3576-1-git-send-email-quic_zijuhu@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 446d8ada5790e5ca2cdc359eafa4bf7136b43ac5 |
| Headers | show |
| Series | [v1] main: Fix a logical error within parse_config_int() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
Dear Zijun, Am 31.07.23 um 09:46 schrieb Zijun Hu: > Fix a logical error within parse_config_int(). Thank you for spotting and fixing this. I guess this warning was printed on the terminal? Although obvious, instead of duplicating the commit message summary in the body, it would be great, if you still wrote a more elaborate commit message. Maybe: Having a config file with the line below … causes the config file to be ignored, and the warning below: … > --- > src/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/main.c b/src/main.c > index 150a5af4cca4..13501440b052 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -458,7 +458,7 @@ static bool parse_config_int(GKeyFile *config, const char *group, > return false; > } > > - if (tmp < max) { > + if (tmp > max) { > warn("%s.%s = %d is out of range (> %d)", group, key, tmp, max); > return false; > } Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul
On 7/31/2023 4:48 PM, Paul Menzel wrote: > Dear Zijun, > > > Am 31.07.23 um 09:46 schrieb Zijun Hu: >> Fix a logical error within parse_config_int(). > > Thank you for spotting and fixing this. I guess this warning was printed on the terminal? no any warnings by following Compilation steps of README. > > Although obvious, instead of duplicating the commit message summary in the body, it would be great, if you still wrote a more elaborate commit message. Maybe: > > Having a config file with the line below > > … > > causes the config file to be ignored, and the warning below: > > … > the error is very simple, so i don't write more to explain it. >> --- >> src/main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/main.c b/src/main.c >> index 150a5af4cca4..13501440b052 100644 >> --- a/src/main.c >> +++ b/src/main.c >> @@ -458,7 +458,7 @@ static bool parse_config_int(GKeyFile *config, const char *group, >> return false; >> } >> - if (tmp < max) { >> + if (tmp > max) { >> warn("%s.%s = %d is out of range (> %d)", group, key, tmp, max); >> return false; >> } > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> > > > Kind regards, > > Paul
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=771058 ---Test result--- Test Summary: CheckPatch PASS 0.41 seconds GitLint PASS 0.30 seconds BuildEll PASS 26.97 seconds BluezMake PASS 819.40 seconds MakeCheck PASS 11.22 seconds MakeDistcheck PASS 158.87 seconds CheckValgrind PASS 253.18 seconds CheckSmatch PASS 343.26 seconds bluezmakeextell PASS 103.67 seconds IncrementalBuild PASS 679.27 seconds ScanBuild PASS 1095.06 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 31 Jul 2023 15:46:44 +0800 you wrote: > Fix a logical error within parse_config_int(). > --- > src/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [v1] main: Fix a logical error within parse_config_int() https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=446d8ada5790 You are awesome, thank you!
diff --git a/src/main.c b/src/main.c index 150a5af4cca4..13501440b052 100644 --- a/src/main.c +++ b/src/main.c @@ -458,7 +458,7 @@ static bool parse_config_int(GKeyFile *config, const char *group, return false; } - if (tmp < max) { + if (tmp > max) { warn("%s.%s = %d is out of range (> %d)", group, key, tmp, max); return false; }