diff mbox series

[BlueZ,v2] main: Fix integer configuration option parse failures

Message ID 1690795722-29873-1-git-send-email-quic_zijuhu@quicinc.com (mailing list archive)
State Accepted
Commit 446d8ada5790e5ca2cdc359eafa4bf7136b43ac5
Headers show
Series [BlueZ,v2] main: Fix integer configuration option parse failures | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

quic_zijuhu July 31, 2023, 9:28 a.m. UTC
parse_config_int() has a obvious logical error, so causes many
parse failures of integer configuration options, fixed by this
change.
---
 src/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com July 31, 2023, 10:46 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=771110

---Test result---

Test Summary:
CheckPatch                    PASS      0.36 seconds
GitLint                       PASS      0.26 seconds
BuildEll                      PASS      32.64 seconds
BluezMake                     PASS      972.40 seconds
MakeCheck                     PASS      13.63 seconds
MakeDistcheck                 PASS      187.41 seconds
CheckValgrind                 PASS      311.54 seconds
CheckSmatch                   PASS      411.05 seconds
bluezmakeextell               PASS      123.87 seconds
IncrementalBuild              PASS      797.78 seconds
ScanBuild                     PASS      1256.69 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org July 31, 2023, 5:50 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 31 Jul 2023 17:28:42 +0800 you wrote:
> parse_config_int() has a obvious logical error, so causes many
> parse failures of integer configuration options, fixed by this
> change.
> ---
>  src/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ,v2] main: Fix integer configuration option parse failures
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=446d8ada5790

You are awesome, thank you!
diff mbox series

Patch

diff --git a/src/main.c b/src/main.c
index 150a5af4cca4..13501440b052 100644
--- a/src/main.c
+++ b/src/main.c
@@ -458,7 +458,7 @@  static bool parse_config_int(GKeyFile *config, const char *group,
 		return false;
 	}
 
-	if (tmp < max) {
+	if (tmp > max) {
 		warn("%s.%s = %d is out of range (> %d)", group, key, tmp, max);
 		return false;
 	}