| Message ID | 20200305131424.381031-1-szymon.janc@codecoup.pl (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Marcel Holtmann |
| Headers | show |
| Series | Bluetooth: Make spurious error message debug | expand |
Hi Szymon, > Even with rate limited reporting this is very spammy and since > it is remote device that is providing bogus data there is no > need to report this as error. > > [72454.143336] bt_err_ratelimited: 10 callbacks suppressed > [72454.143337] Bluetooth: hci0: advertising data len corrected > [72454.296314] Bluetooth: hci0: advertising data len corrected > [72454.892329] Bluetooth: hci0: advertising data len corrected > [72455.051319] Bluetooth: hci0: advertising data len corrected > [72455.357326] Bluetooth: hci0: advertising data len corrected > [72455.663295] Bluetooth: hci0: advertising data len corrected > [72455.787278] Bluetooth: hci0: advertising data len corrected > [72455.942278] Bluetooth: hci0: advertising data len corrected > [72456.094276] Bluetooth: hci0: advertising data len corrected > [72456.249137] Bluetooth: hci0: advertising data len corrected > [72459.416333] bt_err_ratelimited: 13 callbacks suppressed > [72459.416334] Bluetooth: hci0: advertising data len corrected > [72459.721334] Bluetooth: hci0: advertising data len corrected > [72460.011317] Bluetooth: hci0: advertising data len corrected > [72460.327171] Bluetooth: hci0: advertising data len corrected > [72460.638294] Bluetooth: hci0: advertising data len corrected > [72460.946350] Bluetooth: hci0: advertising data len corrected > [72461.225320] Bluetooth: hci0: advertising data len corrected > [72461.690322] Bluetooth: hci0: advertising data len corrected > [72462.118318] Bluetooth: hci0: advertising data len corrected > [72462.427319] Bluetooth: hci0: advertising data len corrected > [72464.546319] bt_err_ratelimited: 7 callbacks suppressed > [72464.546319] Bluetooth: hci0: advertising data len corrected > [72464.857318] Bluetooth: hci0: advertising data len corrected > [72465.163332] Bluetooth: hci0: advertising data len corrected > [72465.278331] Bluetooth: hci0: advertising data len corrected > [72465.432323] Bluetooth: hci0: advertising data len corrected > [72465.891334] Bluetooth: hci0: advertising data len corrected > [72466.045334] Bluetooth: hci0: advertising data len corrected > [72466.197321] Bluetooth: hci0: advertising data len corrected > [72466.340318] Bluetooth: hci0: advertising data len corrected > [72466.498335] Bluetooth: hci0: advertising data len corrected > [72469.803299] bt_err_ratelimited: 10 callbacks suppressed > > Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl> > --- > net/bluetooth/hci_event.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c > index a40ed31f6eb8..c69267f1951e 100644 > --- a/net/bluetooth/hci_event.c > +++ b/net/bluetooth/hci_event.c > @@ -5277,7 +5277,8 @@ static void process_adv_report(struct hci_dev *hdev, u8 type, bdaddr_t *bdaddr, > > /* Adjust for actual length */ > if (len != real_len) { > - bt_dev_err_ratelimited(hdev, "advertising data len corrected"); > + BT_DBG("%s: advertising data len corrected (%u->%u)", > + hdev->name, len, real_len); can we use bt_dev_dbg please. Regards Marcel
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index a40ed31f6eb8..c69267f1951e 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -5277,7 +5277,8 @@ static void process_adv_report(struct hci_dev *hdev, u8 type, bdaddr_t *bdaddr, /* Adjust for actual length */ if (len != real_len) { - bt_dev_err_ratelimited(hdev, "advertising data len corrected"); + BT_DBG("%s: advertising data len corrected (%u->%u)", + hdev->name, len, real_len); len = real_len; }
Even with rate limited reporting this is very spammy and since it is remote device that is providing bogus data there is no need to report this as error. [72454.143336] bt_err_ratelimited: 10 callbacks suppressed [72454.143337] Bluetooth: hci0: advertising data len corrected [72454.296314] Bluetooth: hci0: advertising data len corrected [72454.892329] Bluetooth: hci0: advertising data len corrected [72455.051319] Bluetooth: hci0: advertising data len corrected [72455.357326] Bluetooth: hci0: advertising data len corrected [72455.663295] Bluetooth: hci0: advertising data len corrected [72455.787278] Bluetooth: hci0: advertising data len corrected [72455.942278] Bluetooth: hci0: advertising data len corrected [72456.094276] Bluetooth: hci0: advertising data len corrected [72456.249137] Bluetooth: hci0: advertising data len corrected [72459.416333] bt_err_ratelimited: 13 callbacks suppressed [72459.416334] Bluetooth: hci0: advertising data len corrected [72459.721334] Bluetooth: hci0: advertising data len corrected [72460.011317] Bluetooth: hci0: advertising data len corrected [72460.327171] Bluetooth: hci0: advertising data len corrected [72460.638294] Bluetooth: hci0: advertising data len corrected [72460.946350] Bluetooth: hci0: advertising data len corrected [72461.225320] Bluetooth: hci0: advertising data len corrected [72461.690322] Bluetooth: hci0: advertising data len corrected [72462.118318] Bluetooth: hci0: advertising data len corrected [72462.427319] Bluetooth: hci0: advertising data len corrected [72464.546319] bt_err_ratelimited: 7 callbacks suppressed [72464.546319] Bluetooth: hci0: advertising data len corrected [72464.857318] Bluetooth: hci0: advertising data len corrected [72465.163332] Bluetooth: hci0: advertising data len corrected [72465.278331] Bluetooth: hci0: advertising data len corrected [72465.432323] Bluetooth: hci0: advertising data len corrected [72465.891334] Bluetooth: hci0: advertising data len corrected [72466.045334] Bluetooth: hci0: advertising data len corrected [72466.197321] Bluetooth: hci0: advertising data len corrected [72466.340318] Bluetooth: hci0: advertising data len corrected [72466.498335] Bluetooth: hci0: advertising data len corrected [72469.803299] bt_err_ratelimited: 10 callbacks suppressed Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl> --- net/bluetooth/hci_event.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)