| Message ID | 20200417171532.448053-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Marcel Holtmann |
| Headers | show |
| Series | [1/8] Bluetooth: btbcm: Drop upper nibble version check from btbcm_initialize() | expand |
Hi Hans, > btbcm_initialize() must either return an error; or fill the passed in > fw_name, otherwise we end up passing uninitialized stack memory to > request_firmware(). > > Since we have a fallback hw_name of "BCM" not having a known version > in the subver field does not matter, drop the check so that we always > fill the passed in fw_name. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/bluetooth/btbcm.c | 4 ---- > 1 file changed, 4 deletions(-) all 8 patches have been applied to bluetooth-next tree. Regards Marcel
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c index 1f498f358f60..b9e1fe052148 100644 --- a/drivers/bluetooth/btbcm.c +++ b/drivers/bluetooth/btbcm.c @@ -440,10 +440,6 @@ int btbcm_initialize(struct hci_dev *hdev, char *fw_name, size_t len, return err; } - /* Upper nibble of rev should be between 0 and 3? */ - if (((rev & 0xf000) >> 12) > 3) - return 0; - bcm_subver_table = (hdev->bus == HCI_USB) ? bcm_usb_subver_table : bcm_uart_subver_table;
btbcm_initialize() must either return an error; or fill the passed in fw_name, otherwise we end up passing uninitialized stack memory to request_firmware(). Since we have a fallback hw_name of "BCM" not having a known version in the subver field does not matter, drop the check so that we always fill the passed in fw_name. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/bluetooth/btbcm.c | 4 ---- 1 file changed, 4 deletions(-)