| Message ID | 20200427094558.16649-1-amit.k.bag@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Marcel Holtmann |
| Headers | show |
| Series | [v3,1/2] Bluetooth: btusb: Add support for Intel Bluetooth Device Typhoon Peak (8087:0032) | expand |
Hi Amit, > Device from /sys/kernel/debug/usb/devices: > > T: Bus=01 Lev=01 Prnt=01 Port=13 Cnt=02 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=8087 ProdID=0032 Rev= 0.00 > C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=1ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms > E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms > I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms > E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms > > Signed-off-by: Amit K Bag <amit.k.bag@intel.com> > Signed-off-by: Tumkur Narayan, Chethan <chethan.tumkur.narayan@intel.com> > --- > drivers/bluetooth/btusb.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel
Hi Amit, >> Device from /sys/kernel/debug/usb/devices: >> >> T: Bus=01 Lev=01 Prnt=01 Port=13 Cnt=02 Dev#= 3 Spd=12 MxCh= 0 >> D: Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 >> P: Vendor=8087 ProdID=0032 Rev= 0.00 >> C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA >> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb >> E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=1ms >> E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms >> E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms >> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb >> E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms >> E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms >> I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb >> E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms >> E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms >> I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb >> E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms >> E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms >> I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb >> E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms >> E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms >> I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb >> E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms >> E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms >> I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb >> E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms >> E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms >> I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb >> E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms >> E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms >> >> Signed-off-by: Amit K Bag <amit.k.bag@intel.com> >> Signed-off-by: Tumkur Narayan, Chethan <chethan.tumkur.narayan@intel.com> >> --- >> drivers/bluetooth/btusb.c | 2 ++ >> 1 file changed, 2 insertions(+) > > patch has been applied to bluetooth-next tree. so I am taking this patch back out. You are missing a Signed-off-by line. Please fix that and I also prefer first name last name for the addresses. In addition there is white-space damage in the patch. That needs fixing as well. Regards Marcel
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 09913cadd1ca..7a71d851b6c9 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -340,6 +340,8 @@ static const struct usb_device_id blacklist_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x8087, 0x0029), .driver_info = BTUSB_INTEL_NEW | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x8087, 0x0032), .driver_info = BTUSB_INTEL_NEW | + BTUSB_WIDEBAND_SPEECH}, { USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR }, { USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL }, { USB_DEVICE(0x8087, 0x0a2a), .driver_info = BTUSB_INTEL },