| Message ID | 20200717231404.240644-1-sonnysasaka@chromium.org (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [BlueZ] Add a presubmit configuration file for Chromium OS repo | expand |
Maintainers, could you take a look at this? We started using a mirror of upstream in chromium repo, so we can not apply this PRESUBMIT.cfg file as our own commit. It'd be great if this file can be submitted upstream as well to help Chromium OS developers' workflow. On Fri, Jul 17, 2020 at 4:14 PM Sonny Sasaka <sonnysasaka@chromium.org> wrote: > > Chromium OS developers use gerrit and repo in their workflow. > (https://gerrit.googlesource.com/git-repo/). This configuration file > makes it easier when uploading patches to gerrit with the repo tool. > > --- > PRESUBMIT.cfg | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 PRESUBMIT.cfg > > diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg > new file mode 100644 > index 000000000..10f89b741 > --- /dev/null > +++ b/PRESUBMIT.cfg > @@ -0,0 +1,8 @@ > +# This is a configuration for Chromium OS repo pre-upload hooks. > +# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/ > +# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/ > + > +[Hook Overrides] > +cros_license_check: false > +tab_check: false > +checkpatch_check: true > -- > 2.26.2 >
Hi Sonny, > Chromium OS developers use gerrit and repo in their workflow. > (https://gerrit.googlesource.com/git-repo/). This configuration file > makes it easier when uploading patches to gerrit with the repo tool. > > --- > PRESUBMIT.cfg | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 PRESUBMIT.cfg > > diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg > new file mode 100644 > index 000000000..10f89b741 > --- /dev/null > +++ b/PRESUBMIT.cfg > @@ -0,0 +1,8 @@ > +# This is a configuration for Chromium OS repo pre-upload hooks. > +# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/ > +# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/ > + > +[Hook Overrides] > +cros_license_check: false > +tab_check: false > +checkpatch_check: true I am not in favor of adding anything in the top-level directory that is not for for the BlueZ upstream usage. Regards Marcel
diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg new file mode 100644 index 000000000..10f89b741 --- /dev/null +++ b/PRESUBMIT.cfg @@ -0,0 +1,8 @@ +# This is a configuration for Chromium OS repo pre-upload hooks. +# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/ +# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/ + +[Hook Overrides] +cros_license_check: false +tab_check: false +checkpatch_check: true