diff mbox series

[Bluez,v1,3/3] advertising: Add adv SupportedFeatures to doc

Message ID 20200826131610.Bluez.v1.3.Ieb6522963e3f54b0d63dd88ed3ce24a8942ed73e@changeid (mailing list archive)
State Accepted
Delegated to: Luiz Von Dentz
Headers show
Series Expose extended adv feature support via bluez API | expand

Commit Message

Daniel Winkler Aug. 26, 2020, 8:17 p.m. UTC
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
---

 doc/advertising-api.txt | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Marcel Holtmann Aug. 31, 2020, 3:51 p.m. UTC | #1
Hi Daniel,

> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> ---
> 
> doc/advertising-api.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> 
> diff --git a/doc/advertising-api.txt b/doc/advertising-api.txt
> index b0565eab2..0c07f349e 100644
> --- a/doc/advertising-api.txt
> +++ b/doc/advertising-api.txt
> @@ -209,3 +209,21 @@ Properties	byte ActiveInstances
> 			Possible values: "1M"
> 					 "2M"
> 					 "Coded"
> +
> +		array{string} SupportedFeatures [readonly, optional]
> +
> +			List of supported platform features. If no features
> +			are available on the platform, the SupportedFeatures
> +			endpoint will not be populated.

why not just an empty SupportedFeatures? So you can tell that at least the daemon has support for it, but the hardware does not.

Regards

Marcel
diff mbox series

Patch

diff --git a/doc/advertising-api.txt b/doc/advertising-api.txt
index b0565eab2..0c07f349e 100644
--- a/doc/advertising-api.txt
+++ b/doc/advertising-api.txt
@@ -209,3 +209,21 @@  Properties	byte ActiveInstances
 			Possible values: "1M"
 					 "2M"
 					 "Coded"
+
+		array{string} SupportedFeatures [readonly, optional]
+
+			List of supported platform features. If no features
+			are available on the platform, the SupportedFeatures
+			endpoint will not be populated.
+
+			Possible values: "CanSetTxPower"
+
+						Indicates whether platform can
+						specify tx power on each
+						advertising instance.
+
+					 "HardwareOffload"
+
+						Indicates whether multiple
+						advertising will be offloaded
+						to the controller.