diff mbox series

[BlueZ] profiles/network: Log connection event after setting device name

Message ID 20200827112759.6914-1-edef@edef.eu (mailing list archive)
State Accepted
Delegated to: Luiz Von Dentz
Headers show
Series [BlueZ] profiles/network: Log connection event after setting device name | expand

Commit Message

edef Aug. 27, 2020, 11:27 a.m. UTC
Without reordering these two statements, the logs look like this:

    bnep%d connected
    bnep0 disconnected
---
 profiles/network/connection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luiz Augusto von Dentz Aug. 27, 2020, 5:55 p.m. UTC | #1
Hi Edef,

On Thu, Aug 27, 2020 at 8:21 AM edef <edef@edef.eu> wrote:
>
> Without reordering these two statements, the logs look like this:
>
>     bnep%d connected
>     bnep0 disconnected
> ---
>  profiles/network/connection.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/network/connection.c b/profiles/network/connection.c
> index 97b87d02e..170841de6 100644
> --- a/profiles/network/connection.c
> +++ b/profiles/network/connection.c
> @@ -216,9 +216,9 @@ static void bnep_conn_cb(char *iface, int err, void *data)
>                 goto failed;
>         }
>
> +       memcpy(nc->dev, iface, sizeof(nc->dev));
>         info("%s connected", nc->dev);
>
> -       memcpy(nc->dev, iface, sizeof(nc->dev));
>         btd_service_connecting_complete(nc->service, 0);
>
>         if (nc->connect)
> --
> 2.27.0

Applied, thanks.
diff mbox series

Patch

diff --git a/profiles/network/connection.c b/profiles/network/connection.c
index 97b87d02e..170841de6 100644
--- a/profiles/network/connection.c
+++ b/profiles/network/connection.c
@@ -216,9 +216,9 @@  static void bnep_conn_cb(char *iface, int err, void *data)
 		goto failed;
 	}
 
+	memcpy(nc->dev, iface, sizeof(nc->dev));
 	info("%s connected", nc->dev);
 
-	memcpy(nc->dev, iface, sizeof(nc->dev));
 	btd_service_connecting_complete(nc->service, 0);
 
 	if (nc->connect)