[BlueZ] hcidump: fix a crash in le_meta_ev_dump()

Commit Message

zefang han Aug. 30, 2020, 11:59 a.m. UTC

---
 tools/parser/hci.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

[e-mail] Aug. 30, 2020, 12:24 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkpatch Failed

Outputs:
ERROR:SPACING: space required before the open brace '{'
#17: FILE: tools/parser/hci.c:3672:
+	if(subevent > LE_EV_NUM){

ERROR:SPACING: space required before the open parenthesis '('
#17: FILE: tools/parser/hci.c:3672:
+	if(subevent > LE_EV_NUM){

ERROR:SPACING: space required before the open brace '{'
#19: FILE: tools/parser/hci.c:3674:
+	}else{

ERROR:SPACING: space required after that close brace '}'
#19: FILE: tools/parser/hci.c:3674:
+	}else{

- total: 4 errors, 0 warnings, 13 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



---
Regards,
Linux Bluetooth

[e-mail] Aug. 30, 2020, 12:24 p.m. UTC | #2

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkgitlint Failed

Outputs:
3: B6 Body message is missing



---
Regards,
Linux Bluetooth

Patch

diff --git a/tools/parser/hci.c b/tools/parser/hci.c
index 41f6fe087..e969d198c 100644
--- a/tools/parser/hci.c
+++ b/tools/parser/hci.c
@@ -3668,7 +3668,12 @@  static inline void le_meta_ev_dump(int level, struct frame *frm)
 	frm->len -= EVT_LE_META_EVENT_SIZE;
 
 	p_indent(level, frm);
-	printf("%s\n", ev_le_meta_str[subevent]);
+
+	if(subevent > LE_EV_NUM){
+		printf("Unknown\n");
+	}else{
+		printf("%s\n", ev_le_meta_str[subevent]);
+	}
 
 	switch (mevt->subevent) {
 	case EVT_LE_CONN_COMPLETE: