| Message ID | 20200910161528.BlueZ.v4.1.Iaa9dc2a66de5fbfa97627e1dbeb800116d3aa91e@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [BlueZ,v4,1/8] adapter: Remove indirect dependency of headers | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.
Test Result:
checkbuild Failed
Outputs:
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
src/adv_monitor.c: In function ‘monitor_match’:
src/adv_monitor.c:276:35: error: passing argument 1 of ‘g_dbus_proxy_get_path’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
276 | if (strcmp(g_dbus_proxy_get_path(proxy), monitor->path) != 0)
| ^~~~~
In file included from src/adv_monitor.c:31:
./gdbus/gdbus.h:336:13: note: expected ‘GDBusProxy *’ {aka ‘struct GDBusProxy *’} but argument is of type ‘const GDBusProxy *’ {aka ‘const struct GDBusProxy *’}
336 | const char *g_dbus_proxy_get_path(GDBusProxy *proxy);
| ^~~~~~~~~~~~~~~~~~~~~
src/adv_monitor.c: In function ‘parse_patterns’:
src/adv_monitor.c:485:36: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
485 | if (ad_type > BT_AD_3D_INFO_DATA &&
src/adv_monitor.c:425:11: error: unused variable ‘num_patterns’ [-Werror=unused-variable]
425 | uint16_t num_patterns = 0;
| ^~~~~~~~~~~~
src/adv_monitor.c: In function ‘get_supported_monitor_types’:
src/adv_monitor.c:753:34: error: unused variable ‘manager’ [-Werror=unused-variable]
753 | struct btd_adv_monitor_manager *manager = data;
| ^~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:9272: src/bluetoothd-adv_monitor.o] Error 1
make: *** [Makefile:4014: all] Error 2
---
Regards,
Linux Bluetooth
diff --git a/src/adapter.h b/src/adapter.h index f8ac20261..c70a7b0da 100644 --- a/src/adapter.h +++ b/src/adapter.h @@ -26,6 +26,9 @@ #include <dbus/dbus.h> #include <glib.h> +#include <lib/bluetooth.h> +#include <lib/sdp.h> + #define MAX_NAME_LENGTH 248 /* Invalid SSP passkey value used to indicate negative replies */
Given that adapter.h refers symbols from lib/bluetooth.h and lib/sdp.h, these two headers should be included directly in adapter.h. Reviewed-by: Manish Mandlik <mmandlik@chromium.org> --- (no changes since v1) src/adapter.h | 3 +++ 1 file changed, 3 insertions(+)