Message ID | 20201117024332.165771-1-jingxiangfeng@huawei.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware() | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=385607 ---Test result--- ############################## Test: CheckPatch - FAIL Output: workflow: Add workflow files for ci WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 49 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] workflow: Add workflow files for ci" has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: CheckGitLint - FAIL Output: Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware() 1: T1 Title exceeds max length (79>72): "Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware()" ############################## Test: CheckBuildK - PASS --- Regards, Linux Bluetooth
Hi Jing, > mtk_setup_firmware() misses to call release_firmware() in an error > path. Jump to free_fw to fix it. > > Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence") > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> > --- > drivers/bluetooth/btmtksdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index c7ab7a23bd67..c2677ffbd3c0 100644 --- a/drivers/bluetooth/btmtksdio.c +++ b/drivers/bluetooth/btmtksdio.c @@ -704,7 +704,7 @@ static int mtk_setup_firmware(struct hci_dev *hdev, const char *fwname) err = mtk_hci_wmt_sync(hdev, &wmt_params); if (err < 0) { bt_dev_err(hdev, "Failed to power on data RAM (%d)", err); - return err; + goto free_fw; } fw_ptr = fw->data;
mtk_setup_firmware() misses to call release_firmware() in an error path. Jump to free_fw to fix it. Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence") Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> --- drivers/bluetooth/btmtksdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)