| Message ID | 20210318204640.424409-1-hj.tedd.an@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Luiz Von Dentz |
| Headers | show |
| Series | [BlueZ,v2] tools/mgmt-tester: Fix for scan response in read adv feature command | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=451087 ---Test result--- ############################## Test: CheckPatch - PASS ############################## Test: CheckGitLint - FAIL Output: tools/mgmt-tester: Fix for scan response in read adv feature command 6: B3 Line contains hard tab characters (\t): " Read Advertising Features - Success 1 (No instance) Failed" 7: B3 Line contains hard tab characters (\t): " Read Advertising Features - Success 2 (One instance) Failed" 8: B3 Line contains hard tab characters (\t): " Read Ext Advertising Features - Success 3 (PHY flags) Failed" ############################## Test: CheckBuild - PASS ############################## Test: MakeCheck - PASS --- Regards, Linux Bluetooth
Hi Tedd, On Thu, Mar 18, 2021 at 2:37 PM <bluez.test.bot@gmail.com> wrote: > > This is automated email and please do not reply to this email! > > Dear submitter, > > Thank you for submitting the patches to the linux bluetooth mailing list. > This is a CI test results with your patch series: > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=451087 > > ---Test result--- > > ############################## > Test: CheckPatch - PASS > > ############################## > Test: CheckGitLint - FAIL > Output: > tools/mgmt-tester: Fix for scan response in read adv feature command > 6: B3 Line contains hard tab characters (\t): " Read Advertising Features - Success 1 (No instance) Failed" > 7: B3 Line contains hard tab characters (\t): " Read Advertising Features - Success 2 (One instance) Failed" > 8: B3 Line contains hard tab characters (\t): " Read Ext Advertising Features - Success 3 (PHY flags) Failed" > > > ############################## > Test: CheckBuild - PASS > > ############################## > Test: MakeCheck - PASS > > > > --- > Regards, > Linux Bluetooth Applied, thanks.
diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c index bb9fb0b9c..1835ca079 100644 --- a/tools/mgmt-tester.c +++ b/tools/mgmt-tester.c @@ -4162,7 +4162,7 @@ static const struct generic_data read_adv_features_invalid_index_test = { }; static const uint8_t read_adv_features_rsp_1[] = { - 0x7f, 0xf0, 0x00, 0x00, /* supported flags */ + 0x7f, 0xf0, 0x01, 0x00, /* supported flags */ 0x1f, /* max_adv_data_len */ 0x1f, /* max_scan_rsp_len */ 0x05, /* max_instances */ @@ -4177,7 +4177,7 @@ static const struct generic_data read_adv_features_success_1 = { }; static const uint8_t read_adv_features_rsp_2[] = { - 0x7f, 0xf0, 0x00, 0x00, /* supported flags */ + 0x7f, 0xf0, 0x01, 0x00, /* supported flags */ 0x1f, /* max_adv_data_len */ 0x1f, /* max_scan_rsp_len */ 0x05, /* max_instances */ @@ -7137,7 +7137,7 @@ static const struct generic_data set_appearance_success = { }; static const uint8_t read_adv_features_rsp_3[] = { - 0xff, 0xff, 0x00, 0x00, /* supported flags */ + 0xff, 0xff, 0x01, 0x00, /* supported flags */ 0x1f, /* max_adv_data_len */ 0x1f, /* max_scan_rsp_len */ 0x01, /* max_instances */
From: Tedd Ho-Jeong An <tedd.an@intel.com> This patch fixes the test failure with the read advertising feature API which is changed to include the scan response flag. Read Advertising Features - Success 1 (No instance) Failed Read Advertising Features - Success 2 (One instance) Failed Read Ext Advertising Features - Success 3 (PHY flags) Failed --- tools/mgmt-tester.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)