| Message ID | 20210322164637.941598-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bluetooth: fix set_ecdh_privkey() prototype | expand |
Hi Arnd, > gcc-11 points out that the declaration does not match the definition: > > net/bluetooth/ecdh_helper.c:122:55: error: argument 2 of type ‘const u8[32]’ {aka ‘const unsigned char[32]’} with mismatched bound [-Werror=array-parameter=] > 122 | int set_ecdh_privkey(struct crypto_kpp *tfm, const u8 private_key[32]) > | ~~~~~~~~~^~~~~~~~~~~~~~~ > In file included from net/bluetooth/ecdh_helper.c:23: > net/bluetooth/ecdh_helper.h:28:56: note: previously declared as ‘const u8 *’ {aka ‘const unsigned char *’} > 28 | int set_ecdh_privkey(struct crypto_kpp *tfm, const u8 *private_key); > | ~~~~~~~~~~^~~~~~~~~~~ > > Change the declaration to contain the size of the array, rather than > just a pointer. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > net/bluetooth/ecdh_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/net/bluetooth/ecdh_helper.h b/net/bluetooth/ecdh_helper.h index a6f8d03d4aaf..830723971cf8 100644 --- a/net/bluetooth/ecdh_helper.h +++ b/net/bluetooth/ecdh_helper.h @@ -25,6 +25,6 @@ int compute_ecdh_secret(struct crypto_kpp *tfm, const u8 pair_public_key[64], u8 secret[32]); -int set_ecdh_privkey(struct crypto_kpp *tfm, const u8 *private_key); +int set_ecdh_privkey(struct crypto_kpp *tfm, const u8 private_key[32]); int generate_ecdh_public_key(struct crypto_kpp *tfm, u8 public_key[64]); int generate_ecdh_keys(struct crypto_kpp *tfm, u8 public_key[64]);