diff mbox series

[BlueZ,3/3] monitor/avdtp: Fix decoding of reject type

Message ID 20210501003717.7553-3-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Delegated to: Luiz Von Dentz
Headers show
Series [BlueZ,1/3] avdtp: Fix accepting invalid/malformed capabilities | expand

Commit Message

Luiz Augusto von Dentz May 1, 2021, 12:37 a.m. UTC 
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Reject type was not being decoded, so this remove the early return and
leave the callback to decode it:

< ACL Data TX: Handle 42 flags 0x00 dlen 8
      Channel: 64 len 4 [PSM 25 mode Basic (0x00)] {chan 1}
      AVDTP: Set Configuration (0x03) Response Reject (0x03) type 0x00 label 2 nosp 0
        Service Category: Reserved (0x00)
        Error code: BAD_ACP_SEID (0x12)
---
 monitor/avdtp.c | 4 ----
 1 file changed, 4 deletions(-)
diff mbox series

Patch

diff --git a/monitor/avdtp.c b/monitor/avdtp.c
index 9fe72d240..1393d1286 100644
--- a/monitor/avdtp.c
+++ b/monitor/avdtp.c
@@ -715,10 +715,6 @@  static bool avdtp_signalling_packet(struct avdtp_frame *avdtp_frame)
 		return true;
 	}
 
-	/* General Reject */
-	if ((hdr & 0x03) == 0x03)
-		return true;
-
 	switch (sig_id) {
 	case AVDTP_DISCOVER:
 		return avdtp_discover(avdtp_frame);