| Message ID | 20210518185938.322908-1-dlenski@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: Add a new QCA_ROME device (0cf3:e500) | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=484533
---Test result---
Test Summary:
CheckPatch FAIL 0.84 seconds
GitLint PASS 0.13 seconds
BuildKernel PASS 589.44 seconds
TestRunner: Setup PASS 390.88 seconds
TestRunner: l2cap-tester PASS 2.83 seconds
TestRunner: bnep-tester PASS 2.04 seconds
TestRunner: mgmt-tester PASS 28.94 seconds
TestRunner: rfcomm-tester PASS 2.26 seconds
TestRunner: sco-tester PASS 2.14 seconds
TestRunner: smp-tester PASS 2.27 seconds
TestRunner: userchan-tester PASS 2.00 seconds
Details
##############################
Test: CheckPatch - FAIL - 0.84 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: Add a new QCA_ROME device (0cf3:e500)
WARNING: Unknown commit id '0a03f98b98c2', maybe rebased or not pulled?
#9:
commit 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device").
total: 0 errors, 1 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] Bluetooth: Add a new QCA_ROME device (0cf3:e500)" has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - PASS - 0.13 seconds
Run gitlint with rule in .gitlint
##############################
Test: BuildKernel - PASS - 589.44 seconds
Build Kernel with minimal configuration supports Bluetooth
##############################
Test: TestRunner: Setup - PASS - 390.88 seconds
Setup environment for running Test Runner
##############################
Test: TestRunner: l2cap-tester - PASS - 2.83 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: bnep-tester - PASS - 2.04 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: mgmt-tester - PASS - 28.94 seconds
Run test-runner with mgmt-tester
Total: 416, Passed: 403 (96.9%), Failed: 0, Not Run: 13
##############################
Test: TestRunner: rfcomm-tester - PASS - 2.26 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: sco-tester - PASS - 2.14 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: smp-tester - PASS - 2.27 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: userchan-tester - PASS - 2.00 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0
---
Regards,
Linux Bluetooth
Hi all, I'm somewhat confused about why CheckPatch is failing to approve this patch. It says that a commit referenced in the commit message does not exist: On Tue, May 18, 2021 at 12:31 PM <bluez.test.bot@gmail.com> wrote: > Test: CheckPatch - FAIL - 0.84 seconds > Run checkpatch.pl script with rule in .checkpatch.conf > Bluetooth: Add a new QCA_ROME device (0cf3:e500) > WARNING: Unknown commit id '0a03f98b98c2', maybe rebased or not pulled? > #9: > commit 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device"). However, this commit *does* exist, and it is — as far as I can tell — the *only* commit which exists with this text in its title. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=0a03f98b98c201191e3ba15a0e33f46d8660e1fd https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?qt=grep&q=Add+a+new+04ca%3A3015+QCA_ROME+device Any suggestions about how to resolve this? -Dan Lenski
Hi Dan On Tue, 2021-05-18 at 14:41 -0700, Daniel Lenski wrote: > Hi all, > I'm somewhat confused about why CheckPatch is failing to approve this > patch. It says that a commit referenced in the commit message does not > exist: > > On Tue, May 18, 2021 at 12:31 PM <bluez.test.bot@gmail.com> wrote: > > Test: CheckPatch - FAIL - 0.84 seconds > > Run checkpatch.pl script with rule in .checkpatch.conf > > Bluetooth: Add a new QCA_ROME device (0cf3:e500) > > WARNING: Unknown commit id '0a03f98b98c2', maybe rebased or not pulled? > > #9: > > commit 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device"). > > However, this commit *does* exist, and it is — as far as I can tell — > the *only* commit which exists with this text in its title. > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=0a03f98b98c201191e3ba15a0e33f46d8660e1fd > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?qt=grep&q=Add+a+new+04ca%3A3015+QCA_ROME+device > > Any suggestions about how to resolve this? You can ignore this error. This is an issue in the CI which is not pulling the entire kernel tree to reduce the running time. > > -Dan Lenski Regards, Tedd
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 5d603ef39..ba339e074 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -270,6 +270,8 @@ static const struct usb_device_id blacklist_table[] = { BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0cf3, 0xe360), .driver_info = BTUSB_QCA_ROME | BTUSB_WIDEBAND_SPEECH }, + { USB_DEVICE(0x0cf3, 0xe500), .driver_info = BTUSB_QCA_ROME | + BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe092), .driver_info = BTUSB_QCA_ROME | BTUSB_WIDEBAND_SPEECH }, { USB_DEVICE(0x0489, 0xe09f), .driver_info = BTUSB_QCA_ROME |
This patch adds the 0cf3:e500 Bluetooth device (from a QCA9377 board) as a QCA_ROME device. It appears to be functionally identical to another device ID, also from a QCA9377 board, which was previously marked as QCA_ROME in commit 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device"). Without this patch, the WiFi side of the QCA9377 board is slow or unusable when the Bluetooth side is in use. See https://askubuntu.com/a/1137852 for another report of QCA_ROME fixing this issue for this device ID. /sys/kernel/debug/usb/devices: T: Bus=05 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0 D: Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=0cf3 ProdID=e500 Rev= 0.01 C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms Signed-off-by: Daniel Lenski <dlenski@gmail.com> --- drivers/bluetooth/btusb.c | 2 ++ 1 file changed, 2 insertions(+)