From patchwork Thu Jul 15 14:51:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Archie Pusaka X-Patchwork-Id: 12380259 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF8EC07E96 for ; Thu, 15 Jul 2021 14:52:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07DB161360 for ; Thu, 15 Jul 2021 14:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238085AbhGOOzG (ORCPT ); Thu, 15 Jul 2021 10:55:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238074AbhGOOzF (ORCPT ); Thu, 15 Jul 2021 10:55:05 -0400 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2B91C061760 for ; Thu, 15 Jul 2021 07:52:11 -0700 (PDT) Received: by mail-pg1-x549.google.com with SMTP id n21-20020a6563d50000b029022866cd1f17so4610430pgv.10 for ; Thu, 15 Jul 2021 07:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=G+OSuGiOQklLZymMFCTnttGx/CFqtpqkpXlERNqy3WE=; b=gqIJh2s7wmvsRX3Dj0IG07hc4eEq80GIOGi1lQv/P7dMzkW7Ah21y7ZsWZ7/lTiymv JZC8xVnlyUXMn0OwUMK+i77E1zy28v8vFyO7q9sJIa3WD4bkekPSNnz1ddPp1yhfmeP4 s1ZXzMLYjLz1EcH7YOG1RFh1wQP1ukGPHIVmgsKX15LeECtWIRrWqDVMJPA6Gx5M4OEe gMhYV/8RbA2AZxHfytn36Uxvob46KtyhbW9tQ2xbGyxzWvHSUqQmCAsU92/4iT6r3Uiw r0PY9xhmThnJtgH5/hbwXMvTvjO7UL1wdt0U/oflGeetnn35yDe07v/ZkGU6zRSiogfj bWig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=G+OSuGiOQklLZymMFCTnttGx/CFqtpqkpXlERNqy3WE=; b=o9i/xmCOZrUBG8fo9qXOwhzT58VzhmYOkBtKAD6GOWSm1iz7zG3Yag1FnEitnBvkZ6 eIGU5q6z1sXS+DlQm4J0Gai9BYbY0mFL3haErLTmZIcw0wyPZ+cucZD7IhH0WL3ESUp3 Sk7DCWa+e3D3/ffyAJ9gs6eM+H5Y2KKgR/sSYVf9zAtq8fzCKM1YCEafyucFRjdHmYyF SYIKCF62f46WqTDOYDTkf3ZWYZKN5PU6bKBAuk94GMupPEKX6HsvknLERleMFH9vbsLn I1Y0vGiN3faL/iFdBZGQyp054VnwyZORyNA3f00hHcqwNwFQxa6bCEl3LIW4vyQux4+d JOMg== X-Gm-Message-State: AOAM530K4Hs5EemV2dhNHlnZegrkIZcogdx76d0dNmX4ruR9LNXiXxnl ykjXsLTZd3y5fTbeK7EUfVCCqgOqZ/snj5G2MR7ZlIfUUVT0TLaqCDS1FQ7FqJ7l+X8BjNtTlWm 4xBpq8zKpMjSo9Ovw9oVBVPhygyGOht1eAD9vdM7Ln/hNTMEH8tVrh6FgtVIIKPQC2ZcbNcpMNj mG X-Google-Smtp-Source: ABdhPJw+PADg00qqa82z+TAch21RdtQtw0XRKi81eKrrsyNFFYQ6eyyU2Vw/R45PWxlKj0Z6vuQG3XwTdoFg X-Received: from apusaka-p920.tpe.corp.google.com ([2401:fa00:1:10:d9e1:875d:57dd:2e32]) (user=apusaka job=sendgmr) by 2002:aa7:9e5c:0:b029:32b:4e2a:e549 with SMTP id z28-20020aa79e5c0000b029032b4e2ae549mr5136047pfq.68.1626360731307; Thu, 15 Jul 2021 07:52:11 -0700 (PDT) Date: Thu, 15 Jul 2021 22:51:59 +0800 In-Reply-To: <20210715225146.v2.1.I68649745bd11a83265f1e816bf34ecc82775e95a@changeid> Message-Id: <20210715225146.v2.2.I404c6df9cdab270223c13e867396f440dd4b499d@changeid> Mime-Version: 1.0 References: <20210715225146.v2.1.I68649745bd11a83265f1e816bf34ecc82775e95a@changeid> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog Subject: [PATCH v2 2/3] Bluetooth: hci_h5: btrtl: Maintain flow control if wakeup is enabled From: Archie Pusaka To: linux-bluetooth , Marcel Holtmann Cc: CrosBT Upstreaming , Archie Pusaka , Abhishek Pandit-Subedi , Hilda Wu , Johan Hedberg , Luiz Augusto von Dentz , linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Archie Pusaka For chips that doesn't reset on suspend, we need to provide the correct value of flow_control when it resumes. Therefore, store the flow control value when reading from the config file to be reused upon suspend. Signed-off-by: Archie Pusaka Reviewed-by: Abhishek Pandit-Subedi Reviewed-by: Hilda Wu --- (no changes since v1) drivers/bluetooth/hci_h5.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c index fd672111a048..cbc63b057f33 100644 --- a/drivers/bluetooth/hci_h5.c +++ b/drivers/bluetooth/hci_h5.c @@ -54,6 +54,7 @@ enum { H5_RX_ESC, /* SLIP escape mode */ H5_TX_ACK_REQ, /* Pending ack to send */ H5_WAKEUP_DISABLE, /* Device cannot wake host */ + H5_HW_FLOW_CONTROL, /* Use HW flow control */ }; struct h5 { @@ -920,6 +921,9 @@ static int h5_btrtl_setup(struct h5 *h5) serdev_device_set_baudrate(h5->hu->serdev, controller_baudrate); serdev_device_set_flow_control(h5->hu->serdev, flow_control); + if (flow_control) + set_bit(H5_HW_FLOW_CONTROL, &h5->flags); + err = btrtl_download_firmware(h5->hu->hdev, btrtl_dev); /* Give the device some time before the hci-core sends it a reset */ usleep_range(10000, 20000); @@ -1012,7 +1016,11 @@ static int h5_btrtl_resume(struct h5 *h5) queue_work(system_long_wq, &reprobe->work); } else { gpiod_set_value_cansleep(h5->device_wake_gpio, 1); + + if (test_bit(H5_HW_FLOW_CONTROL, &h5->flags)) + serdev_device_set_flow_control(h5->hu->serdev, true); } + return 0; }