diff mbox series

[BlueZ,1/7] doc/adapter-api: Add SupportedPhyConfiguration property

Message ID 20210722052640.5863-2-ayush.garg@samsung.com (mailing list archive)
State New, archived
Headers show
Series Support for Adapter's Default PHY Configuration | expand

Commit Message

Ayush Garg July 22, 2021, 5:26 a.m. UTC 
This change add a new property to retrieve the PHYs
supported by the controller.

Reviewed-by: Anupam Roy <anupam.r@samsung.com>
---
 doc/adapter-api.txt | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

bluez.test.bot@gmail.com July 22, 2021, 6:45 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=519479

---Test result---

Test Summary:
CheckPatch                    FAIL      1.86 seconds
GitLint                       FAIL      0.84 seconds
Prep - Setup ELL              PASS      47.00 seconds
Build - Prep                  PASS      0.10 seconds
Build - Configure             PASS      8.33 seconds
Build - Make                  PASS      203.42 seconds
Make Check                    PASS      9.65 seconds
Make Distcheck                PASS      241.66 seconds
Build w/ext ELL - Configure   PASS      8.32 seconds
Build w/ext ELL - Make        PASS      191.62 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
adapter: Add support for get/set phy configuration property
WARNING:LONG_LINE_STRING: line length of 82 exceeds 80 columns
#103: FILE: src/adapter.c:3323:
+		g_dbus_pending_property_error(data->id, ERROR_INTERFACE ".Failed",

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#145: FILE: src/adapter.c:3365:
+	unconfigure_phys = adapter->supported_phys & ~(adapter->configurable_phys);

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#171: FILE: src/adapter.c:3391:
+	DBG("sending set phy configuration command for index %u", adapter->dev_id);

WARNING:LONG_LINE_STRING: line length of 82 exceeds 80 columns
#181: FILE: src/adapter.c:3401:
+	btd_error(adapter->dev_id, "Failed to set PHY configuration for index %u",

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#189: FILE: src/adapter.c:3409:
+					const GDBusPropertyTable *property,
 					                         ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#205: FILE: src/adapter.c:3425:
+				const GDBusPropertyTable *property,
 				                         ^

- total: 2 errors, 4 warnings, 312 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] adapter: Add support for get/set phy configuration property" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

adapter: Add support for the get supported phy property
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#20: FILE: src/adapter.c:3409:
+					const GDBusPropertyTable *property,
 					                         ^

- total: 1 errors, 0 warnings, 30 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] adapter: Add support for the get supported phy property" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

adapter: Add support for PHY Configuration Changed event
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#52: FILE: src/adapter.c:9944:
+						phy_configuration_changed_callback,

- total: 0 errors, 1 warnings, 39 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] adapter: Add support for PHY Configuration Changed event" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

client: Add support for get/set PHY configuration in bluetoothctl
WARNING:LONG_LINE_STRING: line length of 87 exceeds 80 columns
#65: FILE: client/main.c:2046:
+					"SupportedPhyConfiguration", "Supported phys");

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#86: FILE: client/main.c:2067:
+					"PhyConfiguration", DBUS_TYPE_STRING, phys,

WARNING:LONG_LINE_STRING: line length of 88 exceeds 80 columns
#87: FILE: client/main.c:2068:
+					phys_len, generic_callback, "PHY Configuration",

- total: 0 errors, 3 warnings, 57 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] client: Add support for get/set PHY configuration in" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
client: Add support for get/set PHY configuration in bluetoothctl
18: B3 Line contains hard tab characters (\t): "	Supported phys: BR1M1SLOT"
19: B3 Line contains hard tab characters (\t): "	Supported phys: BR1M3SLOT"
20: B3 Line contains hard tab characters (\t): "	Supported phys: BR1M5SLOT"
21: B3 Line contains hard tab characters (\t): "	Supported phys: EDR2M1SLOT"
22: B3 Line contains hard tab characters (\t): "	Supported phys: EDR2M3SLOT"
23: B3 Line contains hard tab characters (\t): "	Supported phys: EDR2M5SLOT"
24: B3 Line contains hard tab characters (\t): "	Supported phys: EDR3M1SLOT"
25: B3 Line contains hard tab characters (\t): "	Supported phys: EDR3M3SLOT"
26: B3 Line contains hard tab characters (\t): "	Supported phys: EDR3M5SLOT"
27: B3 Line contains hard tab characters (\t): "	Supported phys: LE1MTX"
28: B3 Line contains hard tab characters (\t): "	Supported phys: LE1MRX"
29: B3 Line contains hard tab characters (\t): "	Selected phys: BR1M1SLOT"
30: B3 Line contains hard tab characters (\t): "	Selected phys: LE1MTX"
31: B3 Line contains hard tab characters (\t): "	Selected phys: LE1MRX"


##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth
Marcel Holtmann July 22, 2021, 2:46 p.m. UTC | #2 
Hi Aysush,

> This change add a new property to retrieve the PHYs
> supported by the controller.
> 
> Reviewed-by: Anupam Roy <anupam.r@samsung.com>
> ---
> doc/adapter-api.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> 
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index 464434a81..25e370d75 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -335,3 +335,24 @@ Properties	string Address [readonly]
> 				"peripheral": Supports the peripheral role.
> 				"central-peripheral": Supports both roles
> 						      concurrently.
> +
> +		array{string} SupportedPhyConfiguration [readonly]
> +
> +			List of PHYs supported by the controller.
> +
> +			Possible values:
> +				"BR1M1SLOT"
> +				"BR1M3SLOT"
> +				"BR1M5SLOT"
> +				"EDR2M1SLOT"
> +				"EDR2M3SLOT"
> +				"EDR2M5SLOT"
> +				"EDR3M1SLOT"
> +				"EDR3M3SLOT"
> +				"EDR3M5SLOT"
> +				"LE1MTX"
> +				"LE1MRX"
> +				"LE2MTX"
> +				"LE2MRX"
> +				"LECODEDTX"
> +				"LECODEDRX"

we don’t do string constants like this in D-Bus API. They are lowercase and verbose “br-1m-1slot” etc. at least.

Regards

Marcel
diff mbox series

Patch

diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
index 464434a81..25e370d75 100644
--- a/doc/adapter-api.txt
+++ b/doc/adapter-api.txt
@@ -335,3 +335,24 @@  Properties	string Address [readonly]
 				"peripheral": Supports the peripheral role.
 				"central-peripheral": Supports both roles
 						      concurrently.
+
+		array{string} SupportedPhyConfiguration [readonly]
+
+			List of PHYs supported by the controller.
+
+			Possible values:
+				"BR1M1SLOT"
+				"BR1M3SLOT"
+				"BR1M5SLOT"
+				"EDR2M1SLOT"
+				"EDR2M3SLOT"
+				"EDR2M5SLOT"
+				"EDR3M1SLOT"
+				"EDR3M3SLOT"
+				"EDR3M5SLOT"
+				"LE1MTX"
+				"LE1MRX"
+				"LE2MTX"
+				"LE2MRX"
+				"LECODEDTX"
+				"LECODEDRX"