diff mbox series

[BlueZ,2/7] doc/adapter-api: Add PhyConfiguration property

Message ID 20210722052640.5863-3-ayush.garg@samsung.com (mailing list archive)
State New, archived
Headers show
Series Support for Adapter's Default PHY Configuration | expand

Commit Message

Ayush Garg July 22, 2021, 5:26 a.m. UTC
This change add a new property which will allow the user
to get the controller's current selected PHYs and to
change it at any point of time.

Reviewed-by: Anupam Roy <anupam.r@samsung.com>
---
 doc/adapter-api.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Luiz Augusto von Dentz July 22, 2021, 5:20 p.m. UTC | #1
Hi Ayush,

On Wed, Jul 21, 2021 at 11:02 PM Ayush Garg <ayush.garg@samsung.com> wrote:
>
> This change add a new property which will allow the user
> to get the controller's current selected PHYs and to
> change it at any point of time.
>
> Reviewed-by: Anupam Roy <anupam.r@samsung.com>
> ---
>  doc/adapter-api.txt | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index 25e370d75..97af8e70b 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -356,3 +356,17 @@ Properties string Address [readonly]
>                                 "LE2MRX"
>                                 "LECODEDTX"
>                                 "LECODEDRX"
> +
> +               array{string} PhyConfiguration [readwrite]
> +
> +                       Set/Get the default PHYs to the controller.
> +
> +                       These PHYs will be used for all the
> +                       subsequent scanning and connection initiation.
> +
> +                       The value of this property is persistent. After
> +                       restart or unplugging of the adapter it will continue
> +                       with the last set PHYs.
> +
> +                       Refer SupportedPhyConfiguration property
> +                       for the possible values.
> --
> 2.17.1

You should probably have create a github issue to discuss the API
first, anyway for the adapter I don't think we should be doing the PHY
configuration at runtime so it would probably have been better to have
such configuration as part of main.conf, and Ive done this with a
exclude logic so one can disable PHYs that it doesn't want the system
to use.
diff mbox series

Patch

diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
index 25e370d75..97af8e70b 100644
--- a/doc/adapter-api.txt
+++ b/doc/adapter-api.txt
@@ -356,3 +356,17 @@  Properties	string Address [readonly]
 				"LE2MRX"
 				"LECODEDTX"
 				"LECODEDRX"
+
+		array{string} PhyConfiguration [readwrite]
+
+			Set/Get the default PHYs to the controller.
+
+			These PHYs will be used for all the
+			subsequent scanning and connection initiation.
+
+			The value of this property is persistent. After
+			restart or unplugging of the adapter it will continue
+			with the last set PHYs.
+
+			Refer SupportedPhyConfiguration property
+			for the possible values.