| Message ID | 20210731154102.GA908767@pc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] bluetooth: bcm203x: update the reference count of udev | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=524445 ---Test result--- Test Summary: CheckPatch PASS 0.42 seconds GitLint PASS 0.10 seconds BuildKernel PASS 510.97 seconds TestRunner: Setup PASS 338.30 seconds TestRunner: l2cap-tester PASS 2.55 seconds TestRunner: bnep-tester PASS 1.92 seconds TestRunner: mgmt-tester PASS 30.45 seconds TestRunner: rfcomm-tester PASS 2.12 seconds TestRunner: sco-tester PASS 2.07 seconds TestRunner: smp-tester FAIL 2.10 seconds TestRunner: userchan-tester PASS 1.94 seconds Details ############################## Test: CheckPatch - PASS - 0.42 seconds Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - PASS - 0.10 seconds Run gitlint with rule in .gitlint ############################## Test: BuildKernel - PASS - 510.97 seconds Build Kernel with minimal configuration supports Bluetooth ############################## Test: TestRunner: Setup - PASS - 338.30 seconds Setup environment for running Test Runner ############################## Test: TestRunner: l2cap-tester - PASS - 2.55 seconds Run test-runner with l2cap-tester Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: bnep-tester - PASS - 1.92 seconds Run test-runner with bnep-tester Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: mgmt-tester - PASS - 30.45 seconds Run test-runner with mgmt-tester Total: 448, Passed: 445 (99.3%), Failed: 0, Not Run: 3 ############################## Test: TestRunner: rfcomm-tester - PASS - 2.12 seconds Run test-runner with rfcomm-tester Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: sco-tester - PASS - 2.07 seconds Run test-runner with sco-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: smp-tester - FAIL - 2.10 seconds Run test-runner with smp-tester Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0 Failed Test Cases SMP Client - SC Request 2 Failed 0.021 seconds ############################## Test: TestRunner: userchan-tester - PASS - 1.94 seconds Run test-runner with userchan-tester Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth
Hi Salah, > Use usb_get_dev() to increment the reference count of the usb device > structure in order to avoid releasing the structure while it is still in > use. And use usb_put_dev() to decrement the reference count and thus, > when it will be equal to 0 the structure will be released. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > Change since v1: > Modification of the description > > drivers/bluetooth/bcm203x.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c > index e667933c3d70..547d35425d70 100644 > --- a/drivers/bluetooth/bcm203x.c > +++ b/drivers/bluetooth/bcm203x.c > @@ -166,7 +166,7 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id > if (!data) > return -ENOMEM; > > - data->udev = udev; > + data->udev = usb_get_dev(udev); > data->state = BCM203X_LOAD_MINIDRV; > > data->urb = usb_alloc_urb(0, GFP_KERNEL); > @@ -244,6 +244,8 @@ static void bcm203x_disconnect(struct usb_interface *intf) > > usb_set_intfdata(intf, NULL); > > + usb_put_dev(data->udev); > + > usb_free_urb(data->urb); > kfree(data->fw_data); > kfree(data->buffer); I do not understand this. If this is something broken, then it is broken in btusb.c as well and that driver is heavily used by all sorts of devices. So we should have seen bug reports about this. Regards Marcel
diff --git a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c index e667933c3d70..547d35425d70 100644 --- a/drivers/bluetooth/bcm203x.c +++ b/drivers/bluetooth/bcm203x.c @@ -166,7 +166,7 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id if (!data) return -ENOMEM; - data->udev = udev; + data->udev = usb_get_dev(udev); data->state = BCM203X_LOAD_MINIDRV; data->urb = usb_alloc_urb(0, GFP_KERNEL); @@ -244,6 +244,8 @@ static void bcm203x_disconnect(struct usb_interface *intf) usb_set_intfdata(intf, NULL); + usb_put_dev(data->udev); + usb_free_urb(data->urb); kfree(data->fw_data); kfree(data->buffer);
Use usb_get_dev() to increment the reference count of the usb device structure in order to avoid releasing the structure while it is still in use. And use usb_put_dev() to decrement the reference count and thus, when it will be equal to 0 the structure will be released. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- Change since v1: Modification of the description drivers/bluetooth/bcm203x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)