diff mbox series

[v3,2/2] btbcm: add patch ram for bluetooth

Message ID 20210812165218.2508258-3-angus@akkea.ca (mailing list archive)
State New, archived
Headers show
Series Add BCM43752 chipset support | expand

Commit Message

Angus Ainslie Aug. 12, 2021, 4:52 p.m. UTC
Bluetooth on the BCM43752 needs a patchram file to function correctly.

Signed-off-by: Angus Ainslie <angus@akkea.ca>
---
 drivers/bluetooth/btbcm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Marcel Holtmann Aug. 16, 2021, 3:58 p.m. UTC | #1
Hi Angus,

> Bluetooth on the BCM43752 needs a patchram file to function correctly.
> 
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> ---
> drivers/bluetooth/btbcm.c | 1 +
> 1 file changed, 1 insertion(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel
Arend Van Spriel Aug. 16, 2021, 9:58 p.m. UTC | #2
On 8/12/2021 6:52 PM, Angus Ainslie wrote:
> Bluetooth on the BCM43752 needs a patchram file to function correctly.
> 
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> ---
>   drivers/bluetooth/btbcm.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index e5d706ed55ea..e4182acee488 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -387,6 +387,7 @@ struct bcm_subver_table {
>   };
>   
>   static const struct bcm_subver_table bcm_uart_subver_table[] = {
> +	{ 0x1111, "BCM4362A2"	},	/* 000.017.017 */

Noticed Marcel applied this one already, but as I asked in earlier patch 
I would like to know why the commit message says 43752 but this entry 
says 4362? Still confused.

Regards,
Arend
Marcel Holtmann Aug. 19, 2021, 3:26 p.m. UTC | #3
Hi Arend,

>> Bluetooth on the BCM43752 needs a patchram file to function correctly.
>> Signed-off-by: Angus Ainslie <angus@akkea.ca>
>> ---
>>  drivers/bluetooth/btbcm.c | 1 +
>>  1 file changed, 1 insertion(+)
>> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
>> index e5d706ed55ea..e4182acee488 100644
>> --- a/drivers/bluetooth/btbcm.c
>> +++ b/drivers/bluetooth/btbcm.c
>> @@ -387,6 +387,7 @@ struct bcm_subver_table {
>>  };
>>    static const struct bcm_subver_table bcm_uart_subver_table[] = {
>> +	{ 0x1111, "BCM4362A2"	},	/* 000.017.017 */
> 
> Noticed Marcel applied this one already, but as I asked in earlier patch I would like to know why the commit message says 43752 but this entry says 4362? Still confused.

seems I missed that part. Can you look internally what this hardware is and we fix it?

Regards

Marcel
Arend Van Spriel Aug. 19, 2021, 3:43 p.m. UTC | #4
On August 19, 2021 5:26:42 PM Marcel Holtmann <marcel@holtmann.org> wrote:

> Hi Arend,
>
>>> Bluetooth on the BCM43752 needs a patchram file to function correctly.
>>> Signed-off-by: Angus Ainslie <angus@akkea.ca>
>>> ---
>>> drivers/bluetooth/btbcm.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
>>> index e5d706ed55ea..e4182acee488 100644
>>> --- a/drivers/bluetooth/btbcm.c
>>> +++ b/drivers/bluetooth/btbcm.c
>>> @@ -387,6 +387,7 @@ struct bcm_subver_table {
>>> };
>>> static const struct bcm_subver_table bcm_uart_subver_table[] = {
>>> + { 0x1111, "BCM4362A2" }, /* 000.017.017 */
>>
>> Noticed Marcel applied this one already, but as I asked in earlier patch I 
>> would like to know why the commit message says 43752 but this entry says 
>> 4362? Still confused.
>
> seems I missed that part. Can you look internally what this hardware is and 
> we fix it?

I will check although not internally as this is probably a Cypress chipset. 
Anyway, I will follow up on this.

Regards,
Arend
diff mbox series

Patch

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index e5d706ed55ea..e4182acee488 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -387,6 +387,7 @@  struct bcm_subver_table {
 };
 
 static const struct bcm_subver_table bcm_uart_subver_table[] = {
+	{ 0x1111, "BCM4362A2"	},	/* 000.017.017 */
 	{ 0x4103, "BCM4330B1"	},	/* 002.001.003 */
 	{ 0x410d, "BCM4334B0"	},	/* 002.001.013 */
 	{ 0x410e, "BCM43341B0"	},	/* 002.001.014 */