diff mbox series

[v2,3/3] Bluetooth: btrtl: Set up Realtek 8822CE for Android BQR commands

Message ID 20210908191915.v2.3.Ic8dcac2622d16775748f9d36c0a5e893372aa48d@changeid (mailing list archive)
State Superseded
Headers show
Series [v2,1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report | expand

Commit Message

Joseph Hwang Sept. 8, 2021, 11:19 a.m. UTC 
This patch sets up Realtek 8822CE to support the Android BQR commands.

Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Signed-off-by: Joseph Hwang <josephsih@chromium.org>
---

Changes in v2:
- Fix the title

 drivers/bluetooth/btrtl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

kernel test robot Sept. 9, 2021, 9:40 a.m. UTC | #1 
Hi Joseph,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20210909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Joseph-Hwang/Bluetooth-btandroid-Support-Android-Bluetooth-Quality-Report/20210908-192118
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: i386-randconfig-f003-20200320 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/3723e13da0251e3fbea4781ce1e4f917301b0bb5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Joseph-Hwang/Bluetooth-btandroid-Support-Android-Bluetooth-Quality-Report/20210908-192118
        git checkout 3723e13da0251e3fbea4781ce1e4f917301b0bb5
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/bluetooth/hci_qca.o: in function `qca_setup':
   drivers/bluetooth/hci_qca.c:1734: undefined reference to `btandroid_set_quality_report'
   ld: drivers/bluetooth/btrtl.o: in function `btrtl_set_quirks':
>> drivers/bluetooth/btrtl.c:750: undefined reference to `btandroid_set_quality_report'


vim +750 drivers/bluetooth/btrtl.c

   733	
   734	void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
   735	{
   736		/* Enable controller to do both LE scan and BR/EDR inquiry
   737		 * simultaneously.
   738		 */
   739		set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
   740	
   741		/* Enable central-peripheral role (able to create new connections with
   742		 * an existing connection in slave role).
   743		 */
   744		/* Enable WBS and quality report supported by the specific devices. */
   745		switch (btrtl_dev->project_id) {
   746		case CHIP_ID_8822C:
   747		case CHIP_ID_8852A:
   748			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
   749			set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
 > 750			hdev->set_quality_report = btandroid_set_quality_report;
   751			break;
   752		default:
   753			rtl_dev_dbg(hdev, "Central-peripheral role not enabled.");
   754			rtl_dev_dbg(hdev, "WBS supported not enabled.");
   755			break;
   756		}
   757	}
   758	EXPORT_SYMBOL_GPL(btrtl_set_quirks);
   759	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff mbox series

Patch

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 1f8afa0244d8..e0bcdbe03eca 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -14,6 +14,7 @@ 
 #include <net/bluetooth/hci_core.h>
 
 #include "btrtl.h"
+#include "btandroid.h"
 
 #define VERSION "0.1"
 
@@ -740,12 +741,13 @@  void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
 	/* Enable central-peripheral role (able to create new connections with
 	 * an existing connection in slave role).
 	 */
-	/* Enable WBS supported for the specific Realtek devices. */
+	/* Enable WBS and quality report supported by the specific devices. */
 	switch (btrtl_dev->project_id) {
 	case CHIP_ID_8822C:
 	case CHIP_ID_8852A:
 		set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
 		set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
+		hdev->set_quality_report = btandroid_set_quality_report;
 		break;
 	default:
 		rtl_dev_dbg(hdev, "Central-peripheral role not enabled.");