| Message ID | 20211013115927.BlueZ.v3.1.I7f6bdb9282c1e12ffc6c662674678f2b1cb69182@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Luiz Von Dentz |
| Headers | show |
| Series | Add Advertisement Monitor Device Lost event | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/setupell | success | Setup ELL PASS |
| tedd_an/buildprep | success | Build Prep PASS |
| tedd_an/build | success | Build Configuration PASS |
| tedd_an/makecheck | success | Make Check PASS |
| tedd_an/makedistcheck | success | Make Distcheck PASS |
| tedd_an/build_extell | success | Build External ELL PASS |
| tedd_an/build_extell_make | success | Build Make with External ELL PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=562967 ---Test result--- Test Summary: CheckPatch PASS 1.30 seconds GitLint PASS 0.85 seconds Prep - Setup ELL PASS 48.42 seconds Build - Prep PASS 0.25 seconds Build - Configure PASS 8.57 seconds Build - Make PASS 202.56 seconds Make Check PASS 9.36 seconds Make Distcheck PASS 243.99 seconds Build w/ext ELL - Configure PASS 8.72 seconds Build w/ext ELL - Make PASS 191.73 seconds --- Regards, Linux Bluetooth
Hi Manish, On Wed, Oct 13, 2021 at 12:00 PM Manish Mandlik <mmandlik@google.com> wrote: > > Add a new event 'Adv Monitor Device Lost' to indicate that the > controller has stopped tracking a particular device. > > --- > > Changes in v3: > - Discard changes to the Device Found event and notify bluetoothd only > when the controller stops monitoring the device via new Device Lost > event. > > Changes in v2: > - Instead of creating a new 'Device Tracking' event, add a flag 'Device > Tracked' in the existing 'Device Found' event and add a new 'Device > Lost' event to indicate that the controller has stopped tracking that > device. > > doc/mgmt-api.txt | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > index 5355fedb0..712bb362d 100644 > --- a/doc/mgmt-api.txt > +++ b/doc/mgmt-api.txt > @@ -107,7 +107,8 @@ Configuration command, Default Runtime Configuration Changed event, Get > Device Flags command, Set Device Flags command, Device Flags Changed event, > Read Advertisement Monitor Features command, Add Advertisement Patterns > Monitor command, Remove Advertisement Monitor command, Advertisement Monitor > -Added event and Advertisement Monitor Removed event. > +Added event, Advertisement Monitor Removed event and Advertisement Monitor > +Device Lost event. > > > Example > @@ -4910,3 +4911,26 @@ Controller Resume Event > Address_Type. Otherwise, Address and Address_Type will both be zero. > > This event will be sent to all management sockets. > + > + > +Advertisement Monitor Device Lost Event > +======================================= > + > + Event code: 0x002f > + Controller Index: <controller_id> > + Event Parameters: Monitor_Handle (2 Octets) > + Address (6 Octets) > + Address_Type (1 Octet) > + > + This event indicates that the controller has stopped tracking the > + device that was being tracked by monitor with handle Monitor_Handle. > + > + The address of the device being tracked will be shared in Address and > + Address_Type. > + > + Possible values for the Address_Type parameter: > + 0 BR/EDR Can the address really be BR/EDR? I always assumed adv monitor to be LE only, or am I mistaken? > + 1 LE Public > + 2 LE Random > + > + This event will be sent to all management sockets. > -- > 2.33.0.882.g93a45727a2-goog >
Hi Manish, > Add a new event 'Adv Monitor Device Lost' to indicate that the > controller has stopped tracking a particular device. > > --- > > Changes in v3: > - Discard changes to the Device Found event and notify bluetoothd only > when the controller stops monitoring the device via new Device Lost > event. > > Changes in v2: > - Instead of creating a new 'Device Tracking' event, add a flag 'Device > Tracked' in the existing 'Device Found' event and add a new 'Device > Lost' event to indicate that the controller has stopped tracking that > device. > > doc/mgmt-api.txt | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > index 5355fedb0..712bb362d 100644 > --- a/doc/mgmt-api.txt > +++ b/doc/mgmt-api.txt > @@ -107,7 +107,8 @@ Configuration command, Default Runtime Configuration Changed event, Get > Device Flags command, Set Device Flags command, Device Flags Changed event, > Read Advertisement Monitor Features command, Add Advertisement Patterns > Monitor command, Remove Advertisement Monitor command, Advertisement Monitor > -Added event and Advertisement Monitor Removed event. > +Added event, Advertisement Monitor Removed event and Advertisement Monitor > +Device Lost event. > > > Example > @@ -4910,3 +4911,26 @@ Controller Resume Event > Address_Type. Otherwise, Address and Address_Type will both be zero. > > This event will be sent to all management sockets. I would consider adding a Advertising Monitor Device Found Event that is similar to the Device Found event, but also includes the Monitor_Handle. It just makes this whole thing a bit more symmetric. > + > + > +Advertisement Monitor Device Lost Event > +======================================= > + > + Event code: 0x002f > + Controller Index: <controller_id> > + Event Parameters: Monitor_Handle (2 Octets) > + Address (6 Octets) > + Address_Type (1 Octet) > + > + This event indicates that the controller has stopped tracking the > + device that was being tracked by monitor with handle Monitor_Handle. > + > + The address of the device being tracked will be shared in Address and > + Address_Type. > + > + Possible values for the Address_Type parameter: > + 0 BR/EDR > + 1 LE Public > + 2 LE Random > + > + This event will be sent to all management sockets. And as noted by Luiz, make 0 Reserved since we only do this for LE at the moment. Regards Marcel
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index 5355fedb0..712bb362d 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -107,7 +107,8 @@ Configuration command, Default Runtime Configuration Changed event, Get Device Flags command, Set Device Flags command, Device Flags Changed event, Read Advertisement Monitor Features command, Add Advertisement Patterns Monitor command, Remove Advertisement Monitor command, Advertisement Monitor -Added event and Advertisement Monitor Removed event. +Added event, Advertisement Monitor Removed event and Advertisement Monitor +Device Lost event. Example @@ -4910,3 +4911,26 @@ Controller Resume Event Address_Type. Otherwise, Address and Address_Type will both be zero. This event will be sent to all management sockets. + + +Advertisement Monitor Device Lost Event +======================================= + + Event code: 0x002f + Controller Index: <controller_id> + Event Parameters: Monitor_Handle (2 Octets) + Address (6 Octets) + Address_Type (1 Octet) + + This event indicates that the controller has stopped tracking the + device that was being tracked by monitor with handle Monitor_Handle. + + The address of the device being tracked will be shared in Address and + Address_Type. + + Possible values for the Address_Type parameter: + 0 BR/EDR + 1 LE Public + 2 LE Random + + This event will be sent to all management sockets.