[BlueZ] mesh: Fix sequence number of message in friend queue

Commit Message

Brian Gix Jan. 19, 2022, 3:49 p.m. UTC

As pointed out by https://github.com/bluez/bluez/issues/250, the last
segment of a multi-segmented message added to Friend Queue was getting
reset to the seqAuth value incorrectly. The correct sequence was set
within the preceding for loop.
---
 mesh/net.c | 1 -
 1 file changed, 1 deletion(-)

Comments

[e-mail] Jan. 19, 2022, 4:48 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=606649

---Test result---

Test Summary:
CheckPatch                    PASS      1.32 seconds
GitLint                       PASS      0.95 seconds
Prep - Setup ELL              PASS      41.93 seconds
Build - Prep                  PASS      0.68 seconds
Build - Configure             PASS      8.39 seconds
Build - Make                  PASS      1232.92 seconds
Make Check                    PASS      12.18 seconds
Make Check w/Valgrind         PASS      434.57 seconds
Make Distcheck                PASS      223.46 seconds
Build w/ext ELL - Configure   PASS      8.40 seconds
Build w/ext ELL - Make        PASS      1212.99 seconds
Incremental Build with patchesPASS      0.00 seconds



---
Regards,
Linux Bluetooth

Patch

diff --git a/mesh/net.c b/mesh/net.c
index aa220f762..dd5398487 100644
--- a/mesh/net.c
+++ b/mesh/net.c
@@ -1325,7 +1325,6 @@  static bool friend_packet_queue(struct mesh_net *net,
 			hdr += (1 << SEGO_HDR_SHIFT);
 		}
 
-		frnd_msg->u.s12[seg_max].seq = seq;
 		frnd_msg->cnt_in = seg_max;
 		frnd_msg->last_len = size % 12;
 		if (!frnd_msg->last_len)