From patchwork Tue Jan 25 16:14:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viacheslav X-Patchwork-Id: 12723996 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4946C433F5 for ; Tue, 25 Jan 2022 16:17:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1449912AbiAYQQ4 (ORCPT ); Tue, 25 Jan 2022 11:16:56 -0500 Received: from mx.msync.work ([95.217.65.204]:39750 "EHLO mx.msync.work" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240533AbiAYQOv (ORCPT ); Tue, 25 Jan 2022 11:14:51 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B5866280BE1; Tue, 25 Jan 2022 16:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lexina.in; s=dkim; t=1643127257; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=ZaUa/CaL6dxwiDX9xBVtw2/ZWg2BaHlrMqUB+epYmUg=; b=dLHeUTAChNUc0fo0L5fQQcmbgb+RJFWBi1yNUJRTRReqcjhKuo629cJt1jRvJYLzI3lv6d 1gmSrxUaQIgYFrxNKPSysToV1viAtXMX/7kA1fhJHl8FTSBNFTqVdY+O3d660zNOlp46Pp xlRz24w8tl1EoB75mNMbMJGPoIvaW1EZ6E6Gn5BtZ2kdpk8VwGcS9n0rUB66if0hzvtGPb 4M+7pqysD00VeFM5yxa6Xd6ok1t81Yye/uc1zITw0jZZr8VM2xyWyI4e77M35CqNJSzQq3 xcNp8dkh+xFcrWh+JKFRX6yCUp2Dd7jxyxlt9izyAJqR8KFrig0eMiORjSbevQ== From: Vyacheslav Bocharov To: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rudi Heitbaum Subject: [PATCH v5 2/2] Bluetooth: hci_h5: Add power reset via gpio in h5_btrtl_open Date: Tue, 25 Jan 2022 19:14:01 +0300 Message-Id: <20220125161401.729179-3-adeep@lexina.in> In-Reply-To: <20220125161401.729179-1-adeep@lexina.in> References: <20220125161401.729179-1-adeep@lexina.in> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Add power reset for bluetooth via enable-gpios in h5_btrtl_open function. Signed-off-by: Vyacheslav Bocharov --- While testing the RTL8822CS SDIO WiFi/BT adapter, I found that in some cases the kernel could not initialize it. However, manually resetting the adapter via gpio allows it to start correctly. Apparently at system start the adapter is in an undefined state (including the unknown state of gpio after starting uboot). A forced reset helps to initialize the adapter in most cases. Experimentally it was found that 100ms is enough to reset. drivers/bluetooth/hci_h5.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c index 34286ffe0568..fdf504b0d265 100644 --- a/drivers/bluetooth/hci_h5.c +++ b/drivers/bluetooth/hci_h5.c @@ -966,6 +966,11 @@ static void h5_btrtl_open(struct h5 *h5) pm_runtime_enable(&h5->hu->serdev->dev); } + /* The controller needs reset to startup */ + gpiod_set_value_cansleep(h5->enable_gpio, 0); + gpiod_set_value_cansleep(h5->device_wake_gpio, 0); + msleep(100); + /* The controller needs up to 500ms to wakeup */ gpiod_set_value_cansleep(h5->enable_gpio, 1); gpiod_set_value_cansleep(h5->device_wake_gpio, 1);