| Message ID | 20220201174256.1690515-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Luiz Von Dentz |
| Headers | show |
| Series | Bluetooth: hci_sync: fix undefined return of hci_disconnect_all_sync() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/subjectprefix | success | PASS |
| tedd_an/buildkernel | success | Build Kernel PASS |
| tedd_an/buildkernel32 | success | Build Kernel32 PASS |
| tedd_an/incremental_build | success | Pass |
| tedd_an/testrunnersetup | success | Test Runner Setup PASS |
| tedd_an/testrunnerl2cap-tester | success | Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerbnep-tester | success | Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermgmt-tester | success | Total: 493, Passed: 493 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerrfcomm-tester | success | Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersco-tester | success | Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersmp-tester | success | Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneruserchan-tester | success | Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0 |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=610424 ---Test result--- Test Summary: CheckPatch PASS 1.70 seconds GitLint PASS 1.03 seconds SubjectPrefix PASS 0.85 seconds BuildKernel PASS 37.44 seconds BuildKernel32 PASS 32.39 seconds Incremental Build with patchesPASS 44.16 seconds TestRunner: Setup PASS 604.98 seconds TestRunner: l2cap-tester PASS 16.73 seconds TestRunner: bnep-tester PASS 7.82 seconds TestRunner: mgmt-tester PASS 129.30 seconds TestRunner: rfcomm-tester PASS 9.40 seconds TestRunner: sco-tester PASS 9.86 seconds TestRunner: smp-tester PASS 9.72 seconds TestRunner: userchan-tester PASS 8.10 seconds --- Regards, Linux Bluetooth
Hi Tom, On Tue, Feb 1, 2022 at 9:43 AM <trix@redhat.com> wrote: > > From: Tom Rix <trix@redhat.com> > > clang static analysis reports this problem > hci_sync.c:4428:2: warning: Undefined or garbage value > returned to caller > return err; > ^~~~~~~~~~ > > If there are no connections this function is a noop but > err is never set and a false error could be reported. > Return 0 as other hci_* functions do. > > Fixes: 182ee45da083 ("Bluetooth: hci_sync: Rework hci_suspend_notifier") > Signed-off-by: Tom Rix <trix@redhat.com> > --- > net/bluetooth/hci_sync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c > index 6e71aa6b6feae..9327737da6003 100644 > --- a/net/bluetooth/hci_sync.c > +++ b/net/bluetooth/hci_sync.c > @@ -4425,7 +4425,7 @@ static int hci_disconnect_all_sync(struct hci_dev *hdev, u8 reason) > return err; > } > > - return err; > + return 0; > } > > /* This function perform power off HCI command sequence as follows: > -- > 2.26.3 Applied, thanks.
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index 6e71aa6b6feae..9327737da6003 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -4425,7 +4425,7 @@ static int hci_disconnect_all_sync(struct hci_dev *hdev, u8 reason) return err; } - return err; + return 0; } /* This function perform power off HCI command sequence as follows: