| Message ID | 20220209092414.751642-1-josephsih@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [BlueZ,v3,1/9] doc: Add Bluetooth quality report event | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/setupell | success | Setup ELL PASS |
| tedd_an/buildprep | success | Build Prep PASS |
| tedd_an/build | success | Build Configuration PASS |
| tedd_an/makecheck | success | Make Check PASS |
| tedd_an/makecheckvalgrind | success | Make Check PASS |
| tedd_an/makedistcheck | success | Make Distcheck PASS |
| tedd_an/build_extell | success | Build External ELL PASS |
| tedd_an/build_extell_make | success | Build Make with External ELL PASS |
| tedd_an/incremental_build | success | Pass |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=612544 ---Test result--- Test Summary: CheckPatch PASS 13.81 seconds GitLint PASS 9.23 seconds Prep - Setup ELL PASS 48.47 seconds Build - Prep PASS 0.90 seconds Build - Configure PASS 9.31 seconds Build - Make PASS 1511.45 seconds Make Check PASS 11.25 seconds Make Check w/Valgrind PASS 447.60 seconds Make Distcheck PASS 231.77 seconds Build w/ext ELL - Configure PASS 8.17 seconds Build w/ext ELL - Make PASS 1430.29 seconds Incremental Build with patchesPASS 13382.32 seconds --- Regards, Linux Bluetooth
Hi Joseph, > Add the Bluetooth quality report event in doc/mgmt-api.txt. > > Signed-off-by: Joseph Hwang <josephsih@chromium.org> > --- > > Changes in v3: > - Swap AOSP Bluetooth Quality Report Event and Intel Telemetry Event. > - Add 5 new patches (5/9 - 9/9) to enable the quality report > feature via MGMT_OP_SET_QUALITY_REPORT instead of through the > experimental features. > > Changes in v2: > - This is a new patch for adding the event in doc/mgmt-api.txt > > doc/mgmt-api.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > index ebe56afa4..5a32091fa 100644 > --- a/doc/mgmt-api.txt > +++ b/doc/mgmt-api.txt > @@ -4978,3 +4978,22 @@ Advertisement Monitor Device Lost Event > 2 LE Random > > This event will be sent to all management sockets. > + > + > +Bluetooth Quality Report Event > +============================== so this is on me since I never realized this. You stuck the Bluetooth word in front of the event name since that is also what AOSP calls it. However in mgmt-api.txt we have never added Bluetooth to command or event naming since that is obvious. So lets shorten this and just use “Quality Report Event”. > + > + Event code: 0x0031 > + Controller Index: <controller_id> > + Event Parameters: Quality_Spec (1 Octet) > + Report_Len (2 Octets) > + Report (0-65535 Octets) > + > + This event carries the Bluetooth quality report sent by the > + controller. > + > + Possible values for the Quality_Spec parameter: > + 0 AOSP Bluetooth Quality Report Event > + 1 Intel Telemetry Event > + > + This event will be sent to all management sockets. > — In addition, I prefer to have both command and event changes in a single patch. Regards Marcel
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index ebe56afa4..5a32091fa 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -4978,3 +4978,22 @@ Advertisement Monitor Device Lost Event 2 LE Random This event will be sent to all management sockets. + + +Bluetooth Quality Report Event +============================== + + Event code: 0x0031 + Controller Index: <controller_id> + Event Parameters: Quality_Spec (1 Octet) + Report_Len (2 Octets) + Report (0-65535 Octets) + + This event carries the Bluetooth quality report sent by the + controller. + + Possible values for the Quality_Spec parameter: + 0 AOSP Bluetooth Quality Report Event + 1 Intel Telemetry Event + + This event will be sent to all management sockets.
Add the Bluetooth quality report event in doc/mgmt-api.txt. Signed-off-by: Joseph Hwang <josephsih@chromium.org> --- Changes in v3: - Swap AOSP Bluetooth Quality Report Event and Intel Telemetry Event. - Add 5 new patches (5/9 - 9/9) to enable the quality report feature via MGMT_OP_SET_QUALITY_REPORT instead of through the experimental features. Changes in v2: - This is a new patch for adding the event in doc/mgmt-api.txt doc/mgmt-api.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)