[BlueZ] tools/mesh-cfgtest: include limits.h

Commit Message

Fabrice Fontaine Feb. 15, 2022, 10:50 p.m. UTC

From: Michael Nosthoff <[e-mail]>

mesh-cfgtest.c uses PATH_MAX so it should include limits.h.

fixes compilation error when enabling mesh support with musl-based
toolchains observed in buildroot autobuilders.

http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/

Signed-off-by: Michael Nosthoff <[e-mail]>
---
I'm sending back this patch as for an unknown reason, the patch sent by
Michael in July 2021 is set as superseded in patchwork:
https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]

 tools/mesh-cfgtest.c | 1 +
 1 file changed, 1 insertion(+)

Comments

[e-mail] Feb. 16, 2022, 12:22 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=614720

---Test result---

Test Summary:
CheckPatch                    FAIL      1.40 seconds
GitLint                       FAIL      0.99 seconds
Prep - Setup ELL              PASS      41.86 seconds
Build - Prep                  PASS      0.77 seconds
Build - Configure             PASS      8.46 seconds
Build - Make                  PASS      1361.27 seconds
Make Check                    PASS      11.94 seconds
Make Check w/Valgrind         PASS      437.89 seconds
Make Distcheck                PASS      225.60 seconds
Build w/ext ELL - Configure   PASS      8.57 seconds
Build w/ext ELL - Make        PASS      1344.82 seconds
Incremental Build with patchesPASS      0.00 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] tools/mesh-cfgtest: include limits.h
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#87: 
http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/

/github/workspace/src/12747687.patch total: 0 errors, 1 warnings, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12747687.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ] tools/mesh-cfgtest: include limits.h
17: B1 Line exceeds max length (92>80): "https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]"




---
Regards,
Linux Bluetooth

Michael Nosthoff Feb. 16, 2022, 11:57 a.m. UTC | #2

Hi Fabrice,

On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <[e-mail]> wrote:

> ---
> I'm sending back this patch as for an unknown reason, the patch sent by
> Michael in July 2021 is set as superseded in patchwork:
> https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]
> 
I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?

https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]/

Regards,
Michael

Fabrice Fontaine Feb. 16, 2022, 12:35 p.m. UTC | #3

Hi Michael,

Le mer. 16 févr. 2022 à 12:57, Michael Nosthoff <[e-mail]> a écrit :
>
> Hi Fabrice,
>
> On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <[e-mail]> wrote:
>
> > ---
> > I'm sending back this patch as for an unknown reason, the patch sent by
> > Michael in July 2021 is set as superseded in patchwork:
> > https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]
> >
> I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
> urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?
>
> https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]/

Thanks for pointing out v2, I missed it.
Would be great to merge one of the version of this patch so we can
drop it from buildroot.

>
> Regards,
> Michael
>
Best Regards,

Fabrice

Brian Gix Feb. 16, 2022, 6:34 p.m. UTC | #4

The clean applying version of this patch has  been applied. This is *not* the one with the Notes attached which
broke length rules in the commit message.

On Wed, 2022-02-16 at 12:57 +0100, Michael Nosthoff wrote:
> Hi Fabrice,
> 
> On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <[e-mail]> wrote:
> 
> > ---
> > I'm sending back this patch as for an unknown reason, the patch sent by
> > Michael in July 2021 is set as superseded in patchwork:
> > https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]
> > 
> I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
> urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?
> 
> https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]/
> 
> Regards,
> Michael
>

Patch

diff --git a/tools/mesh-cfgtest.c b/tools/mesh-cfgtest.c
index fa0474faa..116ab7f16 100644
--- a/tools/mesh-cfgtest.c
+++ b/tools/mesh-cfgtest.c
@@ -21,6 +21,7 @@ 
 #include <ftw.h>
 #include <getopt.h>
 #include <libgen.h>
+#include <limits.h>
 #include <signal.h>
 #include <stdio.h>
 #include <time.h>