diff mbox series

[BlueZ,1/9] adv_monitor: Disable RSSIHighTimeout for SW based filtering

Message ID 20220320183445.BlueZ.1.I21d5ed25e9a0a2427bddbd6d4ec04d80d735fc53@changeid (mailing list archive)
State Superseded
Headers show
Series [BlueZ,1/9] adv_monitor: Disable RSSIHighTimeout for SW based filtering | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck fail Make Check FAIL: src/adv_monitor.c: In function ‘btd_adv_monitor_resume’: src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration] 2402 | if (!btd_adv_monitor_offload_supported(manager)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | btd_adv_monitor_offload_enabled cc1: all warnings being treated as errors make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1 make: *** [Makefile:11277: check] Error 2
tedd_an/makecheckvalgrind fail Make FAIL: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12364 | int main(int argc, char *argv[]) | ^~~~ src/adv_monitor.c: In function ‘btd_adv_monitor_resume’: src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration] 2402 | if (!btd_adv_monitor_offload_supported(manager)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | btd_adv_monitor_offload_enabled cc1: all warnings being treated as errors make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1 make: *** [Makefile:4307: all] Error 2
tedd_an/makedistcheck fail Make Distcheck Make FAIL: ../../src/adv_monitor.c: In function ‘btd_adv_monitor_resume’: ../../src/adv_monitor.c:2402:7: warning: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Wimplicit-function-declaration] 2402 | if (!btd_adv_monitor_offload_supported(manager)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | btd_adv_monitor_offload_enabled /usr/bin/ld: src/bluetoothd-adv_monitor.o: in function `btd_adv_monitor_resume': /github/workspace/src/bluez-5.63/_build/sub/../../src/adv_monitor.c:2402: undefined reference to `btd_adv_monitor_offload_supported' collect2: error: ld returned 1 exit status make[2]: *** [Makefile:5878: src/bluetoothd] Error 1 make[1]: *** [Makefile:4307: all] Error 2 make: *** [Makefile:11198: distcheck] Error 1
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make fail Build Make with External ELL FAIL: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12364 | int main(int argc, char *argv[]) | ^~~~ unit/test-avdtp.c: In function ‘main’: unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 766 | int main(int argc, char *argv[]) | ^~~~ unit/test-avrcp.c: In function ‘main’: unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 989 | int main(int argc, char *argv[]) | ^~~~ src/adv_monitor.c: In function ‘btd_adv_monitor_resume’: src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration] 2402 | if (!btd_adv_monitor_offload_supported(manager)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | btd_adv_monitor_offload_enabled cc1: all warnings being treated as errors make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1 make: *** [Makefile:4307: all] Error 2

Commit Message

Manish Mandlik March 21, 2022, 1:36 a.m. UTC
Controller offloading does not support High RSSI Timeout. Disable High
RSSI Timeout for SW based filtering as well to provide a consistent
behavior between SW based and controller based monitoring.

Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
---

 doc/advertisement-monitor-api.txt | 5 +++++
 src/adv_monitor.c                 | 6 ++++++
 2 files changed, 11 insertions(+)

Comments

bluez.test.bot@gmail.com March 21, 2022, 4:02 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=624998

---Test result---

Test Summary:
CheckPatch                    PASS      13.09 seconds
GitLint                       PASS      8.89 seconds
Prep - Setup ELL              PASS      46.69 seconds
Build - Prep                  PASS      0.76 seconds
Build - Configure             PASS      9.23 seconds
Build - Make                  FAIL      1504.46 seconds
Make Check                    FAIL      2.42 seconds
Make Check w/Valgrind         FAIL      324.61 seconds
Make Distcheck                FAIL      173.77 seconds
Build w/ext ELL - Configure   PASS      9.30 seconds
Build w/ext ELL - Make        FAIL      1466.64 seconds
Incremental Build with patchesFAIL      4186.16 seconds

Details
##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12364 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  766 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  989 | int main(int argc, char *argv[])
      |     ^~~~
src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
 2402 |  if (!btd_adv_monitor_offload_supported(manager))
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       btd_adv_monitor_offload_enabled
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
make: *** [Makefile:4307: all] Error 2


##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
 2402 |  if (!btd_adv_monitor_offload_supported(manager))
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       btd_adv_monitor_offload_enabled
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
make: *** [Makefile:11277: check] Error 2


##############################
Test: Make Check w/Valgrind - FAIL
Desc: Run 'make check' with Valgrind
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12364 | int main(int argc, char *argv[])
      |     ^~~~
src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
 2402 |  if (!btd_adv_monitor_offload_supported(manager))
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       btd_adv_monitor_offload_enabled
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
make: *** [Makefile:4307: all] Error 2


##############################
Test: Make Distcheck - FAIL
Desc: Run distcheck to check the distribution
Output:
../../src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
../../src/adv_monitor.c:2402:7: warning: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Wimplicit-function-declaration]
 2402 |  if (!btd_adv_monitor_offload_supported(manager))
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       btd_adv_monitor_offload_enabled
/usr/bin/ld: src/bluetoothd-adv_monitor.o: in function `btd_adv_monitor_resume':
/github/workspace/src/bluez-5.63/_build/sub/../../src/adv_monitor.c:2402: undefined reference to `btd_adv_monitor_offload_supported'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:5878: src/bluetoothd] Error 1
make[1]: *** [Makefile:4307: all] Error 2
make: *** [Makefile:11198: distcheck] Error 1


##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12364 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  766 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  989 | int main(int argc, char *argv[])
      |     ^~~~
src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
 2402 |  if (!btd_adv_monitor_offload_supported(manager))
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       btd_adv_monitor_offload_enabled
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
make: *** [Makefile:4307: all] Error 2


##############################
Test: Incremental Build with patches - FAIL
Desc: Incremental build per patch in the series
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12364 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  766 | int main(int argc, char *argv[])
      |     ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  989 | int main(int argc, char *argv[])
      |     ^~~~
src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
src/adv_monitor.c:2308:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
 2308 |  if (!btd_adv_monitor_offload_supported(manager))
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       btd_adv_monitor_offload_enabled
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
make: *** [Makefile:4307: all] Error 2




---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz March 29, 2022, 8:19 p.m. UTC | #2
Hi Manish,

On Mon, Mar 21, 2022 at 4:53 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=624998
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      13.09 seconds
> GitLint                       PASS      8.89 seconds
> Prep - Setup ELL              PASS      46.69 seconds
> Build - Prep                  PASS      0.76 seconds
> Build - Configure             PASS      9.23 seconds
> Build - Make                  FAIL      1504.46 seconds
> Make Check                    FAIL      2.42 seconds
> Make Check w/Valgrind         FAIL      324.61 seconds
> Make Distcheck                FAIL      173.77 seconds
> Build w/ext ELL - Configure   PASS      9.30 seconds
> Build w/ext ELL - Make        FAIL      1466.64 seconds
> Incremental Build with patchesFAIL      4186.16 seconds
>
> Details
> ##############################
> Test: Build - Make - FAIL
> Desc: Build the BlueZ source tree
> Output:
> tools/mgmt-tester.c: In function ‘main’:
> tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
> 12364 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avdtp.c: In function ‘main’:
> unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
>   766 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avrcp.c: In function ‘main’:
> unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
>   989 | int main(int argc, char *argv[])
>       |     ^~~~
> src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
> src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
>  2402 |  if (!btd_adv_monitor_offload_supported(manager))
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       btd_adv_monitor_offload_enabled
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
> make: *** [Makefile:4307: all] Error 2
>
>
> ##############################
> Test: Make Check - FAIL
> Desc: Run 'make check'
> Output:
> src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
> src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
>  2402 |  if (!btd_adv_monitor_offload_supported(manager))
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       btd_adv_monitor_offload_enabled
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
> make: *** [Makefile:11277: check] Error 2
>
>
> ##############################
> Test: Make Check w/Valgrind - FAIL
> Desc: Run 'make check' with Valgrind
> Output:
> tools/mgmt-tester.c: In function ‘main’:
> tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
> 12364 | int main(int argc, char *argv[])
>       |     ^~~~
> src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
> src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
>  2402 |  if (!btd_adv_monitor_offload_supported(manager))
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       btd_adv_monitor_offload_enabled
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
> make: *** [Makefile:4307: all] Error 2
>
>
> ##############################
> Test: Make Distcheck - FAIL
> Desc: Run distcheck to check the distribution
> Output:
> ../../src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
> ../../src/adv_monitor.c:2402:7: warning: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Wimplicit-function-declaration]
>  2402 |  if (!btd_adv_monitor_offload_supported(manager))
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       btd_adv_monitor_offload_enabled
> /usr/bin/ld: src/bluetoothd-adv_monitor.o: in function `btd_adv_monitor_resume':
> /github/workspace/src/bluez-5.63/_build/sub/../../src/adv_monitor.c:2402: undefined reference to `btd_adv_monitor_offload_supported'
> collect2: error: ld returned 1 exit status
> make[2]: *** [Makefile:5878: src/bluetoothd] Error 1
> make[1]: *** [Makefile:4307: all] Error 2
> make: *** [Makefile:11198: distcheck] Error 1
>
>
> ##############################
> Test: Build w/ext ELL - Make - FAIL
> Desc: Build BlueZ source with '--enable-external-ell' configuration
> Output:
> tools/mgmt-tester.c: In function ‘main’:
> tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
> 12364 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avdtp.c: In function ‘main’:
> unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
>   766 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avrcp.c: In function ‘main’:
> unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
>   989 | int main(int argc, char *argv[])
>       |     ^~~~
> src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
> src/adv_monitor.c:2402:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
>  2402 |  if (!btd_adv_monitor_offload_supported(manager))
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       btd_adv_monitor_offload_enabled
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
> make: *** [Makefile:4307: all] Error 2
>
>
> ##############################
> Test: Incremental Build with patches - FAIL
> Desc: Incremental build per patch in the series
> Output:
> tools/mgmt-tester.c: In function ‘main’:
> tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
> 12364 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avdtp.c: In function ‘main’:
> unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
>   766 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avrcp.c: In function ‘main’:
> unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
>   989 | int main(int argc, char *argv[])
>       |     ^~~~
> src/adv_monitor.c: In function ‘btd_adv_monitor_resume’:
> src/adv_monitor.c:2308:7: error: implicit declaration of function ‘btd_adv_monitor_offload_supported’; did you mean ‘btd_adv_monitor_offload_enabled’? [-Werror=implicit-function-declaration]
>  2308 |  if (!btd_adv_monitor_offload_supported(manager))
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       btd_adv_monitor_offload_enabled
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:10284: src/bluetoothd-adv_monitor.o] Error 1
> make: *** [Makefile:4307: all] Error 2

Will you be fixing the errors above?
diff mbox series

Patch

diff --git a/doc/advertisement-monitor-api.txt b/doc/advertisement-monitor-api.txt
index 9189f2cce..942d44b2f 100644
--- a/doc/advertisement-monitor-api.txt
+++ b/doc/advertisement-monitor-api.txt
@@ -79,6 +79,11 @@  Properties	string Type [read-only]
 			in-range (found). Valid range is 1 to 300 (seconds),
 			while 0 indicates unset.
 
+			NOTE: Controller offloading does not support High RSSI
+			Timeout. So, to provide a consistent behavior between
+			SW based and controller based monitoring, this property
+			has been disabled and deprecated.
+
 		Uint16 RSSISamplingPeriod [read-only, optional]
 
 			Grouping rules on how to propagate the received
diff --git a/src/adv_monitor.c b/src/adv_monitor.c
index 33f4d9619..a1778248f 100644
--- a/src/adv_monitor.c
+++ b/src/adv_monitor.c
@@ -860,6 +860,12 @@  static bool parse_rssi_and_timeout(struct adv_monitor *monitor,
 	monitor->rssi.low_rssi_timeout = l_rssi_timeout;
 	monitor->rssi.sampling_period = sampling_period;
 
+	/* Controller offloading does not support High RSSI Timeout. Disable
+	 * High RSSI Timeout for SW based filtering to provide a consistent
+	 * behavior between SW based and controller based monitoring.
+	 */
+	monitor->rssi.high_rssi_timeout = ADV_MONITOR_UNSET_TIMEOUT;
+
 done:
 	DBG("Adv Monitor at %s initiated with high RSSI threshold %d, high "
 		"RSSI threshold timeout %d, low RSSI threshold %d, low RSSI "