[BlueZ] tools: Fix g_dbus_setup_private connection check in mpris-proxy

Commit Message

Frédéric Danis March 30, 2022, 9:47 a.m. UTC

---
 tools/mpris-proxy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] March 30, 2022, 11:09 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=627447

---Test result---

Test Summary:
CheckPatch                    PASS      1.57 seconds
GitLint                       PASS      1.10 seconds
Prep - Setup ELL              PASS      51.59 seconds
Build - Prep                  PASS      0.93 seconds
Build - Configure             PASS      10.28 seconds
Build - Make                  PASS      1821.30 seconds
Make Check                    PASS      12.59 seconds
Make Check w/Valgrind         PASS      528.58 seconds
Make Distcheck                PASS      276.12 seconds
Build w/ext ELL - Configure   PASS      10.18 seconds
Build w/ext ELL - Make        PASS      1781.88 seconds
Incremental Build with patchesPASS      0.00 seconds



---
Regards,
Linux Bluetooth

[e-mail] April 4, 2022, 5:14 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Wed, 30 Mar 2022 11:47:40 +0200 you wrote:
> ---
>  tools/mpris-proxy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] tools: Fix g_dbus_setup_private connection check in mpris-proxy
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0f382885d4a3

You are awesome, thank you!

Patch

diff --git a/tools/mpris-proxy.c b/tools/mpris-proxy.c
index 91a25501d..3779b6887 100644
--- a/tools/mpris-proxy.c
+++ b/tools/mpris-proxy.c
@@ -1978,7 +1978,7 @@  static void register_player(GDBusProxy *proxy)
 
 	player->conn = g_dbus_setup_private(DBUS_BUS_SESSION, player->bus_name,
 									NULL);
-	if (!session) {
+	if (!player->conn) {
 		fprintf(stderr, "Could not register bus name %s",
 							player->bus_name);
 		goto fail;