diff mbox series

Bluetooth: btintel: fix btintel_download_firmware stub signature

Message ID 20220331174959.3421978-1-trix@redhat.com (mailing list archive)
State New, archived
Headers show
Series Bluetooth: btintel: fix btintel_download_firmware stub signature | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/subjectprefix success PASS
tedd_an/buildkernel success Build Kernel PASS
tedd_an/buildkernel32 success Build Kernel32 PASS
tedd_an/incremental_build success Pass
tedd_an/testrunnersetup success Test Runner Setup PASS
tedd_an/testrunnerl2cap-tester success Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerbnep-tester success Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnermgmt-tester success Total: 493, Passed: 493 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerrfcomm-tester success Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersco-tester success Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersmp-tester success Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneruserchan-tester success Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

Commit Message

Tom Rix March 31, 2022, 5:49 p.m. UTC 
From: Tom Rix <trix@redhat.com>

cppcheck returns this warning
btintel.c:1059]: (warning) Function 'btintel_download_firmware'
  argument order different: declaration
  'dev, fw, boot_param, ' definition 'hdev, ver, fw, boot_param'

By inspection, the stub version is missing
'struct intel_version *ver', so add it.

Fixes: ac0565462e33 ("Bluetooth: btintel: Check firmware version before download")
Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/bluetooth/btintel.h | 1 +
 1 file changed, 1 insertion(+)

Comments

bluez.test.bot@gmail.com March 31, 2022, 7:11 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=627929

---Test result---

Test Summary:
CheckPatch                    PASS      1.67 seconds
GitLint                       PASS      1.05 seconds
SubjectPrefix                 PASS      0.85 seconds
BuildKernel                   PASS      37.40 seconds
BuildKernel32                 PASS      33.34 seconds
Incremental Build with patchesPASS      44.96 seconds
TestRunner: Setup             PASS      553.75 seconds
TestRunner: l2cap-tester      PASS      17.89 seconds
TestRunner: bnep-tester       PASS      7.27 seconds
TestRunner: mgmt-tester       PASS      116.35 seconds
TestRunner: rfcomm-tester     PASS      9.48 seconds
TestRunner: sco-tester        PASS      9.23 seconds
TestRunner: smp-tester        PASS      8.94 seconds
TestRunner: userchan-tester   PASS      7.59 seconds



---
Regards,
Linux Bluetooth
Marcel Holtmann April 1, 2022, 5:22 p.m. UTC | #2 
Hi Tom,

> On Mar 31, 2022, at 19:49, trix@redhat.com wrote:
> 
> <Mail Attachment>

please fix your email client to send this properly inline. Or use git-send-email.

Regards

Marcel
Tom Rix April 1, 2022, 5:33 p.m. UTC | #3 
On 4/1/22 10:22 AM, Marcel Holtmann wrote:
> Hi Tom,
>
>> On Mar 31, 2022, at 19:49, trix@redhat.com wrote:
>>
>> <Mail Attachment>
> please fix your email client to send this properly inline. Or use git-send-email.

I did use git-send-email.

I am not sure what the problem is.

Tom

>
> Regards
>
> Marcel
>
diff mbox series

Patch

diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index e0060e58573c..66902866a5c1 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -281,6 +281,7 @@  static inline int btintel_read_boot_params(struct hci_dev *hdev,
 }
 
 static inline int btintel_download_firmware(struct hci_dev *dev,
+					    struct intel_version *ver,
 					    const struct firmware *fw,
 					    u32 *boot_param)
 {