diff mbox series

[BlueZ,1/4] monitor/att: Print attribute information on ATT_REQ_RSP

Message ID 20220617004957.1148939-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit c53cb7be2d61e7bdf26c20f61f94d572068d5c6b
Headers show
Series [BlueZ,1/4] monitor/att: Print attribute information on ATT_REQ_RSP | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck success Make Check PASS
tedd_an/makecheckvalgrind success Make Check PASS
tedd_an/makedistcheck success Make Distcheck PASS
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make success Build Make with External ELL PASS
tedd_an/incremental_build success Pass

Commit Message

Luiz Augusto von Dentz June 17, 2022, 12:49 a.m. UTC 
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This prints the attribute information on ATT_REQ_RSP to make it easier
to identify to which handle the response is for:

> ACL Data RX: Handle 42 flags 0x02 dlen 9
      Channel: 65 len 5 sdu 3 [PSM 39 mode Enhanced Credit (0x81)] {chan 1}
      ATT: Read Response (0x0b) len 2
        Value: 0300
        Handle: 0x0030 Type: Source ASE (0x2bc5)
            ASE ID: 3
            State: Idle (0x00)
---
 monitor/att.c | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

Comments

bluez.test.bot@gmail.com June 17, 2022, 5:28 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=651225

---Test result---

Test Summary:
CheckPatch                    FAIL      6.23 seconds
GitLint                       PASS      4.01 seconds
Prep - Setup ELL              PASS      44.24 seconds
Build - Prep                  PASS      0.68 seconds
Build - Configure             PASS      8.79 seconds
Build - Make                  PASS      1783.85 seconds
Make Check                    PASS      11.64 seconds
Make Check w/Valgrind         PASS      475.19 seconds
Make Distcheck                PASS      244.82 seconds
Build w/ext ELL - Configure   PASS      9.09 seconds
Build w/ext ELL - Make        PASS      1725.65 seconds
Incremental Build with patchesPASS      7055.43 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,4/4] monitor/att: Add LTV deconding support for PAC/ASE
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#86: 
      Channel: 65 len 27 sdu 25 [PSM 39 mode Enhanced Credit (0x81)] {chan 1}

/github/workspace/src/12885016.patch total: 0 errors, 1 warnings, 770 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12885016.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org June 17, 2022, 9:10 p.m. UTC | #2 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 16 Jun 2022 17:49:54 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This prints the attribute information on ATT_REQ_RSP to make it easier
> to identify to which handle the response is for:
> 
> > ACL Data RX: Handle 42 flags 0x02 dlen 9
>       Channel: 65 len 5 sdu 3 [PSM 39 mode Enhanced Credit (0x81)] {chan 1}
>       ATT: Read Response (0x0b) len 2
>         Value: 0300
>         Handle: 0x0030 Type: Source ASE (0x2bc5)
>             ASE ID: 3
>             State: Idle (0x00)
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/4] monitor/att: Print attribute information on ATT_REQ_RSP
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c53cb7be2d61
  - [BlueZ,2/4] monitor/att: Add decoding support for PAC Sink/Source Location
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5da3c0387baf
  - [BlueZ,3/4] monitor/att: Add decoding support for PAC Audio Context
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2bdb79cf8173
  - [BlueZ,4/4] monitor/att: Add LTV deconding support for PAC/ASE
    (no matching commit)

You are awesome, thank you!
diff mbox series

Patch

diff --git a/monitor/att.c b/monitor/att.c
index de70a9dc4..34babac6b 100644
--- a/monitor/att.c
+++ b/monitor/att.c
@@ -1290,17 +1290,12 @@  static struct gatt_db_attribute *get_attribute(const struct l2cap_frame *frame,
 	return gatt_db_get_attribute(db, handle);
 }
 
-static void print_handle(const struct l2cap_frame *frame, uint16_t handle,
-								bool rsp)
+static void print_attribute(struct gatt_db_attribute *attr)
 {
-	struct gatt_db_attribute *attr;
+	uint16_t handle = gatt_db_attribute_get_handle(attr);
 	const bt_uuid_t *uuid;
 	char label[21];
 
-	attr = get_attribute(frame, handle, rsp);
-	if (!attr)
-		goto done;
-
 	uuid = gatt_db_attribute_get_type(attr);
 	if (!uuid)
 		goto done;
@@ -1323,6 +1318,20 @@  done:
 	print_field("Handle: 0x%4.4x", handle);
 }
 
+static void print_handle(const struct l2cap_frame *frame, uint16_t handle,
+								bool rsp)
+{
+	struct gatt_db_attribute *attr;
+
+	attr = get_attribute(frame, handle, rsp);
+	if (!attr) {
+		print_field("Handle: 0x%4.4x", handle);
+		return;
+	}
+
+	print_attribute(attr);
+}
+
 static void att_read_req(const struct l2cap_frame *frame)
 {
 	const struct bt_l2cap_att_read_req *pdu = frame->data;
@@ -1393,6 +1402,8 @@  static void att_read_rsp(const struct l2cap_frame *frame)
 	if (!read)
 		return;
 
+	print_attribute(read->attr);
+
 	read->func(frame);
 
 	free(read);