Bluetooth: Add default wakeup callback for HCI UART driver

Commit Message

Ying Hsu July 4, 2022, 10:33 a.m. UTC

Bluetooth HCI devices indicate if they are able to wakeup in the wakeup
callback since 'commit 4539ca67fe8e ("Bluetooth: Rename driver
.prevent_wake to .wakeup")'. This patch adds a default wakeup callback
for Bluetooth HCI UAR devices. It assumes Bluetooth HCI UART devices are
wakeable for backward compatibility. For those who need a customized
behavior, one can override it before calling hci_uart_register_device().

Fixes: 4539ca67fe8e ("Bluetooth: Rename driver .prevent_wake to .wakeup")
Signed-off-by: Ying Hsu <[e-mail]>
Reviewed-by: Alain Michaud <[e-mail]>
---
Tested this commit on trogdor (wcn399x) and hayato (RTL8822-UART).
For platforms with QCA UART connectivity, such as trogdor, we revert the
commit c1a74160eaf1 ("Bluetooth: hci_qca: Add device_may_wakeup
support") downstream as qca_wakeup() returns false and breaks wake-on-bt.

 drivers/bluetooth/hci_serdev.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

[e-mail] July 4, 2022, 11:07 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=656284

---Test result---

Test Summary:
CheckPatch                    FAIL      1.75 seconds
GitLint                       PASS      0.96 seconds
SubjectPrefix                 PASS      0.80 seconds
BuildKernel                   PASS      31.48 seconds
BuildKernel32                 PASS      26.88 seconds
Incremental Build with patchesPASS      37.68 seconds
TestRunner: Setup             PASS      463.74 seconds
TestRunner: l2cap-tester      PASS      16.58 seconds
TestRunner: bnep-tester       PASS      5.69 seconds
TestRunner: mgmt-tester       PASS      94.94 seconds
TestRunner: rfcomm-tester     PASS      9.05 seconds
TestRunner: sco-tester        PASS      8.93 seconds
TestRunner: smp-tester        PASS      8.91 seconds
TestRunner: userchan-tester   PASS      5.92 seconds

Details
##############################
Test: CheckPatch - FAIL - 1.75 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: Add default wakeup callback for HCI UART driver\ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fatal: unsaf ("ace/src' is owned by someone else)")'
#82: 
callback since 'commit 4539ca67fe8e ("Bluetooth: Rename driver
.prevent_wake to .wakeup")'. This patch adds a default wakeup callback

total: 1 errors, 0 warnings, 23 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12905037.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth

[e-mail] July 20, 2022, 4:20 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Mon,  4 Jul 2022 18:33:24 +0800 you wrote:
> Bluetooth HCI devices indicate if they are able to wakeup in the wakeup
> callback since 'commit 4539ca67fe8e ("Bluetooth: Rename driver
> .prevent_wake to .wakeup")'. This patch adds a default wakeup callback
> for Bluetooth HCI UAR devices. It assumes Bluetooth HCI UART devices are
> wakeable for backward compatibility. For those who need a customized
> behavior, one can override it before calling hci_uart_register_device().
> 
> [...]

Here is the summary with links:
  - Bluetooth: Add default wakeup callback for HCI UART driver
    https://git.kernel.org/bluetooth/bluetooth-next/c/db52f939ccf8

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
index 4cda890ce647..c0e5f42ec6b7 100644
--- a/drivers/bluetooth/hci_serdev.c
+++ b/drivers/bluetooth/hci_serdev.c
@@ -231,6 +231,15 @@  static int hci_uart_setup(struct hci_dev *hdev)
 	return 0;
 }
 
+/* Check if the device is wakeable */
+static bool hci_uart_wakeup(struct hci_dev *hdev)
+{
+	/* HCI UART devices are assumed to be wakeable by default.
+	 * Implement wakeup callback to override this behavior.
+	 */
+	return true;
+}
+
 /** hci_uart_write_wakeup - transmit buffer wakeup
  * @serdev: serial device
  *
@@ -342,6 +351,8 @@  int hci_uart_register_device(struct hci_uart *hu,
 	hdev->flush = hci_uart_flush;
 	hdev->send  = hci_uart_send_frame;
 	hdev->setup = hci_uart_setup;
+	if (!hdev->wakeup)
+		hdev->wakeup = hci_uart_wakeup;
 	SET_HCIDEV_DEV(hdev, &hu->serdev->dev);
 
 	if (test_bit(HCI_UART_NO_SUSPEND_NOTIFIER, &hu->flags))