diff mbox series

Bluetooth: hci_sync: Fix opcode format in debug message

Message ID 20220724212639.29269-1-ismael@iodev.co.uk (mailing list archive)
State Superseded
Headers show
Series Bluetooth: hci_sync: Fix opcode format in debug message | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch fail Bluetooth: hci_sync: Fix opcode format in debug message\WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 8 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/12927635.patch has style problems, please review. NOTE: Ignored message types: UNKNOWN_COMMIT_ID NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
tedd_an/gitlint success Gitlint PASS
tedd_an/subjectprefix success PASS
tedd_an/buildkernel success Build Kernel PASS
tedd_an/buildkernel32 success Build Kernel32 PASS
tedd_an/incremental_build success Pass
tedd_an/testrunnersetup success Test Runner Setup PASS
tedd_an/testrunnerl2cap-tester success Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerbnep-tester success Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnermgmt-tester success Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerrfcomm-tester success Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersco-tester success Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersmp-tester success Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneruserchan-tester success Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

Commit Message

Ismael Luceno July 24, 2022, 9:26 p.m. UTC 
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com July 24, 2022, 10:03 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=662601

---Test result---

Test Summary:
CheckPatch                    FAIL      1.37 seconds
GitLint                       PASS      0.83 seconds
SubjectPrefix                 PASS      0.62 seconds
BuildKernel                   PASS      37.10 seconds
BuildKernel32                 PASS      32.02 seconds
Incremental Build with patchesPASS      49.05 seconds
TestRunner: Setup             PASS      536.08 seconds
TestRunner: l2cap-tester      PASS      16.75 seconds
TestRunner: bnep-tester       PASS      6.11 seconds
TestRunner: mgmt-tester       PASS      99.35 seconds
TestRunner: rfcomm-tester     PASS      9.41 seconds
TestRunner: sco-tester        PASS      9.12 seconds
TestRunner: smp-tester        PASS      9.25 seconds
TestRunner: userchan-tester   PASS      6.28 seconds

Details
##############################
Test: CheckPatch - FAIL - 1.37 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: hci_sync: Fix opcode format in debug message\WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12927635.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz July 26, 2022, 6:58 p.m. UTC | #2 
Hi Ismael,

On Sun, Jul 24, 2022 at 2:26 PM Ismael Luceno <ismael@iodev.co.uk> wrote:

Add some description, perhaps the debug output before and after the changes.

> Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
> ---
>  net/bluetooth/hci_sync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
> index 351c2390164d..d86d819465e8 100644
> --- a/net/bluetooth/hci_sync.c
> +++ b/net/bluetooth/hci_sync.c
> @@ -150,7 +150,7 @@
>         struct sk_buff *skb;
>         int err = 0;
>
> -       bt_dev_dbg(hdev, "Opcode 0x%4x", opcode);
> +       bt_dev_dbg(hdev, "Opcode 0x%04x", opcode);
>
>         hci_req_init(&req, hdev);
>
> --
> 2.36.0
>
diff mbox series

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 351c2390164d..d86d819465e8 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -150,7 +150,7 @@ 
 	struct sk_buff *skb;
 	int err = 0;
 
-	bt_dev_dbg(hdev, "Opcode 0x%4x", opcode);
+	bt_dev_dbg(hdev, "Opcode 0x%04x", opcode);
 
 	hci_req_init(&req, hdev);