diff mbox series

[BlueZ,1/2] mesh: Clear addr field if virt sub failed

Message ID 20220923113149.14209-2-isak.westin@loytec.com (mailing list archive)
State Accepted
Commit 32d866b4df928aa1d7785da7f83d089f64d42797
Headers show
Series Mesh: Fixes to comply with mesh profile | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck success Make Check PASS
tedd_an/makecheckvalgrind success Make Check PASS
tedd_an/makedistcheck success Make Distcheck PASS
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make success Build Make with External ELL PASS
tedd_an/incremental_build success Pass
tedd_an/scan_build success Pass

Commit Message

Isak Westin Sept. 23, 2022, 11:31 a.m. UTC 
If processing failed for a Config Model Subscription Virtual Address
Add/Delete/Overwrite message, the address field in the status reply
should be set to zero. See MshPRFv1.0.1 section 4.4.1.2.8.
---
 mesh/cfgmod-server.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

bluez.test.bot@gmail.com Sept. 23, 2022, 1:53 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679853

---Test result---

Test Summary:
CheckPatch                    PASS      2.24 seconds
GitLint                       PASS      1.67 seconds
Prep - Setup ELL              PASS      36.89 seconds
Build - Prep                  PASS      0.81 seconds
Build - Configure             PASS      8.60 seconds
Build - Make                  PASS      1240.83 seconds
Make Check                    PASS      12.09 seconds
Make Check w/Valgrind         PASS      400.43 seconds
Make Distcheck                PASS      252.41 seconds
Build w/ext ELL - Configure   PASS      8.77 seconds
Build w/ext ELL - Make        PASS      139.00 seconds
Incremental Build w/ patches  PASS      314.75 seconds
Scan Build                    PASS      873.87 seconds



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/mesh/cfgmod-server.c b/mesh/cfgmod-server.c
index c1e1faa6a..9bc2f1c97 100644
--- a/mesh/cfgmod-server.c
+++ b/mesh/cfgmod-server.c
@@ -286,6 +286,10 @@  static uint16_t cfg_virt_sub_add_msg(struct mesh_node *node, const uint8_t *pkt,
 						label, true, addr, opcode))
 		msg[n] = MESH_STATUS_STORAGE_FAIL;
 
+	/* If processing failed, set addr field to zero in reply */
+	if (msg[n] != MESH_STATUS_SUCCESS)
+		addr = UNASSIGNED_ADDRESS;
+
 	l_put_le16(ele_addr, msg + n + 1);
 	l_put_le16(addr, msg + n + 3);