| Message ID | 20221006143343.199055-2-abhay.maheshbhai.maheta@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Media Control Profile Client | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=683505
---Test result---
Test Summary:
CheckPatch FAIL 5.09 seconds
GitLint PASS 1.96 seconds
Prep - Setup ELL PASS 31.81 seconds
Build - Prep PASS 0.67 seconds
Build - Configure PASS 10.15 seconds
Build - Make FAIL 12.78 seconds
Make Check FAIL 33.53 seconds
Make Check w/Valgrind FAIL 19.54 seconds
Make Distcheck FAIL 13.15 seconds
Build w/ext ELL - Configure PASS 10.24 seconds
Build w/ext ELL - Make FAIL 4.95 seconds
Incremental Build w/ patches FAIL 136.59 seconds
Scan Build FAIL 636.05 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,2/4] shared/mcp: Add initial code for handling MCP
ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
#113: FILE: src/shared/mcp.c:19:
+ * License along with this library; if not, write to the Free Software$
ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
#114: FILE: src/shared/mcp.c:20:
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#179: FILE: src/shared/mcp.c:85:
+ struct bt_mcp_session_info session;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: src/shared/mcp.c:90:
+ bt_mcp_debug_func_t debug_func;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#185: FILE: src/shared/mcp.c:91:
+ bt_mcp_destroy_func_t debug_destroy;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: src/shared/mcp.c:92:
+ void *debug_data;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#545: FILE: src/shared/mcp.c:451:
+ &uuid,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#545: FILE: src/shared/mcp.c:451:
+ &uuid,$
WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#555: FILE: src/shared/mcp.c:461:
+ mcs->track_title = gatt_db_service_add_characteristic(mcs->service, &uuid,
WARNING:LONG_LINE: line length of 90 exceeds 80 columns
#573: FILE: src/shared/mcp.c:479:
+ BT_GATT_CHRC_PROP_READ | BT_GATT_CHRC_PROP_WRITE |
WARNING:LONG_LINE: line length of 90 exceeds 80 columns
#575: FILE: src/shared/mcp.c:481:
+ mcs_track_position_read, mcs_track_position_write,
WARNING:LONG_LINE: line length of 90 exceeds 80 columns
#582: FILE: src/shared/mcp.c:488:
+ BT_GATT_CHRC_PROP_READ | BT_GATT_CHRC_PROP_WRITE |
WARNING:LONG_LINE: line length of 90 exceeds 80 columns
#584: FILE: src/shared/mcp.c:490:
+ mcs_playback_speed_read, mcs_playback_speed_write,
ERROR:CODE_INDENT: code indent should use tabs where possible
#589: FILE: src/shared/mcp.c:495:
+ &uuid,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#589: FILE: src/shared/mcp.c:495:
+ &uuid,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#590: FILE: src/shared/mcp.c:496:
+ BT_ATT_PERM_READ,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#590: FILE: src/shared/mcp.c:496:
+ BT_ATT_PERM_READ,$
WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#596: FILE: src/shared/mcp.c:502:
+ mcs->play_order = gatt_db_service_add_characteristic(mcs->service, &uuid,
WARNING:LONG_LINE: line length of 90 exceeds 80 columns
#598: FILE: src/shared/mcp.c:504:
+ BT_GATT_CHRC_PROP_READ | BT_GATT_CHRC_PROP_WRITE |
WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#600: FILE: src/shared/mcp.c:506:
+ mcs_playing_order_read, mcs_playing_order_write,
WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#604: FILE: src/shared/mcp.c:510:
+ mcs->play_order_supported = gatt_db_service_add_characteristic(mcs->service,
WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#612: FILE: src/shared/mcp.c:518:
+ mcs->media_state = gatt_db_service_add_characteristic(mcs->service, &uuid,
WARNING:LONG_LINE: line length of 90 exceeds 80 columns
#614: FILE: src/shared/mcp.c:520:
+ BT_GATT_CHRC_PROP_READ | BT_GATT_CHRC_PROP_NOTIFY,
WARNING:LONG_LINE: line length of 92 exceeds 80 columns
#624: FILE: src/shared/mcp.c:530:
+ BT_GATT_CHRC_PROP_WRITE | BT_GATT_CHRC_PROP_NOTIFY |
WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#633: FILE: src/shared/mcp.c:539:
+ mcs->media_cp_op_supportd = gatt_db_service_add_characteristic(mcs->service,
WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#641: FILE: src/shared/mcp.c:547:
+ mcs->content_control_id = gatt_db_service_add_characteristic(mcs->service,
WARNING:LONG_LINE: line length of 90 exceeds 80 columns
#644: FILE: src/shared/mcp.c:550:
+ BT_GATT_CHRC_PROP_READ | BT_GATT_CHRC_PROP_NOTIFY,
WARNING:LONG_LINE: line length of 86 exceeds 80 columns
#778: FILE: src/shared/mcp.c:684:
+ DBG(mcp, "Unable to read media player name: error 0x%02x", att_ecode);
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#814: FILE: src/shared/mcp.c:720:
+ DBG(mcp, "Unable to read track duration: error 0x%02x", att_ecode);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#818: FILE: src/shared/mcp.c:724:
+ if (length != sizeof(duration)) {
+ DBG(mcp, "Wrong length received Length : %u", length);
+ }
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#834: FILE: src/shared/mcp.c:740:
+ DBG(mcp, "Unable to read track position: error 0x%02x", att_ecode);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#838: FILE: src/shared/mcp.c:744:
+ if (length != sizeof(position)) {
+ DBG(mcp, "Wrong length received Length : %u", length);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#857: FILE: src/shared/mcp.c:763:
+ if (length != sizeof(uint8_t)) {
+ DBG(mcp, "Wrong length received Length : %u", length);
+ }
WARNING:LONG_LINE_STRING: line length of 83 exceeds 80 columns
#871: FILE: src/shared/mcp.c:777:
+ DBG(mcp, "Unable to read media CP opcodes supported: error 0x%02x",
WARNING:BRACES: braces {} are not necessary for single statement blocks
#876: FILE: src/shared/mcp.c:782:
+ if (length != sizeof(uint32_t)) {
+ DBG(mcp, "Wrong length received Length : %u", length);
+ }
WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#892: FILE: src/shared/mcp.c:798:
+ DBG(mcp, "Unable to read content control id: error 0x%02x", att_ecode);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#896: FILE: src/shared/mcp.c:802:
+ if (length != sizeof(uint8_t)) {
+ DBG(mcp, "Wrong length received Length : %u", length);
+ }
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#947: FILE: src/shared/mcp.c:853:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#950: FILE: src/shared/mcp.c:856:
+ DBG(mcp, "Media Player Name notification failed: 0x%04x", att_ecode);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#966: FILE: src/shared/mcp.c:872:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#969: FILE: src/shared/mcp.c:875:
+ DBG(mcp, "Media Track Changed notification failed: 0x%04x", att_ecode);
ERROR:CODE_INDENT: code indent should use tabs where possible
#973: FILE: src/shared/mcp.c:879:
+ const uint8_t *value, uint16_t length, void *user_data)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#973: FILE: src/shared/mcp.c:879:
+ const uint8_t *value, uint16_t length, void *user_data)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#986: FILE: src/shared/mcp.c:892:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#989: FILE: src/shared/mcp.c:895:
+ DBG(mcp, "Media Track Title notification failed: 0x%04x", att_ecode);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1002: FILE: src/shared/mcp.c:908:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#1005: FILE: src/shared/mcp.c:911:
+ DBG(mcp, "Media Track Duration notification failed: 0x%04x", att_ecode);
ERROR:CODE_INDENT: code indent should use tabs where possible
#1009: FILE: src/shared/mcp.c:915:
+ const uint8_t *value, uint16_t length, void *user_data)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1009: FILE: src/shared/mcp.c:915:
+ const uint8_t *value, uint16_t length, void *user_data)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1020: FILE: src/shared/mcp.c:926:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#1023: FILE: src/shared/mcp.c:929:
+ DBG(mcp, "Media Track Position notification failed: 0x%04x", att_ecode);
ERROR:CODE_INDENT: code indent should use tabs where possible
#1027: FILE: src/shared/mcp.c:933:
+ const uint8_t *value, uint16_t length, void *user_data)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1027: FILE: src/shared/mcp.c:933:
+ const uint8_t *value, uint16_t length, void *user_data)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1038: FILE: src/shared/mcp.c:944:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#1041: FILE: src/shared/mcp.c:947:
+ DBG(mcp, "Media Media State notification failed: 0x%04x", att_ecode);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1054: FILE: src/shared/mcp.c:960:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#1057: FILE: src/shared/mcp.c:963:
+ DBG(mcp, "Media Media CP notification failed: 0x%04x", att_ecode);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1063: FILE: src/shared/mcp.c:969:
+ struct bt_mcp *mcp = user_data;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1069: FILE: src/shared/mcp.c:975:
+ void *user_data)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1069: FILE: src/shared/mcp.c:975:
+ void *user_data)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1071: FILE: src/shared/mcp.c:977:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE_STRING: line length of 83 exceeds 80 columns
#1074: FILE: src/shared/mcp.c:980:
+ DBG(mcp, "Media Media CP OP Supported notification failed: 0x%04x",
WARNING:LONG_LINE: line length of 95 exceeds 80 columns
#1079: FILE: src/shared/mcp.c:985:
+ const uint8_t *value, uint16_t length, void *user_data)
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1081: FILE: src/shared/mcp.c:987:
+ struct bt_mcp *mcp = user_data;$
WARNING:LONG_LINE: line length of 95 exceeds 80 columns
#1102: FILE: src/shared/mcp.c:1008:
+ value_handle, mcp_mp_name_register, mcp_mp_name_notify,
WARNING:LONG_LINE: line length of 89 exceeds 80 columns
#1118: FILE: src/shared/mcp.c:1024:
+ value_handle, mcp_track_changed_register,
WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#1119: FILE: src/shared/mcp.c:1025:
+ mcp_track_changed_notify, mcp, NULL);
WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#1154: FILE: src/shared/mcp.c:1060:
+ value_handle, mcp_track_duration_register,
WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#1172: FILE: src/shared/mcp.c:1078:
+ value_handle, mcp_track_position_register,
WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#1206: FILE: src/shared/mcp.c:1112:
+ value_handle, mcp_media_cp_register,
ERROR:CODE_INDENT: code indent should use tabs where possible
#1220: FILE: src/shared/mcp.c:1126:
+ value_handle);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1220: FILE: src/shared/mcp.c:1126:
+ value_handle);$
WARNING:LONG_LINE: line length of 94 exceeds 80 columns
#1225: FILE: src/shared/mcp.c:1131:
+ mcp->client, value_handle, mcp_media_cp_op_supported_register,
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#1238: FILE: src/shared/mcp.c:1144:
+ DBG(mcp, "Media Content Control id Supported handle 0x%04x", value_handle);
WARNING:LONG_LINE: line length of 91 exceeds 80 columns
#1247: FILE: src/shared/mcp.c:1153:
+ uuid_track_duration, uuid_track_position, uuid_media_state,
WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#1264: FILE: src/shared/mcp.c:1170:
+ MEDIA_CP_OP_SUPPORTED_CHRC_UUID);
WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#1266: FILE: src/shared/mcp.c:1172:
+ MEDIA_CONTENT_CONTROL_ID_CHRC_UUID);
WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#1269: FILE: src/shared/mcp.c:1175:
+ DBG(mcp, "Media Player Name found: handle 0x%04x", value_handle);
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#1336: FILE: src/shared/mcp.c:1242:
+ DBG(mcp, "Media Control Point found: handle 0x%04x", value_handle);
WARNING:LONG_LINE_STRING: line length of 87 exceeds 80 columns
#1347: FILE: src/shared/mcp.c:1253:
+ DBG(mcp, "Media Control Point Opecodes Supported found: handle 0x%04x",
WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#1359: FILE: src/shared/mcp.c:1265:
+ DBG(mcp, "Content Control ID found: handle 0x%04x", value_handle);
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#1522: FILE: src/shared/mcp.h:14:
+#define __packed __attribute__((packed))
WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#1543: FILE: src/shared/mcp.h:35:
+ void (*play_order_supported)(struct bt_mcp *mcp, uint16_t order_supported);
/github/workspace/src/13000447.patch total: 10 errors, 73 warnings, 1540 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
/github/workspace/src/13000447.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,3/4] profiles: Add initial code for mcp plugin
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#381: FILE: profiles/audio/mcp.c:270:
+ bt_mcp_set_debug(data->mcp, mcp_debug, NULL, NULL);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#396: FILE: profiles/audio/mcp.c:285:
+ if (data->mp) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#397: FILE: profiles/audio/mcp.c:286:
+ media_player_destroy(data->mp);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#397: FILE: profiles/audio/mcp.c:286:
+ media_player_destroy(data->mp);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#398: FILE: profiles/audio/mcp.c:287:
+ data->mp = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#398: FILE: profiles/audio/mcp.c:287:
+ data->mp = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#399: FILE: profiles/audio/mcp.c:288:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#477: FILE: profiles/audio/mcp.c:366:
+ if (data->mp) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#478: FILE: profiles/audio/mcp.c:367:
+ media_player_destroy(data->mp);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#478: FILE: profiles/audio/mcp.c:367:
+ media_player_destroy(data->mp);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#479: FILE: profiles/audio/mcp.c:368:
+ data->mp = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#479: FILE: profiles/audio/mcp.c:368:
+ data->mp = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#480: FILE: profiles/audio/mcp.c:369:
+ }$
WARNING:LINE_SPACING: Missing a blank line after declarations
#493: FILE: profiles/audio/mcp.c:382:
+ struct btd_gatt_database *database = btd_adapter_get_database(adapter);
+ bt_mcp_register(btd_gatt_database_get_db(database));
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#521: FILE: profiles/audio/mcp.c:410:
+ if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL)) {
+ warn("D-Bus experimental not enabled");
ERROR:CODE_INDENT: code indent should use tabs where possible
#522: FILE: profiles/audio/mcp.c:411:
+ warn("D-Bus experimental not enabled");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#522: FILE: profiles/audio/mcp.c:411:
+ warn("D-Bus experimental not enabled");$
ERROR:CODE_INDENT: code indent should use tabs where possible
#523: FILE: profiles/audio/mcp.c:412:
+ return -ENOTSUP;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#523: FILE: profiles/audio/mcp.c:412:
+ return -ENOTSUP;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#526: FILE: profiles/audio/mcp.c:415:
+ btd_profile_register(&mcp_profile);$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#534: FILE: profiles/audio/mcp.c:423:
+ if (g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL) {
+ btd_profile_unregister(&mcp_profile);
+ }
/github/workspace/src/13000445.patch total: 6 errors, 15 warnings, 450 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
/github/workspace/src/13000445.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,4/4] monitor/att: Add decoding support for GMCS
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: monitor/att.c:1754:
+ char utf8_name[HCI_MAX_NAME_LENGTH + 2];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: monitor/att.c:1755:
+ int i;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: monitor/att.c:1757:
+ if (g_utf8_validate((const char *) name, len, NULL))$
ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: monitor/att.c:1758:
+ return g_strndup((char *) name, len);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: monitor/att.c:1758:
+ return g_strndup((char *) name, len);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: monitor/att.c:1760:
+ len = MIN(len, sizeof(utf8_name) - 1);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#121: FILE: monitor/att.c:1762:
+ memset(utf8_name, 0, sizeof(utf8_name));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: monitor/att.c:1763:
+ strncpy(utf8_name, (char *) name, len);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#125: FILE: monitor/att.c:1766:
+ for (i = 0; utf8_name[i] != '\0'; i++) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#126: FILE: monitor/att.c:1767:
+ if (!isascii(utf8_name[i]))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: monitor/att.c:1767:
+ if (!isascii(utf8_name[i]))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#126: FILE: monitor/att.c:1767:
+ if (!isascii(utf8_name[i]))
+ utf8_name[i] = ' ';
ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: monitor/att.c:1768:
+ utf8_name[i] = ' ';$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: monitor/att.c:1768:
+ utf8_name[i] = ' ';$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: monitor/att.c:1769:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: monitor/att.c:1772:
+ g_strstrip(utf8_name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: monitor/att.c:1774:
+ return g_strdup(utf8_name);$
WARNING:LONG_LINE_STRING: line length of 86 exceeds 80 columns
#383: FILE: monitor/att.c:2024:
+ print_text(COLOR_ERROR, " Supported Playing Orders: invalid size");
WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#387: FILE: monitor/att.c:2028:
+ print_field(" Supported Playing Orders: 0x%4.4x", supported_orders);
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#451: FILE: monitor/att.c:2092:
+ {0x02 , "Pause"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#452: FILE: monitor/att.c:2093:
+ {0x03 , "Fast Rewind"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#453: FILE: monitor/att.c:2094:
+ {0x04 , "Fast Forward"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#454: FILE: monitor/att.c:2095:
+ {0x05 , "Stop"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#455: FILE: monitor/att.c:2096:
+ {0x10 , "Move Relative"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#456: FILE: monitor/att.c:2097:
+ {0x20 , "Previous Segment"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#457: FILE: monitor/att.c:2098:
+ {0x21 , "Next Segment"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#458: FILE: monitor/att.c:2099:
+ {0x22 , "First Segment"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#459: FILE: monitor/att.c:2100:
+ {0x23 , "Last Segment"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#460: FILE: monitor/att.c:2101:
+ {0x24 , "Goto Segment"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#461: FILE: monitor/att.c:2102:
+ {0x30 , "Previous Track"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#462: FILE: monitor/att.c:2103:
+ {0x31 , "Next Track"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#463: FILE: monitor/att.c:2104:
+ {0x32 , "First Track"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#464: FILE: monitor/att.c:2105:
+ {0x33 , "Last Track"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#465: FILE: monitor/att.c:2106:
+ {0x34 , "Goto Track"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#466: FILE: monitor/att.c:2107:
+ {0x40 , "Previous Group"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#467: FILE: monitor/att.c:2108:
+ {0x41 , "Next Group"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#468: FILE: monitor/att.c:2109:
+ {0x42 , "First Group"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#469: FILE: monitor/att.c:2110:
+ {0x43 , "Last Group"},
^
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#470: FILE: monitor/att.c:2111:
+ {0x44 , "Goto Group"},
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#514: FILE: monitor/att.c:2155:
+ {0^I, "Play (0x00000001)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#514: FILE: monitor/att.c:2155:
+ {0 , "Play (0x00000001)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#515: FILE: monitor/att.c:2156:
+ {1^I, "Pause (0x00000002)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#515: FILE: monitor/att.c:2156:
+ {1 , "Pause (0x00000002)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#516: FILE: monitor/att.c:2157:
+ {2^I, "Fast Rewind^I(0x00000004)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#516: FILE: monitor/att.c:2157:
+ {2 , "Fast Rewind (0x00000004)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#517: FILE: monitor/att.c:2158:
+ {3^I, "Fast Forward (0x00000008)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#517: FILE: monitor/att.c:2158:
+ {3 , "Fast Forward (0x00000008)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#518: FILE: monitor/att.c:2159:
+ {4^I, "Stop (0x00000010)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#518: FILE: monitor/att.c:2159:
+ {4 , "Stop (0x00000010)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#519: FILE: monitor/att.c:2160:
+ {5^I, "Move Relative (0x00000020)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#519: FILE: monitor/att.c:2160:
+ {5 , "Move Relative (0x00000020)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#520: FILE: monitor/att.c:2161:
+ {6^I, "Previous Segment (0x00000040)"^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#520: FILE: monitor/att.c:2161:
+ {6 , "Previous Segment (0x00000040)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#521: FILE: monitor/att.c:2162:
+ {7^I, "Next Segment (0x00000080)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#521: FILE: monitor/att.c:2162:
+ {7 , "Next Segment (0x00000080)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#522: FILE: monitor/att.c:2163:
+ {8^I, "First Segment (0x00000100)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#522: FILE: monitor/att.c:2163:
+ {8 , "First Segment (0x00000100)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#523: FILE: monitor/att.c:2164:
+ {9^I, "Last Segment (0x00000200)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#523: FILE: monitor/att.c:2164:
+ {9 , "Last Segment (0x00000200)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#524: FILE: monitor/att.c:2165:
+ {10^I, "Goto Segment (0x00000400)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#524: FILE: monitor/att.c:2165:
+ {10 , "Goto Segment (0x00000400)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#525: FILE: monitor/att.c:2166:
+ {11^I, "Previous Track (0x00000800)" },$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#525: FILE: monitor/att.c:2166:
+ {11 , "Previous Track (0x00000800)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#526: FILE: monitor/att.c:2167:
+ {12^I, "Next Track (0x00001000)"^I^I },$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#526: FILE: monitor/att.c:2167:
+ {12 , "Next Track (0x00001000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#527: FILE: monitor/att.c:2168:
+ {13^I, "First Track (0x00002000)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#527: FILE: monitor/att.c:2168:
+ {13 , "First Track (0x00002000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#528: FILE: monitor/att.c:2169:
+ {14^I, "Last Track (0x00004000)"^I^I },$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#528: FILE: monitor/att.c:2169:
+ {14 , "Last Track (0x00004000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#529: FILE: monitor/att.c:2170:
+ {15^I, "Goto Track (0x00008000)"^I^I },$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#529: FILE: monitor/att.c:2170:
+ {15 , "Goto Track (0x00008000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#530: FILE: monitor/att.c:2171:
+ {16^I, "Previous Group (0x00010000)"^I },$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#530: FILE: monitor/att.c:2171:
+ {16 , "Previous Group (0x00010000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#531: FILE: monitor/att.c:2172:
+ {17^I, "Next Group (0x00020000)"^I^I },$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#531: FILE: monitor/att.c:2172:
+ {17 , "Next Group (0x00020000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#532: FILE: monitor/att.c:2173:
+ {18^I, "First Group (0x00040000)"^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#532: FILE: monitor/att.c:2173:
+ {18 , "First Group (0x00040000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#533: FILE: monitor/att.c:2174:
+ {19^I, "Last Group (0x00080000)"^I^I },$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#533: FILE: monitor/att.c:2174:
+ {19 , "Last Group (0x00080000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#534: FILE: monitor/att.c:2175:
+ {20 , "Goto Group (0x00100000)"^I^I },$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#534: FILE: monitor/att.c:2175:
+ {20 , "Goto Group (0x00100000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#535: FILE: monitor/att.c:2176:
+ {21^I, "RFU (0x00200000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#535: FILE: monitor/att.c:2176:
+ {21 , "RFU (0x00200000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#536: FILE: monitor/att.c:2177:
+ {22^I, "RFU (0x00400000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#536: FILE: monitor/att.c:2177:
+ {22 , "RFU (0x00400000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#537: FILE: monitor/att.c:2178:
+ {23^I, "RFU (0x00800000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#537: FILE: monitor/att.c:2178:
+ {23 , "RFU (0x00800000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#538: FILE: monitor/att.c:2179:
+ {24^I, "RFU (0x01000000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#538: FILE: monitor/att.c:2179:
+ {24 , "RFU (0x01000000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#539: FILE: monitor/att.c:2180:
+ {25^I, "RFU (0x02000000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#539: FILE: monitor/att.c:2180:
+ {25 , "RFU (0x02000000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#540: FILE: monitor/att.c:2181:
+ {26^I, "RFU (0x04000000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#540: FILE: monitor/att.c:2181:
+ {26 , "RFU (0x04000000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#541: FILE: monitor/att.c:2182:
+ {27^I, "RFU (0x08000000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#541: FILE: monitor/att.c:2182:
+ {27 , "RFU (0x08000000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#542: FILE: monitor/att.c:2183:
+ {28^I, "RFU (0x10000000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#542: FILE: monitor/att.c:2183:
+ {28 , "RFU (0x10000000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#543: FILE: monitor/att.c:2184:
+ {29^I, "RFU (0x20000000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#543: FILE: monitor/att.c:2184:
+ {29 , "RFU (0x20000000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#544: FILE: monitor/att.c:2185:
+ {30^I, "RFU (0x40000000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#544: FILE: monitor/att.c:2185:
+ {30 , "RFU (0x40000000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#545: FILE: monitor/att.c:2186:
+ {31^I, "RFU (0x80000000)"^I^I^I^I},$
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#545: FILE: monitor/att.c:2186:
+ {31 , "RFU (0x80000000)" },
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#546: FILE: monitor/att.c:2187:
+ { }$
/github/workspace/src/13000446.patch total: 55 errors, 49 warnings, 535 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
/github/workspace/src/13000446.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
src/shared/mcp.c: In function ‘read_track_title’:
src/shared/mcp.c:699:25: error: unused variable ‘cb’ [-Werror=unused-variable]
699 | struct event_callback *cb = mcp->cb;
| ^~
src/shared/mcp.c: At top level:
src/shared/mcp.c:994:6: error: no previous declaration for ‘bt_mcp_mp_name_attach’ [-Werror=missing-declarations]
994 | void bt_mcp_mp_name_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1012:6: error: no previous declaration for ‘bt_mcp_track_changed_attach’ [-Werror=missing-declarations]
1012 | void bt_mcp_track_changed_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1028:6: error: no previous declaration for ‘bt_mcp_track_title_attach’ [-Werror=missing-declarations]
1028 | void bt_mcp_track_title_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1046:6: error: no previous declaration for ‘bt_mcp_track_duration_attach’ [-Werror=missing-declarations]
1046 | void bt_mcp_track_duration_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1064:6: error: no previous declaration for ‘bt_mcp_track_position_attach’ [-Werror=missing-declarations]
1064 | void bt_mcp_track_position_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1082:6: error: no previous declaration for ‘bt_mcp_media_state_attach’ [-Werror=missing-declarations]
1082 | void bt_mcp_media_state_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1100:6: error: no previous declaration for ‘bt_mcp_media_cp_attach’ [-Werror=missing-declarations]
1100 | void bt_mcp_media_cp_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1116:6: error: no previous declaration for ‘bt_mcp_media_cp_op_supported_attach’ [-Werror=missing-declarations]
1116 | void bt_mcp_media_cp_op_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1135:6: error: no previous declaration for ‘bt_mcp_content_control_id_supported_attach’ [-Werror=missing-declarations]
1135 | void bt_mcp_content_control_id_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c: In function ‘bt_mcp_attach’:
src/shared/mcp.c:1381:12: error: unused variable ‘value_handle’ [-Werror=unused-variable]
1381 | uint16_t value_handle;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8235: src/shared/libshared_mainloop_la-mcp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4465: all] Error 2
##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
src/shared/mcp.c: In function ‘read_track_title’:
src/shared/mcp.c:699:25: error: unused variable ‘cb’ [-Werror=unused-variable]
699 | struct event_callback *cb = mcp->cb;
| ^~
src/shared/mcp.c: At top level:
src/shared/mcp.c:994:6: error: no previous declaration for ‘bt_mcp_mp_name_attach’ [-Werror=missing-declarations]
994 | void bt_mcp_mp_name_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1012:6: error: no previous declaration for ‘bt_mcp_track_changed_attach’ [-Werror=missing-declarations]
1012 | void bt_mcp_track_changed_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1028:6: error: no previous declaration for ‘bt_mcp_track_title_attach’ [-Werror=missing-declarations]
1028 | void bt_mcp_track_title_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1046:6: error: no previous declaration for ‘bt_mcp_track_duration_attach’ [-Werror=missing-declarations]
1046 | void bt_mcp_track_duration_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1064:6: error: no previous declaration for ‘bt_mcp_track_position_attach’ [-Werror=missing-declarations]
1064 | void bt_mcp_track_position_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1082:6: error: no previous declaration for ‘bt_mcp_media_state_attach’ [-Werror=missing-declarations]
1082 | void bt_mcp_media_state_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1100:6: error: no previous declaration for ‘bt_mcp_media_cp_attach’ [-Werror=missing-declarations]
1100 | void bt_mcp_media_cp_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1116:6: error: no previous declaration for ‘bt_mcp_media_cp_op_supported_attach’ [-Werror=missing-declarations]
1116 | void bt_mcp_media_cp_op_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1135:6: error: no previous declaration for ‘bt_mcp_content_control_id_supported_attach’ [-Werror=missing-declarations]
1135 | void bt_mcp_content_control_id_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c: In function ‘bt_mcp_attach’:
src/shared/mcp.c:1381:12: error: unused variable ‘value_handle’ [-Werror=unused-variable]
1381 | uint16_t value_handle;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8032: src/shared/libshared_glib_la-mcp.lo] Error 1
make: *** [Makefile:11650: check] Error 2
##############################
Test: Make Check w/Valgrind - FAIL
Desc: Run 'make check' with Valgrind
Output:
src/shared/mcp.c: In function ‘read_track_title’:
src/shared/mcp.c:699:25: error: unused variable ‘cb’ [-Werror=unused-variable]
699 | struct event_callback *cb = mcp->cb;
| ^~
src/shared/mcp.c: At top level:
src/shared/mcp.c:994:6: error: no previous declaration for ‘bt_mcp_mp_name_attach’ [-Werror=missing-declarations]
994 | void bt_mcp_mp_name_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1012:6: error: no previous declaration for ‘bt_mcp_track_changed_attach’ [-Werror=missing-declarations]
1012 | void bt_mcp_track_changed_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1028:6: error: no previous declaration for ‘bt_mcp_track_title_attach’ [-Werror=missing-declarations]
1028 | void bt_mcp_track_title_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1046:6: error: no previous declaration for ‘bt_mcp_track_duration_attach’ [-Werror=missing-declarations]
1046 | void bt_mcp_track_duration_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1064:6: error: no previous declaration for ‘bt_mcp_track_position_attach’ [-Werror=missing-declarations]
1064 | void bt_mcp_track_position_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1082:6: error: no previous declaration for ‘bt_mcp_media_state_attach’ [-Werror=missing-declarations]
1082 | void bt_mcp_media_state_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1100:6: error: no previous declaration for ‘bt_mcp_media_cp_attach’ [-Werror=missing-declarations]
1100 | void bt_mcp_media_cp_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1116:6: error: no previous declaration for ‘bt_mcp_media_cp_op_supported_attach’ [-Werror=missing-declarations]
1116 | void bt_mcp_media_cp_op_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1135:6: error: no previous declaration for ‘bt_mcp_content_control_id_supported_attach’ [-Werror=missing-declarations]
1135 | void bt_mcp_content_control_id_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c: In function ‘bt_mcp_attach’:
src/shared/mcp.c:1381:12: error: unused variable ‘value_handle’ [-Werror=unused-variable]
1381 | uint16_t value_handle;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8235: src/shared/libshared_mainloop_la-mcp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4465: all] Error 2
##############################
Test: Make Distcheck - FAIL
Desc: Run distcheck to check the distribution
Output:
make[2]: *** No rule to make target 'shared/mcs.h', needed by 'distdir-am'. Stop.
make[1]: *** [Makefile:11483: distdir] Error 2
make: *** [Makefile:11559: dist] Error 2
##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
src/shared/mcp.c: In function ‘read_track_title’:
src/shared/mcp.c:699:25: error: unused variable ‘cb’ [-Werror=unused-variable]
699 | struct event_callback *cb = mcp->cb;
| ^~
src/shared/mcp.c: At top level:
src/shared/mcp.c:994:6: error: no previous declaration for ‘bt_mcp_mp_name_attach’ [-Werror=missing-declarations]
994 | void bt_mcp_mp_name_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1012:6: error: no previous declaration for ‘bt_mcp_track_changed_attach’ [-Werror=missing-declarations]
1012 | void bt_mcp_track_changed_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1028:6: error: no previous declaration for ‘bt_mcp_track_title_attach’ [-Werror=missing-declarations]
1028 | void bt_mcp_track_title_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1046:6: error: no previous declaration for ‘bt_mcp_track_duration_attach’ [-Werror=missing-declarations]
1046 | void bt_mcp_track_duration_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1064:6: error: no previous declaration for ‘bt_mcp_track_position_attach’ [-Werror=missing-declarations]
1064 | void bt_mcp_track_position_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1082:6: error: no previous declaration for ‘bt_mcp_media_state_attach’ [-Werror=missing-declarations]
1082 | void bt_mcp_media_state_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1100:6: error: no previous declaration for ‘bt_mcp_media_cp_attach’ [-Werror=missing-declarations]
1100 | void bt_mcp_media_cp_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1116:6: error: no previous declaration for ‘bt_mcp_media_cp_op_supported_attach’ [-Werror=missing-declarations]
1116 | void bt_mcp_media_cp_op_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1135:6: error: no previous declaration for ‘bt_mcp_content_control_id_supported_attach’ [-Werror=missing-declarations]
1135 | void bt_mcp_content_control_id_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c: In function ‘bt_mcp_attach’:
src/shared/mcp.c:1381:12: error: unused variable ‘value_handle’ [-Werror=unused-variable]
1381 | uint16_t value_handle;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8235: src/shared/libshared_mainloop_la-mcp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4465: all] Error 2
##############################
Test: Incremental Build w/ patches - FAIL
Desc: Incremental build per patch in the series
Output:
src/shared/mcp.c: In function ‘read_track_title’:
src/shared/mcp.c:699:25: error: unused variable ‘cb’ [-Werror=unused-variable]
699 | struct event_callback *cb = mcp->cb;
| ^~
src/shared/mcp.c: At top level:
src/shared/mcp.c:994:6: error: no previous declaration for ‘bt_mcp_mp_name_attach’ [-Werror=missing-declarations]
994 | void bt_mcp_mp_name_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1012:6: error: no previous declaration for ‘bt_mcp_track_changed_attach’ [-Werror=missing-declarations]
1012 | void bt_mcp_track_changed_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1028:6: error: no previous declaration for ‘bt_mcp_track_title_attach’ [-Werror=missing-declarations]
1028 | void bt_mcp_track_title_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1046:6: error: no previous declaration for ‘bt_mcp_track_duration_attach’ [-Werror=missing-declarations]
1046 | void bt_mcp_track_duration_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1064:6: error: no previous declaration for ‘bt_mcp_track_position_attach’ [-Werror=missing-declarations]
1064 | void bt_mcp_track_position_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1082:6: error: no previous declaration for ‘bt_mcp_media_state_attach’ [-Werror=missing-declarations]
1082 | void bt_mcp_media_state_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1100:6: error: no previous declaration for ‘bt_mcp_media_cp_attach’ [-Werror=missing-declarations]
1100 | void bt_mcp_media_cp_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1116:6: error: no previous declaration for ‘bt_mcp_media_cp_op_supported_attach’ [-Werror=missing-declarations]
1116 | void bt_mcp_media_cp_op_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1135:6: error: no previous declaration for ‘bt_mcp_content_control_id_supported_attach’ [-Werror=missing-declarations]
1135 | void bt_mcp_content_control_id_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c: In function ‘bt_mcp_attach’:
src/shared/mcp.c:1381:12: error: unused variable ‘value_handle’ [-Werror=unused-variable]
1381 | uint16_t value_handle;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8226: src/shared/libshared_mainloop_la-mcp.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4460: all] Error 2
##############################
Test: Scan Build - FAIL
Desc: Run Scan Build with patches
Output:
client/player.c:1756:25: warning: Dereference of null pointer
iov_append(&cfg->caps, preset->data.iov_base, preset->data.iov_len);
^~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/shared/ad.c:369:19: warning: Use of zero-allocated memory
buf[(*pos)++] = ad_type;
^
1 warning generated.
src/shared/gatt-client.c:387:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:600:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:900:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1009:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1185:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1250:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1521:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1526:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2028:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2036:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3119:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3141:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
src/shared/mcp.c: In function ‘read_track_title’:
src/shared/mcp.c:699:25: error: unused variable ‘cb’ [-Werror=unused-variable]
699 | struct event_callback *cb = mcp->cb;
| ^~
src/shared/mcp.c: At top level:
src/shared/mcp.c:994:6: error: no previous declaration for ‘bt_mcp_mp_name_attach’ [-Werror=missing-declarations]
994 | void bt_mcp_mp_name_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1012:6: error: no previous declaration for ‘bt_mcp_track_changed_attach’ [-Werror=missing-declarations]
1012 | void bt_mcp_track_changed_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1028:6: error: no previous declaration for ‘bt_mcp_track_title_attach’ [-Werror=missing-declarations]
1028 | void bt_mcp_track_title_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1046:6: error: no previous declaration for ‘bt_mcp_track_duration_attach’ [-Werror=missing-declarations]
1046 | void bt_mcp_track_duration_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1064:6: error: no previous declaration for ‘bt_mcp_track_position_attach’ [-Werror=missing-declarations]
1064 | void bt_mcp_track_position_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1082:6: error: no previous declaration for ‘bt_mcp_media_state_attach’ [-Werror=missing-declarations]
1082 | void bt_mcp_media_state_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1100:6: error: no previous declaration for ‘bt_mcp_media_cp_attach’ [-Werror=missing-declarations]
1100 | void bt_mcp_media_cp_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1116:6: error: no previous declaration for ‘bt_mcp_media_cp_op_supported_attach’ [-Werror=missing-declarations]
1116 | void bt_mcp_media_cp_op_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c:1135:6: error: no previous declaration for ‘bt_mcp_content_control_id_supported_attach’ [-Werror=missing-declarations]
1135 | void bt_mcp_content_control_id_supported_attach(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/mcp.c: In function ‘bt_mcp_attach’:
src/shared/mcp.c:1381:12: error: unused variable ‘value_handle’ [-Werror=unused-variable]
1381 | uint16_t value_handle;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8032: src/shared/libshared_glib_la-mcp.lo] Error 1
make: *** [Makefile:4465: all] Error 2
---
Regards,
Linux Bluetooth
diff --git a/lib/uuid.h b/lib/uuid.h index f667a74b9..d5e5665e4 100644 --- a/lib/uuid.h +++ b/lib/uuid.h @@ -171,6 +171,21 @@ extern "C" { #define VOL_CP_CHRC_UUID 0x2B7E #define VOL_FLAG_CHRC_UUID 0x2B7F +#define GMCS_UUID 0x1849 +#define MEDIA_PLAYER_NAME_CHRC_UUID 0x2b93 +#define MEDIA_TRACK_CHNGD_CHRC_UUID 0x2b96 +#define MEDIA_TRACK_TITLE_CHRC_UUID 0x2b97 +#define MEDIA_TRACK_DURATION_CHRC_UUID 0x2b98 +#define MEDIA_TRACK_POSTION_CHRC_UUID 0x2b99 +#define MEDIA_PLAYBACK_SPEED_CHRC_UUID 0x2b9a +#define MEDIA_SEEKING_SPEED_CHRC_UUID 0x2b9b +#define MEDIA_PLAYING_ORDER_CHRC_UUID 0x2ba1 +#define MEDIA_PLAY_ORDER_SUPPRTD_CHRC_UUID 0x2ba2 +#define MEDIA_STATE_CHRC_UUID 0x2ba3 +#define MEDIA_CP_CHRC_UUID 0x2ba4 +#define MEDIA_CP_OP_SUPPORTED_CHRC_UUID 0x2ba5 +#define MEDIA_CONTENT_CONTROL_ID_CHRC_UUID 0x2bba + typedef struct { enum { BT_UUID_UNSPEC = 0,