diff mbox series

[BlueZ,1/2] settings: Fix scan-build warning

Message ID 20221018212800.3967256-1-luiz.dentz@gmail.com (mailing list archive)
State Superseded
Headers show
Series [BlueZ,1/2] settings: Fix scan-build warning | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck success Make Check PASS
tedd_an/makecheckvalgrind success Make Check PASS
tedd_an/makedistcheck success Make Distcheck PASS
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make success Build Make with External ELL PASS
tedd_an/incremental_build success Pass
tedd_an/scan_build success Pass

Commit Message

Luiz Augusto von Dentz Oct. 18, 2022, 9:27 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the following warning:

src/settings.c:281:7: warning: Branch condition evaluates to a garbage
value [core.uninitialized.Branch]
                if (ret) {
                    ^~~
---
 src/settings.c | 1 +
 1 file changed, 1 insertion(+)

Comments

bluez.test.bot@gmail.com Oct. 18, 2022, 10:37 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=686460

---Test result---

Test Summary:
CheckPatch                    PASS      2.22 seconds
GitLint                       PASS      1.56 seconds
Prep - Setup ELL              PASS      32.57 seconds
Build - Prep                  PASS      0.82 seconds
Build - Configure             PASS      10.55 seconds
Build - Make                  PASS      992.64 seconds
Make Check                    PASS      12.63 seconds
Make Check w/Valgrind         PASS      351.85 seconds
Make Distcheck                PASS      293.36 seconds
Build w/ext ELL - Configure   PASS      10.54 seconds
Build w/ext ELL - Make        PASS      103.89 seconds
Incremental Build w/ patches  PASS      248.67 seconds
Scan Build                    PASS      631.14 seconds



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/src/settings.c b/src/settings.c
index 0f053000610b..85534f2c7aca 100644
--- a/src/settings.c
+++ b/src/settings.c
@@ -269,6 +269,7 @@  static int gatt_db_load(struct gatt_db *db, GKeyFile *key_file, char **keys)
 							&primary, &uuid);
 
 			bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+			ret = 0;
 		} else if (g_str_equal(type, GATT_INCLUDE_UUID_STR)) {
 			ret = load_incl(db, *handle, value, current_service);
 		} else if (g_str_equal(type, GATT_CHARAC_UUID_STR)) {