diff mbox series

[BlueZ,v2,1/3] settings: Fix scan-build warning

Message ID 20221018234600.3990980-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit 9c739ba22f094496381a6bce88ed4c118ef020b9
Headers show
Series [BlueZ,v2,1/3] settings: Fix scan-build warning | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck success Make Check PASS
tedd_an/makecheckvalgrind success Make Check PASS
tedd_an/makedistcheck success Make Distcheck PASS
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make success Build Make with External ELL PASS
tedd_an/incremental_build success Pass
tedd_an/scan_build success Pass

Commit Message

Luiz Augusto von Dentz Oct. 18, 2022, 11:45 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the following warning:

src/settings.c:281:7: warning: Branch condition evaluates to a garbage
value [core.uninitialized.Branch]
                if (ret) {
                    ^~~
---
 src/settings.c | 1 +
 1 file changed, 1 insertion(+)

Comments

bluez.test.bot@gmail.com Oct. 19, 2022, 12:51 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=686498

---Test result---

Test Summary:
CheckPatch                    PASS      3.39 seconds
GitLint                       PASS      2.35 seconds
Prep - Setup ELL              PASS      34.58 seconds
Build - Prep                  PASS      1.00 seconds
Build - Configure             PASS      11.02 seconds
Build - Make                  PASS      1177.12 seconds
Make Check                    PASS      13.47 seconds
Make Check w/Valgrind         PASS      370.82 seconds
Make Distcheck                PASS      311.71 seconds
Build w/ext ELL - Configure   PASS      11.27 seconds
Build w/ext ELL - Make        PASS      112.47 seconds
Incremental Build w/ patches  PASS      397.01 seconds
Scan Build                    PASS      702.70 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Oct. 19, 2022, 8:40 p.m. UTC | #2
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 18 Oct 2022 16:45:58 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes the following warning:
> 
> src/settings.c:281:7: warning: Branch condition evaluates to a garbage
> value [core.uninitialized.Branch]
>                 if (ret) {
>                     ^~~
> 
> [...]

Here is the summary with links:
  - [BlueZ,v2,1/3] settings: Fix scan-build warning
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9c739ba22f09
  - [BlueZ,v2,2/3] monitor/att: Detect cache changes
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a49b47f241ce
  - [BlueZ,v2,3/3] monitor/att: Revert treating Notification/Indication as a request
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=68155e2f7e66

You are awesome, thank you!
diff mbox series

Patch

diff --git a/src/settings.c b/src/settings.c
index 0f053000610b..85534f2c7aca 100644
--- a/src/settings.c
+++ b/src/settings.c
@@ -269,6 +269,7 @@  static int gatt_db_load(struct gatt_db *db, GKeyFile *key_file, char **keys)
 							&primary, &uuid);
 
 			bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+			ret = 0;
 		} else if (g_str_equal(type, GATT_INCLUDE_UUID_STR)) {
 			ret = load_incl(db, *handle, value, current_service);
 		} else if (g_str_equal(type, GATT_CHARAC_UUID_STR)) {