| Message ID | 20221021234617.28848-1-inga.stotland@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/subjectprefix | success | PASS |
| tedd_an/buildkernel | success | Build Kernel PASS |
| tedd_an/buildkernel32 | success | Build Kernel32 PASS |
| tedd_an/incremental_build | success | Pass |
| tedd_an/testrunnersetup | success | Test Runner Setup PASS |
| tedd_an/testrunnerl2cap-tester | success | Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneriso-tester | success | Total: 55, Passed: 55 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerbnep-tester | success | Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermgmt-tester | success | Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerrfcomm-tester | success | Total: 11, Passed: 11 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersco-tester | success | Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerioctl-tester | success | Total: 28, Passed: 28 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermesh-tester | success | Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersmp-tester | success | Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneruserchan-tester | success | Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0 |
Hi Inga, On Fri, Oct 21, 2022 at 4:50 PM Inga Stotland <inga.stotland@intel.com> wrote: > > When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS > command, use the correct op code in error status report: > was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS. Please add the Fixes tag: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes > Signed-off-by: Inga Stotland <inga.stotland@intel.com> > --- > net/bluetooth/mgmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c > index a92e7e485feb..0dd30a3beb77 100644 > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev, > * extra parameters we don't know about will be ignored in this request. > */ > if (data_len < MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE) > - return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING, > + return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_EXT_ADV_PARAMS, > MGMT_STATUS_INVALID_PARAMS); > > flags = __le32_to_cpu(cp->flags); > -- > 2.37.3 >
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=687718 ---Test result--- Test Summary: CheckPatch PASS 0.91 seconds GitLint PASS 0.48 seconds SubjectPrefix PASS 0.32 seconds BuildKernel PASS 43.52 seconds BuildKernel32 PASS 38.52 seconds Incremental Build with patchesPASS 57.31 seconds TestRunner: Setup PASS 629.88 seconds TestRunner: l2cap-tester PASS 20.01 seconds TestRunner: iso-tester PASS 20.06 seconds TestRunner: bnep-tester PASS 7.60 seconds TestRunner: mgmt-tester PASS 126.26 seconds TestRunner: rfcomm-tester PASS 12.24 seconds TestRunner: sco-tester PASS 11.24 seconds TestRunner: ioctl-tester PASS 12.99 seconds TestRunner: mesh-tester PASS 9.48 seconds TestRunner: smp-tester PASS 11.29 seconds TestRunner: userchan-tester PASS 8.17 seconds --- Regards, Linux Bluetooth
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index a92e7e485feb..0dd30a3beb77 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev, * extra parameters we don't know about will be ignored in this request. */ if (data_len < MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE) - return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING, + return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_EXT_ADV_PARAMS, MGMT_STATUS_INVALID_PARAMS); flags = __le32_to_cpu(cp->flags);
When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS command, use the correct op code in error status report: was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS. Signed-off-by: Inga Stotland <inga.stotland@intel.com> --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)