diff mbox series

[BlueZ,v3,1/7] shared/util: Update UUID database for Csip services

Message ID 20221122101232.45320-2-sathish.narasimman@intel.com (mailing list archive)
State New, archived
Headers show
Series Csip - Client role | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Sathish Narasimman Nov. 22, 2022, 10:12 a.m. UTC 
This updates UUID database with the values from assigned numbers for
co-ordinated set identification services.
---
 src/shared/util.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

bluez.test.bot@gmail.com Nov. 22, 2022, 12:38 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=698015

---Test result---

Test Summary:
CheckPatch                    FAIL      5.01 seconds
GitLint                       PASS      2.58 seconds
BuildEll                      PASS      32.32 seconds
BluezMake                     PASS      986.05 seconds
MakeCheck                     PASS      12.80 seconds
MakeDistcheck                 PASS      174.43 seconds
CheckValgrind                 PASS      290.29 seconds
bluezmakeextell               PASS      114.13 seconds
IncrementalBuild              PASS      5622.11 seconds
ScanBuild                     PASS      1194.14 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v3,3/7] main.conf: Add CSIP profile configurable options
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#119: FILE: src/main.c:152:
+static const char *csip_options[] = {

/github/workspace/src/src/13052136.patch total: 0 errors, 1 warnings, 199 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13052136.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


[BlueZ,v3,4/7] shared/csip: Add initial code for handling CSIP
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#668: FILE: src/shared/csip.h:16:
+#define __packed __attribute__((packed))

/github/workspace/src/src/13052137.patch total: 0 errors, 1 warnings, 605 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13052137.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz Nov. 22, 2022, 8:03 p.m. UTC | #2 
Hi Sathish,

On Tue, Nov 22, 2022 at 2:16 AM Sathish Narasimman
<sathish.narasimman@intel.com> wrote:
>
> This updates UUID database with the values from assigned numbers for
> co-ordinated set identification services.
> ---
>  src/shared/util.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/shared/util.c b/src/shared/util.c
> index 333023e0dcac..d7fbd2322f7b 100644
> --- a/src/shared/util.c
> +++ b/src/shared/util.c
> @@ -695,6 +695,9 @@ static const struct {
>         { 0x2b82, "Volume Offset Control Point"                 },
>         { 0x2b83, "Audio Output Description"                    },
>         { 0x2b84, "Set Identity Resolving Key"                  },
> +       { 0x2b85, "Csis Size"                                   },
> +       { 0x2b86, "Csis Lock"                                   },
> +       { 0x2b87, "Csis Rank"                                   },

Use the actual attribute name rather than its services e.g:
Coordinated Set Size, etc.

>         { 0x2b93, "Media Player Name"                           },
>         { 0x2b94, "Media Player Icon Object ID"                 },
>         { 0x2b95, "Media Player Icon URL"                       },
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/src/shared/util.c b/src/shared/util.c
index 333023e0dcac..d7fbd2322f7b 100644
--- a/src/shared/util.c
+++ b/src/shared/util.c
@@ -695,6 +695,9 @@  static const struct {
 	{ 0x2b82, "Volume Offset Control Point"			},
 	{ 0x2b83, "Audio Output Description"			},
 	{ 0x2b84, "Set Identity Resolving Key"			},
+	{ 0x2b85, "Csis Size"					},
+	{ 0x2b86, "Csis Lock"					},
+	{ 0x2b87, "Csis Rank"					},
 	{ 0x2b93, "Media Player Name"				},
 	{ 0x2b94, "Media Player Icon Object ID"			},
 	{ 0x2b95, "Media Player Icon URL"			},