| Message ID | 20221205150928.4017973-2-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: don't call kfree_skb() under spin_lock_irqsave() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=701842 ---Test result--- Test Summary: CheckPatch PASS 3.46 seconds GitLint PASS 1.70 seconds SubjectPrefix PASS 0.57 seconds BuildKernel PASS 33.24 seconds BuildKernel32 PASS 28.37 seconds TestRunnerSetup PASS 404.37 seconds TestRunner_l2cap-tester PASS 15.09 seconds TestRunner_iso-tester PASS 14.79 seconds TestRunner_bnep-tester PASS 5.12 seconds TestRunner_mgmt-tester PASS 100.60 seconds TestRunner_rfcomm-tester PASS 8.91 seconds TestRunner_sco-tester PASS 8.29 seconds TestRunner_ioctl-tester PASS 10.00 seconds TestRunner_mesh-tester PASS 7.11 seconds TestRunner_smp-tester PASS 8.63 seconds TestRunner_userchan-tester PASS 5.54 seconds IncrementalBuild PASS 60.74 seconds --- Regards, Linux Bluetooth
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 8df11016fd51..69c5cedda6d2 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -912,8 +912,9 @@ static int qca_enqueue(struct hci_uart *hu, struct sk_buff *skb) default: BT_ERR("Illegal tx state: %d (losing packet)", qca->tx_ibs_state); + spin_unlock_irqrestore(&qca->hci_ibs_lock, flags); kfree_skb(skb); - break; + return 0; } spin_unlock_irqrestore(&qca->hci_ibs_lock, flags);
It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. Call it after the spin_unlock_irqrestore(). Fixes: 0ff252c1976d ("Bluetooth: hciuart: Add support QCA chipset for UART") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/bluetooth/hci_qca.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)