diff mbox series

[BlueZ,v3,4/6] media-api: Add CompanyID, VendorCodecID, Metadata

Message ID 20221229155257.341327-5-abhay.maheshbhai.maheta@intel.com (mailing list archive)
State New, archived
Headers show
Series To add support for Metadata, CID, VID | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Abhay Maheta Dec. 29, 2022, 3:53 p.m. UTC 
This adds CompanyID, VendorCodecID, Metadata for RegisterEndpoint method
---
 doc/media-api.txt | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Luiz Augusto von Dentz Jan. 4, 2023, 12:26 a.m. UTC | #1 
Hi Abhay,

On Thu, Dec 29, 2022 at 7:58 AM Abhay Maheta
<abhay.maheshbhai.maheta@intel.com> wrote:
>
> This adds CompanyID, VendorCodecID, Metadata for RegisterEndpoint method
> ---
>  doc/media-api.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/doc/media-api.txt b/doc/media-api.txt
> index 847f8bee7..7bfa8a52b 100644
> --- a/doc/media-api.txt
> +++ b/doc/media-api.txt
> @@ -34,11 +34,29 @@ Methods             void RegisterEndpoint(object endpoint, dict properties)
>                                         match the profile specification which
>                                         is indicated by the UUID.
>
> +                               uint16_t CompanyID [BAP only]:
> +
> +                                       Assigned number of Company ID that the
> +                                       endpoint implements. It should be set to
> +                                       appropriate value when Vendor Specific
> +                                       Codec is used.
> +
> +                               uint16_t VendorCodecID [BAP only]:
> +
> +                                       Vendor-specific codec ID that the endpoint
> +                                       implements. It should be set to appropriate
> +                                       value when Vendor Specific Codec is used.
> +

Check the version Ive pushed, I end up merging these 2 into a single
property called Vendor which is a tuple of Company ID, Vendor Codec
ID, so you will need to adjust the changes to bluetoothctl.

>                                 array{byte} Capabilities:
>
>                                         Capabilities blob, it is used as it is
>                                         so the size and byte order must match.
>
> +                               array{byte} Metadata [BAP only]:
> +
> +                                       Metadata blob, it is used as it is
> +                                       so the size and byte order must match.
> +
>                         Possible Errors: org.bluez.Error.InvalidArguments
>                                          org.bluez.Error.NotSupported - emitted
>                                          when interface for the end-point is
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/doc/media-api.txt b/doc/media-api.txt
index 847f8bee7..7bfa8a52b 100644
--- a/doc/media-api.txt
+++ b/doc/media-api.txt
@@ -34,11 +34,29 @@  Methods		void RegisterEndpoint(object endpoint, dict properties)
 					match the profile specification which
 					is indicated by the UUID.
 
+				uint16_t CompanyID [BAP only]:
+
+					Assigned number of Company ID that the
+					endpoint implements. It should be set to
+					appropriate value when Vendor Specific
+					Codec is used.
+
+				uint16_t VendorCodecID [BAP only]:
+
+					Vendor-specific codec ID that the endpoint
+					implements. It should be set to appropriate
+					value when Vendor Specific Codec is used.
+
 				array{byte} Capabilities:
 
 					Capabilities blob, it is used as it is
 					so the size and byte order must match.
 
+				array{byte} Metadata [BAP only]:
+
+					Metadata blob, it is used as it is
+					so the size and byte order must match.
+
 			Possible Errors: org.bluez.Error.InvalidArguments
 					 org.bluez.Error.NotSupported - emitted
 					 when interface for the end-point is