| Message ID | 20230126165529.1452252-2-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: Add support for RTL8821CS | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | warning | CheckSparse WARNING drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=715934 ---Test result--- Test Summary: CheckPatch PASS 2.17 seconds GitLint PASS 0.75 seconds SubjectPrefix FAIL 0.58 seconds BuildKernel PASS 38.49 seconds CheckAllWarning PASS 41.50 seconds CheckSparse WARNING 47.05 seconds CheckSmatch WARNING 127.35 seconds BuildKernel32 PASS 36.70 seconds TestRunnerSetup PASS 526.86 seconds TestRunner_l2cap-tester PASS 19.05 seconds TestRunner_iso-tester PASS 20.75 seconds TestRunner_bnep-tester PASS 6.80 seconds TestRunner_mgmt-tester PASS 129.94 seconds TestRunner_rfcomm-tester PASS 10.75 seconds TestRunner_sco-tester PASS 9.87 seconds TestRunner_ioctl-tester PASS 11.82 seconds TestRunner_mesh-tester PASS 8.72 seconds TestRunner_smp-tester PASS 9.75 seconds TestRunner_userchan-tester PASS 7.21 seconds IncrementalBuild PASS 40.32 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject ############################## Test: CheckSparse - WARNING Desc: Run sparse tool with linux kernel Output: drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures --- Regards, Linux Bluetooth
On 26/01/2023 17:55, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add compatible string for RTL8821CS for existing Realtek Bluetooth > driver. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 1 + > 1 file changed, 1 insertion(+) > Based on your driver it is compatible with rtl8822cs, so you can indicate it in the binding and use just one of_device_id entry. Best regards, Krzysztof
On Fri, Jan 27, 2023 at 11:24:03AM +0100, Krzysztof Kozlowski wrote: > On 26/01/2023 17:55, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > Add compatible string for RTL8821CS for existing Realtek Bluetooth > > driver. > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > --- > > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > Based on your driver it is compatible with rtl8822cs, so you can > indicate it in the binding and use just one of_device_id entry. It's very similar, and uses some of the same constants, but has a different firmware. I assumed the firmware difference is enough to require it to be differentiated, but I wasn't sure. You are saying it does not? I just want to be clear. As always, thank you. > > Best regards, > Krzysztof >
On 27/01/2023 17:46, Chris Morgan wrote: > On Fri, Jan 27, 2023 at 11:24:03AM +0100, Krzysztof Kozlowski wrote: >> On 26/01/2023 17:55, Chris Morgan wrote: >>> From: Chris Morgan <macromorgan@hotmail.com> >>> >>> Add compatible string for RTL8821CS for existing Realtek Bluetooth >>> driver. >>> >>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com> >>> --- >>> Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >> >> Based on your driver it is compatible with rtl8822cs, so you can >> indicate it in the binding and use just one of_device_id entry. > > It's very similar, and uses some of the same constants, but has a > different firmware. I assumed the firmware difference is enough to > require it to be differentiated, but I wasn't sure. You are saying > it does not? I just want to be clear. If by "differentiated" you mean "incompatible", then depends: 1. You have firmware-name property to indicate the firmware to load and then you can use one compatible to bind and just load different firmware, 2. If device variant is autodectable, it's compatible. realtek,rtl8723ds-bt also was added to the driver uselessly... Best regards, Krzysztof
On Fri, Jan 27, 2023 at 05:53:49PM +0100, Krzysztof Kozlowski wrote: > On 27/01/2023 17:46, Chris Morgan wrote: > > On Fri, Jan 27, 2023 at 11:24:03AM +0100, Krzysztof Kozlowski wrote: > >> On 26/01/2023 17:55, Chris Morgan wrote: > >>> From: Chris Morgan <macromorgan@hotmail.com> > >>> > >>> Add compatible string for RTL8821CS for existing Realtek Bluetooth > >>> driver. > >>> > >>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > >>> --- > >>> Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >> > >> Based on your driver it is compatible with rtl8822cs, so you can > >> indicate it in the binding and use just one of_device_id entry. > > > > It's very similar, and uses some of the same constants, but has a > > different firmware. I assumed the firmware difference is enough to > > require it to be differentiated, but I wasn't sure. You are saying > > it does not? I just want to be clear. > > If by "differentiated" you mean "incompatible", then depends: > 1. You have firmware-name property to indicate the firmware to load and > then you can use one compatible to bind and just load different firmware, > 2. If device variant is autodectable, it's compatible. > > realtek,rtl8723ds-bt also was added to the driver uselessly... Gotcha. They are incompatible, but the driver should be able to autodetect each device as best I can tell. In fact all of the devices listed in the bindings should be autodetectable by the driver (again, as best I can tell). Honestly though that's assuming I'm using the correct firmware, which is why I have this tagged as an RFC. I'm really hoping to get Realtek's attention for them to chime in to confirm I'm using the most recent firmware and under what license/terms the firmware can be redistributed so that the firmware may be added to linux-firmware. Assuming everything is good though, I can resubmit V2 and instead of adding a new compatible just noting that the 8822CS and 8821CS use the same bindings. Thank you. > > Best regards, > Krzysztof >
On 27/01/2023 18:00, Chris Morgan wrote: > On Fri, Jan 27, 2023 at 05:53:49PM +0100, Krzysztof Kozlowski wrote: >> On 27/01/2023 17:46, Chris Morgan wrote: >>> On Fri, Jan 27, 2023 at 11:24:03AM +0100, Krzysztof Kozlowski wrote: >>>> On 26/01/2023 17:55, Chris Morgan wrote: >>>>> From: Chris Morgan <macromorgan@hotmail.com> >>>>> >>>>> Add compatible string for RTL8821CS for existing Realtek Bluetooth >>>>> driver. >>>>> >>>>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com> >>>>> --- >>>>> Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>> >>>> Based on your driver it is compatible with rtl8822cs, so you can >>>> indicate it in the binding and use just one of_device_id entry. >>> >>> It's very similar, and uses some of the same constants, but has a >>> different firmware. I assumed the firmware difference is enough to >>> require it to be differentiated, but I wasn't sure. You are saying >>> it does not? I just want to be clear. >> >> If by "differentiated" you mean "incompatible", then depends: >> 1. You have firmware-name property to indicate the firmware to load and >> then you can use one compatible to bind and just load different firmware, >> 2. If device variant is autodectable, it's compatible. >> >> realtek,rtl8723ds-bt also was added to the driver uselessly... > > Gotcha. > > They are incompatible, but the driver should be able to autodetect each > device as best I can tell. In fact all of the devices listed in the > bindings should be autodetectable by the driver (again, as best I can > tell). Honestly though that's assuming I'm using the correct firmware, > which is why I have this tagged as an RFC. I'm really hoping to get > Realtek's attention for them to chime in to confirm I'm using the > most recent firmware and under what license/terms the firmware can > be redistributed so that the firmware may be added to linux-firmware. > > Assuming everything is good though, I can resubmit V2 and instead of > adding a new compatible just noting that the 8822CS and 8821CS use > the same bindings. They cannot use the same bindings. You always need specific compatible and this was not discussed here. What's discussed is to drop the driver change in of_device_id. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml index 143b5667abad..5af4731338c0 100644 --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml @@ -21,6 +21,7 @@ properties: - realtek,rtl8723bs-bt - realtek,rtl8723cs-bt - realtek,rtl8723ds-bt + - realtek,rtl8821cs-bt - realtek,rtl8822cs-bt device-wake-gpios: