[kernel,v1] Bluetooth: hci_qca: get wakeup status from serdev device handle

Commit Message

Zhengping Jiang Feb. 2, 2023, 5:47 p.m. UTC

Bluetooth controller attached via the UART is handled by the serdev driver.
Get the wakeup status from the device handle through serdev, instead of the
parent path.

Fixes: c1a74160eaf1 ("Bluetooth: hci_qca: Add device_may_wakeup support")
Signed-off-by: Zhengping Jiang <[e-mail]>
---

Changes in v1:
- Get wakeup status from device handle of serdev driver

 drivers/bluetooth/hci_qca.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

[e-mail] Feb. 2, 2023, 6:35 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=718272

---Test result---

Test Summary:
CheckPatch                    PASS      0.80 seconds
GitLint                       PASS      0.31 seconds
SubjectPrefix                 PASS      0.11 seconds
BuildKernel                   PASS      30.86 seconds
CheckAllWarning               PASS      34.19 seconds
CheckSparse                   PASS      38.46 seconds
CheckSmatch                   PASS      106.74 seconds
BuildKernel32                 PASS      29.81 seconds
TestRunnerSetup               PASS      431.37 seconds
TestRunner_l2cap-tester       PASS      16.26 seconds
TestRunner_iso-tester         PASS      16.50 seconds
TestRunner_bnep-tester        PASS      5.45 seconds
TestRunner_mgmt-tester        PASS      110.09 seconds
TestRunner_rfcomm-tester      PASS      8.63 seconds
TestRunner_sco-tester         PASS      8.06 seconds
TestRunner_ioctl-tester       PASS      9.33 seconds
TestRunner_mesh-tester        PASS      6.86 seconds
TestRunner_smp-tester         PASS      7.85 seconds
TestRunner_userchan-tester    PASS      5.73 seconds
IncrementalBuild              PASS      27.67 seconds



---
Regards,
Linux Bluetooth

[e-mail] Feb. 2, 2023, 9:20 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Thu,  2 Feb 2023 09:47:01 -0800 you wrote:
> Bluetooth controller attached via the UART is handled by the serdev driver.
> Get the wakeup status from the device handle through serdev, instead of the
> parent path.
> 
> Fixes: c1a74160eaf1 ("Bluetooth: hci_qca: Add device_may_wakeup support")
> Signed-off-by: Zhengping Jiang <[e-mail]>
> 
> [...]

Here is the summary with links:
  - [kernel,v1] Bluetooth: hci_qca: get wakeup status from serdev device handle
    https://git.kernel.org/bluetooth/bluetooth-next/c/3d29daf4b155

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index a5c19f32926b..3df8c3606e93 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1588,10 +1588,11 @@  static bool qca_wakeup(struct hci_dev *hdev)
 	struct hci_uart *hu = hci_get_drvdata(hdev);
 	bool wakeup;
 
-	/* UART driver handles the interrupt from BT SoC.So we need to use
-	 * device handle of UART driver to get the status of device may wakeup.
+	/* BT SoC attached through the serial bus is handled by the serdev driver.
+	 * So we need to use the device handle of the serdev driver to get the
+	 * status of device may wakeup.
 	 */
-	wakeup = device_may_wakeup(hu->serdev->ctrl->dev.parent);
+	wakeup = device_may_wakeup(&hu->serdev->ctrl->dev);
 	bt_dev_dbg(hu->hdev, "wakeup status : %d", wakeup);
 
 	return wakeup;