diff mbox series

[BlueZ] gatttool: Use consistent spacing before brackets

Message ID 20230212172402.19018-1-david.nicolson@gmail.com (mailing list archive)
State Accepted
Commit 89f535894e59b66e70213ec9ab33fd158e8f54f1
Headers show
Series [BlueZ] gatttool: Use consistent spacing before brackets | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch warning CheckSparse WARNING attrib/gatttool.c:235:23: warning: Variable length array is used.
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

David Nicolson Feb. 12, 2023, 5:24 p.m. UTC
From: Dave Nicolson <david.nicolson@gmail.com>

---
 attrib/gatttool.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

bluez.test.bot@gmail.com Feb. 12, 2023, 6:51 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=721094

---Test result---

Test Summary:
CheckPatch                    PASS      0.35 seconds
GitLint                       PASS      0.26 seconds
BuildEll                      PASS      33.20 seconds
BluezMake                     PASS      1090.59 seconds
MakeCheck                     PASS      12.80 seconds
MakeDistcheck                 PASS      183.29 seconds
CheckValgrind                 PASS      301.39 seconds
CheckSmatch                   WARNING   411.94 seconds
bluezmakeextell               PASS      122.16 seconds
IncrementalBuild              PASS      922.53 seconds
ScanBuild                     PASS      1317.16 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
attrib/gatttool.c:235:23: warning: Variable length array is used.


---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Feb. 14, 2023, 8:40 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sun, 12 Feb 2023 18:24:02 +0100 you wrote:
> From: Dave Nicolson <david.nicolson@gmail.com>
> 
> ---
>  attrib/gatttool.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Here is the summary with links:
  - [BlueZ] gatttool: Use consistent spacing before brackets
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=89f535894e59

You are awesome, thank you!
diff mbox series

Patch

diff --git a/attrib/gatttool.c b/attrib/gatttool.c
index 6a0ddfaad..2d03875b0 100644
--- a/attrib/gatttool.c
+++ b/attrib/gatttool.c
@@ -456,17 +456,17 @@  static gboolean parse_uuid(const char *key, const char *value,
 
 static GOptionEntry primary_char_options[] = {
 	{ "start", 's' , 0, G_OPTION_ARG_INT, &opt_start,
-		"Starting handle(optional)", "0x0001" },
+		"Starting handle (optional)", "0x0001" },
 	{ "end", 'e' , 0, G_OPTION_ARG_INT, &opt_end,
-		"Ending handle(optional)", "0xffff" },
+		"Ending handle (optional)", "0xffff" },
 	{ "uuid", 'u', G_OPTION_FLAG_OPTIONAL_ARG, G_OPTION_ARG_CALLBACK,
-		parse_uuid, "UUID16 or UUID128(optional)", "0x1801"},
+		parse_uuid, "UUID16 or UUID128 (optional)", "0x1801"},
 	{ NULL },
 };
 
 static GOptionEntry char_rw_options[] = {
 	{ "handle", 'a' , 0, G_OPTION_ARG_INT, &opt_handle,
-		"Read/Write characteristic by handle(required)", "0x0001" },
+		"Read/Write characteristic by handle (required)", "0x0001" },
 	{ "value", 'n' , 0, G_OPTION_ARG_STRING, &opt_value,
 		"Write characteristic value (required for write operation)",
 		"0x0001" },