| Message ID | 20230220181205.1577283-1-hj.tedd.an@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1106b28be85ac9586d1758839226e163e9030ee2 |
| Headers | show |
| Series | [BlueZ,v2] configure: Check ell path | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=723518 ---Test result--- Test Summary: CheckPatch PASS 0.30 seconds GitLint PASS 0.24 seconds BuildEll PASS 26.81 seconds BluezMake PASS 751.72 seconds MakeCheck PASS 11.17 seconds MakeDistcheck PASS 147.79 seconds CheckValgrind PASS 240.71 seconds CheckSmatch PASS 319.26 seconds bluezmakeextell PASS 95.72 seconds IncrementalBuild PASS 607.91 seconds ScanBuild PASS 941.47 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 20 Feb 2023 10:12:05 -0800 you wrote: > From: Tedd Ho-Jeong An <tedd.an@intel.com> > > If the 'enable-external-ell' is not specified in the configure parameter, > the build system assumes that the ELL source is located same level where > the bluez source is cloned. But the configure doens't check the folder > and user will get the build error while building the source. > > [...] Here is the summary with links: - [BlueZ,v2] configure: Check ell path https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1106b28be85a You are awesome, thank you!
diff --git a/configure.ac b/configure.ac index f9f0faf57..515cdf146 100644 --- a/configure.ac +++ b/configure.ac @@ -289,6 +289,11 @@ if (test "${enable_external_ell}" = "yes"); then AC_SUBST(ELL_CFLAGS) AC_SUBST(ELL_LIBS) fi +if (test "${enable_external_ell}" != "yes"); then + AC_CHECK_FILE(${srcdir}/ell/ell.h, dummy=yes, + AC_CHECK_FILE(${srcdir}/../ell/ell/ell.h, dummy=yes, + AC_MSG_ERROR(ELL source is required or use --enable-external-ell))) +fi AM_CONDITIONAL(EXTERNAL_ELL, test "${enable_external_ell}" = "yes" || (test "${enable_btpclient}" != "yes" && test "${enable_mesh}" != "yes"))
From: Tedd Ho-Jeong An <tedd.an@intel.com> If the 'enable-external-ell' is not specified in the configure parameter, the build system assumes that the ELL source is located same level where the bluez source is cloned. But the configure doens't check the folder and user will get the build error while building the source. This patch checks if the ELL source path if the 'enable-external-ell' flag is not set and throws an error if the ELL doesn't exist. --- configure.ac | 5 +++++ 1 file changed, 5 insertions(+)